From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 7B3C53858CDB for ; Wed, 17 Jan 2024 11:02:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B3C53858CDB Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B3C53858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705489379; cv=none; b=kmhJI/Dz5GmNdkQjMlucESDu1l3Yzrg4kIfxoTsv9c3EdYy1Z+azsnP7KGwNadk3orhtfGhSqQKKTqwH3ymAilrXpvhOp1iqmkAQjHsv78M45E3DV6UzGr0tewRsILq6dzoknziLZQJXOHjpXtHgVNNz1sAI3zO1QIEdtGpwYgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705489379; c=relaxed/simple; bh=ZAWFaV0wGYYa2C5qBIvNlzDvF3Ad2IBYKPdoktd4vwg=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=RWphuDcXGk/b2GzmY1wB+ZcROSwJQj6z5Hq8Gk+ksLphZEIlwVZf3KBYiZEcKF3vJUb6S4VGoEfr02cJahtEcxwugiOwWv2WtRKE8GNazXjkkRxNm+eHEe9xxtM3gs53ZA8pK2SXlZ5ktBCRkYYM+fH6vM4r4W4z/+wr9k4Ww60= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1705489377; bh=ZAWFaV0wGYYa2C5qBIvNlzDvF3Ad2IBYKPdoktd4vwg=; h=Subject:From:To:Date:In-Reply-To:References:From; b=OlNMAQTraiaEUdFrxt5pvM9jt6QD9ImViJgRYenebjL8dzldS1bwJOfjfLlRr2/Y+ BfV0idm8J5Le9VDVuJrsQtOuGbvr57HOZudeaphgxLETXWRkoVpbJcRIvzHeEUMXUU uQQj1Ra9upOcfLZZbNIHfbgTyqLZkV3oS3pAO864= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 8BD7466A00; Wed, 17 Jan 2024 06:02:56 -0500 (EST) Message-ID: <32f802c6a0c3e0fce9b12da29b98574f82ea6d1e.camel@xry111.site> Subject: Re: [PATCH v3] x86-64: Add -z mark-plt and -z nomark-plt From: Xi Ruoyao To: "H.J. Lu" , binutils@sourceware.org Date: Wed, 17 Jan 2024 19:02:53 +0800 In-Reply-To: <20230928153830.28922-1-hjl.tools@gmail.com> References: <20230928153830.28922-1-hjl.tools@gmail.com> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi H.J., When I test Binutils-2.41.90 I get 4 test failures regarding mark-plt: ./ld/ld.log:FAIL: ld-x86-64/mark-plt-1b ./ld/ld.log:FAIL: ld-x86-64/mark-plt-1d ./ld/ld.log:FAIL: ld-x86-64/mark-plt-1b-x32 ./ld/ld.log:FAIL: ld-x86-64/mark-plt-1d-x32 It seems related to --enable-default-hash-style=3Dgnu: for mark-plt-1b with --hash-style=3Dboth I get the same dump as the .d file: 0000000000001010 : 1010: ff 25 32 11 00 00 jmp *0x1132(%rip) # 2148 1016: 68 00 00 00 00 push $0x0 101b: e9 e0 ff ff ff jmp 1000 But with --hash-style=3Dgnu: 0000000000001010 : 1010: ff 25 22 11 00 00 jmp *0x1122(%rip) # 2138 1016: 68 00 00 00 00 push $0x0 101b: e9 e0 ff ff ff jmp 1000 The simplest "fix" would be adding --hash-style=3Dboth for these tests but I'm not sure if doing so is proper. On Thu, 2023-09-28 at 08:38 -0700, H.J. Lu via Binutils wrote: > diff --git a/ld/testsuite/ld-x86-64/mark-plt-1b.d b/ld/testsuite/ld-x86-6= 4/mark-plt-1b.d > new file mode 100644 > index 00000000000..dc046c031eb > --- /dev/null > +++ b/ld/testsuite/ld-x86-64/mark-plt-1b.d > @@ -0,0 +1,16 @@ > +#source: mark-plt-1.s > +#as: --64 > +#ld: -melf_x86_64 -shared -z mark-plt > +#objdump: -dw > + > +#... > +0+1010 : > + +1010: ff 25 32 11 00 00=C2=A0=C2=A0=C2=A0=C2=A0 jmp=C2=A0=C2=A0=C2=A0 = \*0x1132\(%rip\)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # 2148 > + +1016: 68 00 00 00 00=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 push=C2= =A0=C2=A0 \$0x0 > + +101b: e9 e0 ff ff ff=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 jmp=C2= =A0=C2=A0=C2=A0 1000 > + > +Disassembly of section .text: > + > +0+1020 : > + +1020: e8 eb ff ff ff=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 call=C2= =A0=C2=A0 1010 > +#pass --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University