From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87566 invoked by alias); 10 Feb 2020 16:24:55 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 87478 invoked by uid 89); 10 Feb 2020 16:24:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2020 16:24:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581351879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OuH0NmdMETTFFuYTt1WzMZpVw5ofhos3/YlsgB7+/Cg=; b=UQy4w02VOxn/UAz9BXLj75k8ncge8qAkdsdQZtXf/G346XLX2sp9Vjq5BPPswVXDl+0Hnb e5YUGc+ziAvk//tUc5GPNgtEjWFfVz/wxcyeokenAAejIwkdGd2BFApXzhGJXnywrLTJHh tf4CHlj8Wmf6ekBy2JzIabN58ebYEkA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-139-VyCz5oxPMZu9w3eltVQALA-1; Mon, 10 Feb 2020 11:24:37 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B9A9107ACC7; Mon, 10 Feb 2020 16:24:36 +0000 (UTC) Received: from [10.36.116.165] (ovpn-116-165.ams2.redhat.com [10.36.116.165]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FAFC8ED05; Mon, 10 Feb 2020 16:24:35 +0000 (UTC) Subject: Re: [PATCH] Support 'exclude' in objcopy --set-section-flags To: Fangrui Song , binutils References: <20200116085509.pttoo3atw34dbl3m@google.com> <20200203060029.a3mora6uaadropos@google.com> From: Nick Clifton Message-ID: <3390c868-a19f-e3cf-4cbd-27dfd507d43f@redhat.com> Date: Mon, 10 Feb 2020 16:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200203060029.a3mora6uaadropos@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00153.txt.bz2 Hi Fangrui, >> --set-section-flags .foo= => clear SHF_EXCLUDE >> --set-section-flags .foo=exclude => set SHF_EXCLUDE > > Ping :) Approved and applied - mostly. You also had an undocumented change to _bfd_elf_init_private_section_data() which would remove the SHF_EXCLUDE bit from sections with OS or PROC specific flags. This breaks several linker tests, and seemed to be unrelated to the main purpose of the patch, so I discarded it. Cheers Nick