From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 6BD2038582AE for ; Wed, 6 Mar 2024 01:58:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BD2038582AE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6BD2038582AE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709690320; cv=none; b=qwAbScjOaIxJ3/x2SbuNlb4oXFBSOjWZqtgJRKxRRdySVpqoWBVE0uYXQOHm975PmLSTJZVdFKC45q+4UHZxtyomdfOMjy0Nn5dC3uWWr/O3GVBJp+kf2WIw5Oe8Nk+RQPYg9BbStuQ6g1pHvouNC+iJ11Z1doWrXfd0zrx5nLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709690320; c=relaxed/simple; bh=/WCh5FYq3goaKSPkqjExYd//xtQkm1cAt4OJk/UzxhE=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=P7iCDw4l4kal0UzAb/ehTme5nJuUkCUUs/mupPMtNOFe/P0o6j5K2e/F9NxzzYsyI02hqnGvx5fFotp1xgAc6VzPBYGzwKIAei3AW1hgURQELcmz8u+94Gkj6nUaPvfU2em6zLiXbn9iha4exGpGyGz71YLT05dwLK/YU31ZxE4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.103]) by gateway (Coremail) with SMTP id _____8CxSPDLzedlEvgUAA--.53198S3; Wed, 06 Mar 2024 09:58:36 +0800 (CST) Received: from [10.20.4.103] (unknown [10.20.4.103]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxHs_JzedlZvJOAA--.13178S3; Wed, 06 Mar 2024 09:58:34 +0800 (CST) Subject: Re: [PATCH v1] LoongArch: Scan all illegal operand instructions without interruption To: WANG Xuerui , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, mengqinggang@loongson.cn, xry111@xry111.site, maskray@google.com, luweining@loongson.cn, wanglei@loongson.cn, hejinyang@loongson.cn References: <20240305113554.3393481-1-cailulu@loongson.cn> From: Lulu Cai Message-ID: <3556806e-c2f7-06ac-28eb-4ab8ccd40af3@loongson.cn> Date: Wed, 6 Mar 2024 09:58:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8AxHs_JzedlZvJOAA--.13178S3 X-CM-SenderInfo: xfdlz3tox6z05rqj20fqof0/1tbiAQAIB2Xm1+YHfQAAsG X-Coremail-Antispam: 1Uk129KBj93XoW7Aw1fAw4fGr1fAF1fur4kAFc_yoW8Xw1fpF yxArn0yrWkCFn7JrsxG345XryrJw4xtw1Y9F1fta4Skr4Fqr12vr10qrWqgFWUJ3yxWw1I qw15Xw1UuF1UtrbCm3ZEXasCq-sJn29KB7ZKAUJUUUU7529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUBjb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2kKe7AKxVWUXVWUAwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYI kI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUAVWU twAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx k0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_ Gr1l4IxYO2xFxVAFwI0_Jrv_JF1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67 AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8I cVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI 8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v2 6r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jjWlkUUUUU= X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/6/24 2:43 AM, WANG Xuerui wrote: > On 3/5/24 19:35, Lulu Cai wrote: >> Currently, gas will exit immediately and report an error when >> it sees illegal operands, and will not process the remaining >> instructions. Replace as_fatal with as_bad to check for all >> illegal operands. >> >> Add test cases for illegal operands of some instructions. >> --- >>   gas/config/tc-loongarch.c                     |  11 +- >>   .../gas/loongarch/check_bstrins-pick.d        |  18 +++ >>   .../gas/loongarch/check_bstrins-pick.s        |   9 ++ >>   gas/testsuite/gas/loongarch/illegal-oprand.l  | 113 +++++++++++++++++ >>   gas/testsuite/gas/loongarch/illegal-oprand.s  | 117 ++++++++++++++++++ > > The filename contains a typo: "operand" instead of "oprand". > Thanks for the reminder, I will revise it later. >> gas/testsuite/gas/loongarch/loongarch.exp     |   4 + >>   gas/testsuite/gas/loongarch/lvz-lbt.d         |   2 +- >>   gas/testsuite/gas/loongarch/lvz-lbt.s         |   2 +- >>   8 files changed, 269 insertions(+), 7 deletions(-) >>   create mode 100644 gas/testsuite/gas/loongarch/check_bstrins-pick.d >>   create mode 100644 gas/testsuite/gas/loongarch/check_bstrins-pick.s >>   create mode 100644 gas/testsuite/gas/loongarch/illegal-oprand.l >>   create mode 100644 gas/testsuite/gas/loongarch/illegal-oprand.s > Other than that, the code changes LGTM, thanks!