From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2050.outbound.protection.outlook.com [40.107.20.50]) by sourceware.org (Postfix) with ESMTPS id 5324A3858D28 for ; Mon, 17 Jul 2023 07:02:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5324A3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHQTw/kV4ru3jk93n4mPOk4CfHjXj1rsFZRVSEASPQ5fzGJfMnQZWDEiYD6dE/gwVsxPzmcojKZ276OprExGqQrqLyhrALBHuaabZy0puR/SoB+uZ2oadtmINf2sUFQ7EakJ9Ctipmhd5eLqQIu4p0uPzb0uRXVUcJBPaPgaTuTHILpS1CEq/rVGN8L6hDrcNafuU1MprLrH6V14MG36jZLJWdSaxEMrCswjnuy6eVQwye3HUF0wHTkoobdgZbUWO2gyZGiPJBTRH+9Rm1NCUq1EJ659Jygvef7jqalZWAXvhUOFoSuQMeS48Q46YPzF6vukTsGcJFkQubuUl2tjKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EYiQzf7iVvt1e3fpxxst941iR97ucXsSEto/YJkwaCY=; b=CtvU5R3I/l1C3qDfZ7Hqbqwi/wBjgAsf/d8pw4mHV+Ua2LpAXHUowZ7/ec1310W9Tjk9RnDKqUn9wbuRQjB+1WpxmXUNWzYJu8VBmZjRiFvwI5An28mi2DUplzd7bzL+X07eRPBbtFbwmp4bOwyXX4CW7EQxrP5JDFNyyTRn6N7rhhppLv6q3T8pxpGYC+fim+5XpW7Yvq0wzJ7hUHmHcJO53/Ns2dqe5RlBX/edz6jeDxNa49HasQzq5BRpOlnW78PERNuiku+THaJR1qZSm64u7wDGIf/axHLwYQpNCjIQvMDq686kLN1OyhyiJFTHZuNa2wJBMzfhtynYq/ds0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EYiQzf7iVvt1e3fpxxst941iR97ucXsSEto/YJkwaCY=; b=UmHyDk/lFtiAI8z8/egFohgDuqLAZr39rF4MuA9+2L0L1WPGfxp1/6xrLhYxa70o9YeKhzDO3N7wzLhlg2SrrdOsPMSdlLrfai4uoga4kCDLeNZNeC+wbodDNsWirHh9QMQqn4x0Auzycxi7sbzfFsKAKZ04I2xORZKPfXPf5b/ylGOzMfoSuty/JRQYKlEuy8HUH+LQbReTjRnHdfq3CqDB8zC6Rfp4H66Jo7+CyHKM9YlmeF1X2XFP7BfceUL/5YDQ2EyBqK+pgjj1ZJjqEFVpzVzQRjYwAFNlqNp++WjK1DyQXkF/mK/M1y8NZOW3HNUmQyqY51cK5H4ADWO0ig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8338.eurprd04.prod.outlook.com (2603:10a6:20b:3ec::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32; Mon, 17 Jul 2023 07:02:13 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 07:02:13 +0000 Message-ID: <355e3b07-3111-34dc-7b0f-8be828012ae4@suse.com> Date: Mon, 17 Jul 2023 09:02:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 02/15] RISC-V: Add support for the Zvbc extension Content-Language: en-US To: Christoph Muellner References: <20230701052104.4018352-1-christoph.muellner@vrull.eu> <20230701052104.4018352-3-christoph.muellner@vrull.eu> Cc: binutils@sourceware.org, Nathan Huckleberry , nhuck@pmull.org, Jeff Law , Nelson Chu , Andrew Waterman , Palmer Dabbelt , Jim Wilson , Philipp Tomsich From: Jan Beulich In-Reply-To: <20230701052104.4018352-3-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8338:EE_ X-MS-Office365-Filtering-Correlation-Id: c0cbfada-832c-4554-d879-08db8693bf80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VX5Zs6o52Z7xTJgNLm+oNzLaWY3XdWLnFCYPh1ibSd44nd+Om8WhuhMjGNmHpgsT0jSYt3yYotvDNWZaxqvNkAgvl7koaFTsHGFM+joxR/nC9f4E6opUKGglpHRPWBFmn+JXGxgsOuLWLwubqDeUK8vFnFMLZ5x50et/wFHBE3ggcIXb3wXN6kbe7niJ6RiOScWuA3gR3MzTMXRts1bQ2cXa+SQ514DUJ0P2hLGxsbZ7ID61m2R9cSFkvugQOMtLSry+5l5+9guUEBp6qax7YUWHtoSs7p7EsQZJH2lNQcucZusxrFtWI+KGP8ZhOVqf1FC7JXecePIJmN45jso7VimhHt9fIOnylsRbV+S7AWr7mhp40QtWmdDlB+fevecNHNNFPzLu7qgwEHSGdjpTdDjYKMr5Ux9Zx6brrY+vNv0bTY1k5j+jZWQIqRu6xojsjogJDMJe8QM/9tDz/euizWcd8FlCtEIA9S0xBMgEVzh443/twmyUZy0ZfG+uCmbXI+H4yWWNsXVIt9/DhNtp8o1G0byJSAyIyWXdeZwyImMFO9sREe6Ddedpaz8HMeeupMpN1QRNf1utGWEn0Ilt9Rt6iv8H0JKIhSAxGOgiQLpcH8m0k1XKWOtv/nUtSLRPsg2qXAieZIzm0Wys0ZSqYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199021)(31686004)(86362001)(31696002)(2906002)(36756003)(7416002)(6512007)(186003)(53546011)(6506007)(26005)(38100700002)(6486002)(54906003)(316002)(66946007)(66556008)(66476007)(6916009)(2616005)(4326008)(478600001)(41300700001)(5660300002)(8936002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czVvY3VBMWVkWXZ3ZExvNy9EVlhyUlZvWFd0SDBnM0dSKytBaVdRZ0lnTGx3?= =?utf-8?B?MzhjTjV3YkpseTBiMVBNK2NHS0p1ZEZVc0hFRktQZm9YWnh0UWhyTTFhc0Nh?= =?utf-8?B?QjAwU2dUZ0pYUi84R0FRNnlEbUErUGRtNUpQY29oMCtmVW5TVVEwb3JpQjhu?= =?utf-8?B?dk90SE9sT3JsL2I5bG0rTmkrb1hmQkZkbVJ6bGJjQitzRTJNUjFDMUxUQ1NX?= =?utf-8?B?UU8xS25OTXp2U2xJY09OMEpIS3JLdWtONFl5NVVoNmxFYmlOSUZNZlMrTHVZ?= =?utf-8?B?emJBcWlUUWhxZ2lXVnJIOVg2aXNrWlI3STBIMmM3S2F6akFaY05KNXhKQUdR?= =?utf-8?B?WTF5SHpTUXdyalNIbjRkVk96S2h2Y1ZaSFFFc3BJMlR4R0V2Q2w4dWpVZExk?= =?utf-8?B?Mjc0amZkNHlENWhTL1lTUFNtWEJMK3NRK3FmM3pxQWswTnFqbG5DS3Q5dmFG?= =?utf-8?B?K3QzRHpzM3B4b2Q1ajQ0elV1VlloZml6OWJHNXJWWHpJS2tlMTNYSm5HT3pw?= =?utf-8?B?NnQyejhDR3NVQi8vM2x0VExCUVNZdVZXajZrbmpQUVBOZ0VvVUUvN0YyVDF2?= =?utf-8?B?UHZLOFdzOFJXMEhzOTAybHA4b3dSOFFsTmhoSURtTE4zQTMrOHVsNk5WZGdt?= =?utf-8?B?OXgxcVlDeDRubnVOOWNxOU1BOHl5Tmx2TUFRZWhGVVJKb2pScmVqZHhSdUdl?= =?utf-8?B?SjNMRXA3Ly94S0w1SWRpU2pMS3IwWjNFYi9vOEpnZ2VBdkJ1d2x0NkNHZmdj?= =?utf-8?B?RDhFU1dORXNNM3k3S053TTV1bWNheFlGQ1pxVEhtUW4vY01QcGdqbEMxU2VD?= =?utf-8?B?WXl6ZkxrVUNCUlNNc1dMV29hRzhCSXozV3hiS3E1RkhrekhYRkdpWTlMN3pL?= =?utf-8?B?MjREck9OdmcrcTM1czgyM1JYRStkdHRGMlBVNFZDRmRhMjJLL0RUM3E3VGEy?= =?utf-8?B?VmRDbWh2bkxhZk9JMkFINGN3M1FFd1ZLY1FOUFdXVDRoMzUyZ1hkVGdoQUVq?= =?utf-8?B?dktsM0s5SnpaNHdoOXIxY2dqdzdteHMwTjV0d0svSnN3ZVdKVnRXVllzRjY0?= =?utf-8?B?SXdEM2xETHgya2pWOXU4V3ZXZTlpUnIvUFBEekVFRU9mR01CU1ZLZHh4SEVj?= =?utf-8?B?dktqc05Kc0pkekxuRis1MUJLY21la0VqUVB4OTlXVXB1MFh0am5mV1ZvN3NG?= =?utf-8?B?OUN5K0UzMUdtN1FndXM3aWFJelRZdXUyVzAvSmpCRnNiQm9IQlplU0RZZW5z?= =?utf-8?B?ODF6SzgyNmx0N2hPM2tGK3hzVXh6RHpiTm1oNXoxNldDUVQrZUpobTd4SXhn?= =?utf-8?B?Z21kVi9MOWp3Z2FHbzZoSm8rSmxpY2labll4OTc5OXprdUdmOEd3MGNmd2Vj?= =?utf-8?B?aVdTajZGSjN0ZlpoNTladUdVeDFOb28ybUJYK252VE5teE9Cb2ltUDY4Mjln?= =?utf-8?B?aDdrTkhGMWhEb0F4QjJEaFhWN0p3Z21pZHc1Zzh3U0JzaXhoMytGd3M1ODJR?= =?utf-8?B?eUFFNjB5UEVMS0MxeHVzT284SHBINUR0TUxwcVBPeXY2S2NLVTdFUnc0TkRO?= =?utf-8?B?cERhZjBFSkQrSzkzUm0zcEdtd01pODE3YldNb3BUYis1TDkweTRxUVh1WXZ1?= =?utf-8?B?YXBTdTZkaDQrR3AvRnh0L1lKUEdKRkN1ei9QZ1N1NUcrUTRYVDRBajdwMkdE?= =?utf-8?B?d2RlVUNFNzRUYVkyV212RDdMeUlSL1Ara3c2SUNLMUJuUlN4bGpMd3FWTk1M?= =?utf-8?B?citxTWd2VklqRXpFNnF0ZzhrYWthcWEvczRRMTdqRFJVSTAzVHF0ZUlHeGNl?= =?utf-8?B?by90VTAya0phMGNncXQ2UVlhc0Fic2ZTaFM3d3hBZU1LSXR3VXZuUlpBVzRa?= =?utf-8?B?Z3pJbHNqV3VzM0UxSjU5eTZ4N010ZWkwM3FtdFpzM0gxbis1UXNSYVYyMElT?= =?utf-8?B?ZDluYVFrK0lYdmdyRnlkYTg5b056TGRRdHJUL1ZIUHZUU1dqT3M4aTdWYVVj?= =?utf-8?B?LzRyK1BjUU85M3MydDZsZmRFaDBoT1htc3lBQjBVUDJNQjZDQ0UyWEVWd0FV?= =?utf-8?B?d0Y3UWxORHdKdyt5d2lEUXBlbVZ1b0lHYmVPVVBoVmw2RktLZklTN3RyUmVO?= =?utf-8?Q?uS0j8MCTzHks6nrMzfeCF24Jq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0cbfada-832c-4554-d879-08db8693bf80 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 07:02:13.5334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tJ+Yr5qP7kZ50d/e/CVTGXzoGirtXZGtwMEK49zfoZVyQFI6jds1U2H0Ga/xpVfXNhrk+XwznfRjO2BmTvritQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8338 X-Spam-Status: No, score=-3027.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01.07.2023 07:20, Christoph Muellner wrote: > --- a/opcodes/riscv-opc.c > +++ b/opcodes/riscv-opc.c > @@ -1902,6 +1902,12 @@ const struct riscv_opcode riscv_opcodes[] = > {"vwsll.vx", 0, INSN_CLASS_ZVBB, "Vd,Vt,sVm", MATCH_VWSLL_VX, MASK_VWSLL_VX, match_opcode, 0}, > {"vwsll.vi", 0, INSN_CLASS_ZVBB, "Vd,Vt,VjVm", MATCH_VWSLL_VI, MASK_VWSLL_VI, match_opcode, 0}, > > +/* Zvbc instructions. */ > +{"vclmul.vv", 0, INSN_CLASS_ZVBC, "Vd,Vt,VsVm", MATCH_VCLMUL_VV, MASK_VCLMUL_VV, match_opcode, 0}, > +{"vclmul.vx", 0, INSN_CLASS_ZVBC, "Vd,Vt,sVm", MATCH_VCLMUL_VX, MASK_VCLMUL_VX, match_opcode, 0}, I realize this is more a spec question than an implementation one, but implementation might be affected by the answer to the question: What exactly are this and ... > +{"vclmulh.vv", 0, INSN_CLASS_ZVBC, "Vd,Vt,VsVm", MATCH_VCLMULH_VV, MASK_VCLMULH_VV, match_opcode, 0}, > +{"vclmulh.vx", 0, INSN_CLASS_ZVBC, "Vd,Vt,sVm", MATCH_VCLMULH_VX, MASK_VCLMULH_VX, match_opcode, 0}, ... this insn doing in RV32 mode? There are no 64 bits to take from the GPR, yet that's what the doc presently says. Is the value coming from a pair of GPRs, or is it sign- or zero-extended? Or is this an RV64-only insn? (Note how the doc explicitly describes the behavior for vandn's scalar-source form; the only thing left to be implied there is that truncation / sign-extension are to - I assume - element size, but maybe that's said somewhere in more general terms.) As a nit: The two vclmulh lines have one too many blanks, resulting in columns to not be aligned. Jan