From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id A379B3858C35 for ; Thu, 8 Feb 2024 08:23:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A379B3858C35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A379B3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707380594; cv=none; b=fdKjv8FovRoIxw/R0DSK2wuThtjcn/RWivlLSDRkAydlMyKGIrweQXDBZoeo9rXWuaOYIOtIGuU1+cJcVvMaK/FPiw+BGS+g68ycw5JYODZRQ8yv8RVc/rkb216bxgL3R1THYd4r0FXrpHMLIM2kyeCYUFFxQNKq366JJX5qUoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707380594; c=relaxed/simple; bh=PV2KXylNk7m9jbOigKXvwLRBytY8pBRRmpF7JZQBiKk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YYNiOzMBxb+YAONzwzTzPVot/9sjp6hGhVUSQCcS5/yAHgZBfzg9ZlDbCT82qnGMKVUTet2iI7R2atNE4/98UFvVx6GwqCgjBmmIO3+ddyj+Iss2ZZrKzhXVQBq4Ih4Yy7MCVCNMbttM6M+F8//uM5Udy6r415XM8nbljuCnqEU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5116b017503so1307724e87.1 for ; Thu, 08 Feb 2024 00:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1707380587; x=1707985387; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dNnxHogKWUtnpa6AiZadMuWcGAbOlGDs44m7pXRUNrE=; b=F9v07ta7IA0GQRDfAzEzXxfb1FJAlnSccCXDBZ1cL/2rqMrXGXM0areNZArg+9BGpc GD6wFDnl2vmw6y3qpQCIm3IiDbwXHL8i4BvgPviCnTkfBt4UL6McPgCSIlzmXfhN1D8r Fey8hDdVSUAC+uYwoHUKG/IjT8ZmZEDU8uBlSai02oEBg3Jsxg6omDeVAOrgAijajWYC 66ZCg3R9JeiqXwcZFDKMjzdO3IwzFkG+Dj5Ojc86II9YeGvRUd+TPCPTIln/7NAOWPeL SGji+Dve9br5juSMatSYOTBPuQN3SMRaI3NZwaJuZq5SXfMNDDAuV14cWwLr1LIE89cu R05Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707380587; x=1707985387; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dNnxHogKWUtnpa6AiZadMuWcGAbOlGDs44m7pXRUNrE=; b=UUDqf1HXSyTch3H4LUjTV4ICaEU7m8TucT6/OwXmfrea8YjLf2YSSeNc3JW4F5s8lJ lnH0aB6LXDoBNYrV+JEucmPBEy5kegkyFTZwPYLXhiGP2Msho/Y+IB0DaJRHkcQXWiEF l6sRXkbT/75+Ot3g9UVZLrMx/KfPeJnHy7SFaGjY3kc6ojwLbT3ftZz/2HE5ZaHVVOxu QOk0hByecx1Xym3OnyienQCgsVCA6MvLglJh+d5IzQre5jJZOPJmp0G+rnYIFsT73dC8 AQeefus08TqSWhWRn8krXD04PzvHGErTRG0uqfp/hctzvFbtD1wo7TrE4ScZ9XTvnl8B SyVw== X-Gm-Message-State: AOJu0Yw2p0WwuUqi//xa4MoLhyp3T6JeDhl+QUGdVm1oz7I8Xgn/bf+e yqPZiExSR0INT7s66+bpCjrEwBHcocg6x925x+T+tZF6YoEhgNJF4A4Q/Z9RQw== X-Google-Smtp-Source: AGHT+IGRB7MmaKHhS9PThgRV9SWtH5YB92E43BZUJRtKwT4OmHmiumYOv/TG7aJZW5Akg0J/wxBTaA== X-Received: by 2002:ac2:482d:0:b0:511:6a0b:cd3 with SMTP id 13-20020ac2482d000000b005116a0b0cd3mr1760446lft.57.1707380587116; Thu, 08 Feb 2024 00:23:07 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVIthEAmSKFuGPD0tPMoXY5H1adNFA0VZuFS7tASzGA2o4mL6og8yenpknwdtn+s8gNFVHL/XIEN+yLuKs= Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id i16-20020a05600c355000b004103ffb8cfdsm579513wmq.10.2024.02.08.00.23.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Feb 2024 00:23:06 -0800 (PST) Message-ID: <35dbe455-4917-4a97-bae5-619b96be2f30@suse.com> Date: Thu, 8 Feb 2024 09:23:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: Warn .insn instruction with length > 15 bytes Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org, Michael Matz References: <20240205200028.219844-1-hjl.tools@gmail.com> <533a896f-8eec-b73b-cb18-26240ad822fc@suse.de> <8059bdee-392a-b9cd-41d5-8dea538c957c@suse.de> <2721d4bc-e29f-4ed1-8fac-064fe0711029@suse.com> <93ef6fde-42aa-485a-8b22-f2c1f1d52efa@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3025.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07.02.2024 18:03, H.J. Lu wrote: > On Wed, Feb 7, 2024 at 8:59 AM Jan Beulich wrote: >> >> On 07.02.2024 17:53, H.J. Lu wrote: >>> On Wed, Feb 7, 2024 at 7:32 AM Jan Beulich wrote: >>>> >>>> On 07.02.2024 16:24, H.J. Lu wrote: >>>>> On Tue, Feb 6, 2024 at 11:51 PM Jan Beulich wrote: >>>>>> >>>>>> On 06.02.2024 19:06, H.J. Lu wrote: >>>>>>> On Tue, Feb 6, 2024 at 9:05 AM Jan Beulich wrote: >>>>>>>> >>>>>>>> On 06.02.2024 17:28, H.J. Lu wrote: >>>>>>>>> With as_bad, assembler will continue to assemble, just not generate >>>>>>>>> an object file. We ran into this with APX. Not everyone checks >>>>>>>>> assembler warnings closely. It led to mysterious crashes. I am >>>>>>>>> not against it if someone else implements an assembler option to >>>>>>>>> turn this error into a warning. >>>>>>>> >>>>>>>> But it should be the other way around: The compiler could pass an >>>>>>>> option to promote the (default) warning to an error. And if you >>>>>>>> don#t pay attention to warning for assembly files, you could pass >>>>>>>> the same option as well. Without harming anyone else with anything >>>>>>> >>>>>>> People who use/need instructions > 15 bytes belong to a very small >>>>>>> minority. If they want to do it, they can use .insn or use binutlls 2.41 >>>>>>> or older. The default assembler isn't for them. >>>>>> >>>>>> No, staying on an old assembler isn't viable. And minority or not, you >>>>>> have to face it: In the present discussion it is you who represents a >>>>>> minority. As such I'm even inclined to suggest that your earlier patch >>>>>> wants reverting, on the basis that it was put in despite there being >>>>>> disagreement. Unless you soon come forward with an incremental change >>>>>> undoing at least the worst of its effects ... >>>>> >>>>> Please tell me exactly which projects are negatively impacted by >>>>> disallowing > 15 byte instructions. >>>> >>>> I already told you: I'm using such in testing of my personal disassembler >>>> library. >>> >>> So, it is only you. You can either use .insn or add a switch to turn >>> this error to warning. >> >> I has been a warning until 2.42, which you've regressed for my use case. >> This is why I expect you to at least soften the regression, in allowing >> people like me to simply add a command line option to the gas invocations. > > So this is for your personal use case. If you asked nicely, I might have > considered spending my time on this. Well, to be blunt: I would have asked more nicely if you hadn't overridden my concern. The more that this isn't the first time that you went ahead with changes without having reached consensus. >> Plus, as you have learnt from Michael's responses, I'm not the only one >> to think that this diagnostic ought to continue to be a warning by >> default. > > I can also tell you that there are other binutils developers who want to > treat this as an error. Should I ask them for their opinions? >From further reactions I can see that I suddenly moved to the minority. So be it then, so long as a future patch to allow this diagnostic to be converted to a warning won't be blocked. Jan