From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id B724F3834F1E for ; Sat, 27 Aug 2022 00:12:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B724F3834F1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id F2FC130008A; Sat, 27 Aug 2022 00:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1661559144; bh=bZu0kxoCJ2ZvpaXLMh5kzbHZ9T2YcAnxh9430KYH2Do=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Mime-Version:Content-Transfer-Encoding; b=axUp/sPZARN/qBe4osvoDaqUWM2IY1tdgDsxLRpOwwG3Ipp1dAejyq1QP/J4ca27s a09OsyAkDaMj1u2L7jCfTEzBHQ9GlIaeCG4kalgqLQhXNIByBHIEhR1m4YeLh2ItIn 9YktM6zbgrP1Ym6Fny8KPZgRdq32tNp+KevAc9kQ= From: Tsukasa OI To: Tsukasa OI , "H . Peter Anvin" , Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu Cc: binutils@sourceware.org Subject: [PATCH v8 7/7] RISC-V: Make `is_addiw' parameter bool Date: Sat, 27 Aug 2022 00:11:04 +0000 Message-Id: <361a8dd8cc5396b708b5cbfae842881bb4bf2224.1661559056.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,KAM_MANYTO,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Because we widely use `bool' type, this commit makes this parameter `bool' in the process of tidying. opcodes/ChangeLog: * riscv-dis.c (maybe_print_address): Change `is_addiw' type from `int' to `bool'. (print_insn_args): Use boolean values. --- opcodes/riscv-dis.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 7322db10d24..d4c1a5505b1 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -172,7 +172,7 @@ arg_print (struct disassemble_info *info, unsigned long val, static void maybe_print_address (struct riscv_private_data *pd, int base_reg, int offset, - int is_addiw) + bool is_addiw) { if (pd->hi_addr[base_reg] != (bfd_vma)-1) { @@ -243,10 +243,10 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info case 'o': case 'j': if (((l & MASK_C_ADDI) == MATCH_C_ADDI) && rd != 0) - maybe_print_address (pd, rd, EXTRACT_CITYPE_IMM (l), 0); + maybe_print_address (pd, rd, EXTRACT_CITYPE_IMM (l), false); if (info->mach == bfd_mach_riscv64 && ((l & MASK_C_ADDIW) == MATCH_C_ADDIW) && rd != 0) - maybe_print_address (pd, rd, EXTRACT_CITYPE_IMM (l), 1); + maybe_print_address (pd, rd, EXTRACT_CITYPE_IMM (l), true); print (info->stream, dis_style_immediate, "%d", (int)EXTRACT_CITYPE_IMM (l)); break; @@ -406,7 +406,7 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info case 'b': case 's': if ((l & MASK_JALR) == MATCH_JALR) - maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), 0); + maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), false); print (info->stream, dis_style_register, "%s", riscv_gpr_names[rs1]); break; @@ -436,21 +436,21 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info break; case 'o': - maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), 0); + maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), false); /* Fall through. */ case 'j': if (((l & MASK_ADDI) == MATCH_ADDI && rs1 != 0) || (l & MASK_JALR) == MATCH_JALR) - maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), 0); + maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), false); if (info->mach == bfd_mach_riscv64 && ((l & MASK_ADDIW) == MATCH_ADDIW) && rs1 != 0) - maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), 1); + maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), true); print (info->stream, dis_style_immediate, "%d", (int)EXTRACT_ITYPE_IMM (l)); break; case 'q': - maybe_print_address (pd, rs1, EXTRACT_STYPE_IMM (l), 0); + maybe_print_address (pd, rs1, EXTRACT_STYPE_IMM (l), false); print (info->stream, dis_style_address_offset, "%d", (int)EXTRACT_STYPE_IMM (l)); break; -- 2.34.1