From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2041.outbound.protection.outlook.com [40.107.103.41]) by sourceware.org (Postfix) with ESMTPS id C97B83858C55 for ; Wed, 2 Nov 2022 10:52:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C97B83858C55 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhtiCiWAq/eEgq6PPuP5XLrMnbi3b+mXepcalTIeSzHCY0hKr6yrMzMb+n2OBXUw+iEW0XVq/KBJJuW3/yTI0qQzNq1W/wzlsZqaPCZTFKJIOtDdAGn6KF0PmaaPRKSjTqNJwkkgRzYE2ohPtepSqiKOcDxyYdgFMmxGxZmI/D1tqKRgljcWvwbpEPG7EjT1v1Kxnan/lVACN+CbQMXzsUnBYZUmi4W9VFfmhu85ZZ5M6j2WzAUdepPWn6w0o/gGQHkbxPRXEaprPDsJ5MMkwPvHUTyDNCzMVOGYo0z5lZIFmlnVjw+G17V9zMndzmRF2JrcCp3iJzsy8DlMXBSQLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VOk+qex1gI4Jb/pzqurvKh7ornkdaFpnlYlXXY3ZbtE=; b=hc4IzvhYj4WmUJaTnP5qL3jiTiefa/z3T3UujAbR/VrSsHXHImrCORvtq53jhaWgJWIUXeQZrD50b7BeOMW0ZRYO8C/IOqHcJ5vr/B/S4cqxF3N6GUj8xqvE96D2VxavZUhtMZgIUO9MBz9I8iAl+ysh10ds/D82qaCpyyveaZeRRVjaZOu/9bdKBLBiUxfibcJcW26iwXmlzvU/+Zs2Msj+BTsa+KmiJJJu+C4viVWny5yxrVClSFZ7x9qEo/j0w677WAtMhTOWjvVF9QiPOWKApCM8iUWWjU05F0kClOZKL0Cx5Ia4UOa1e9qMQQ7HV0eIBmok32YyCk/Hi0u5kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VOk+qex1gI4Jb/pzqurvKh7ornkdaFpnlYlXXY3ZbtE=; b=YV72WWiSlCS0Jd6E3ZT9pg3D6LDIIZMjQzgzLzqbgPLiQ6+YYiHJ2NBIAisELrY6wtnzjWKiff3MGyDB+0aqSnU3A7PJeakYwD3BclO30U0ZF1pLNeUvQdrOdNXgt3U8Q+pSua+M98zx9PWnBCc7w2K+KJ1hy08Kwnl1WQZuEaH9ZBUxC4G/Zw8d1KFKR90kRaTzsGncwunhJMsrXtYdz0Z61W4C3sUYN8M5KZIqbstTDftTcI75NkGrvc/PT4vilH8uBPMr5qogeMYG1CRmTXOKmUzegqw9tqx8UbfvSSEhXR2ZOQ+2k8c0UcvctpabY4FwQ/45vqzjBqVxBEgCRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6776.eurprd04.prod.outlook.com (2603:10a6:20b:103::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 10:52:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 10:52:32 +0000 Message-ID: <3666195d-32ac-62b8-a03d-41a3bb0bc32b@suse.com> Date: Wed, 2 Nov 2022 11:52:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 3/6] Support Intel CMPccXADD Content-Language: en-US To: Haochen Jiang Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20221031030507.35588-1-haochen.jiang@intel.com> <20221031030507.35588-4-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: <20221031030507.35588-4-haochen.jiang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0176.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6776:EE_ X-MS-Office365-Filtering-Correlation-Id: d4f1afa4-eb87-4b45-f568-08dabcc05843 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ukEyciWucwSI5SoYFKls5g0HJlM5h1jhqimacOP/IrKJT0A3NjlO58WGY9Mmc2Fs9+8DNTEapLYztO/egvHz6C0m5uukWbdG67dxIo3x0bRBQz385sDjxkgplO3P2NiM69D9Dw0RRGVoqyEjfIYKXBerCLumgu+b/25Xl8HCPxaPcqcl7+GNqOv27aBq7LAMc6iVQmIcjaJ029qxdLEUmi0Gkc6HXUyk6V76dCOQxvSpf0i7gkPaY1bO9d+Y+nzVaSVDm378R1fllSkW5p77uePHNdxrCoxrlk18JDXI00H7qwko5cD31ilNwTp1p5desclYKi95E2oqO31yhOHPyhG9rysKXTtDTkChtEIzmXfjoHsq2SxcvFLNdLVYzh6TO35ehIdqn4BCn4r2mkFZUAMiQAlgXANCfR2YcAwunt1rtJ2Q9h5bGG9dmzrr798z5r6DgvkXeLcnIK0eU20gXaTK1PXIhYh1pf4lBVsXrJiBPZJ4Hkm7kQ2QZT0zMhw4T5bTDuMh8p04NuWGSnZ0IPoly1e4+UOB0YCxnilL+gxBBIz9xRDdbfPtKkt1VB/lTndfcLxnW69vqdAbuTjOn19mal5JQpM4BOEdg2zICw6dY/HKVNCtwtrTDCiIPR0TRFqRchhe0DjFvgs4B98IIEl8NIs9e/qV+H0zfVV/SQrxMfIW3OtRuGFtUug24ruy5XWT4wBhaXLNJh5cDJgp6iHpwjF/XbXeZL7hIntmuQ6R91K/uBw0H89OkF+BYq52A4Og6rMFQZIJqDeadtoz1tzkDstEp/fBBluj6SlFfnk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39850400004)(346002)(396003)(136003)(376002)(451199015)(186003)(2906002)(2616005)(6486002)(31686004)(478600001)(41300700001)(53546011)(316002)(66556008)(66476007)(8676002)(38100700002)(4326008)(66946007)(36756003)(26005)(6506007)(6916009)(31696002)(8936002)(6512007)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjVkdnE1a3FVNDhyQ0NvYkU3NWJrelM5ZDhnMDFrLzQycCsvYmRKRHN3dUR6?= =?utf-8?B?WmNFcTIwbVhBYmpFejV0OUphc3BjNURpVnVPbXR4N2ZtSXpONXpGOXYvckQ1?= =?utf-8?B?OUtyTkhSZGd0bC8wV3ZseFY2cmIyaXQyU3JSaDk1VUZBdklGM3luclBMOWRk?= =?utf-8?B?T0ZZL2N3UzFkMVJ5WHY4UXptTlV5VTZQR3RpVTgyZVl2QnpqVC9hSXV3blEw?= =?utf-8?B?bFFmaTI0ZDc4WU9od3dod1hXaEpic3B4ekJVOSs1WkRpQTZiUitKSU94UktY?= =?utf-8?B?a1JJUGFFdEwvWjBnbTlxNS9ZQmdWcVY0WVl6MUNYZnhidm1LR0pTUmJrbVh2?= =?utf-8?B?SG9PbDJNYjJ5Ym9ibXlxSjMxL1pVaE5oUXVRaGg0VG9Wb00vRCtpZkNpajFQ?= =?utf-8?B?cVlQNXFXWU4rWHVEdTJiaDVSOS90aW40bVcvbWI3bjZuSE82TGZhakc5eHRS?= =?utf-8?B?OWdmelQ0V0VCL2huSnRJVkJhakFIT3ROVWNvQlowRGpkRU5CdGc4MzRJQmhj?= =?utf-8?B?MzlZbllXM0tlRkxUYU1kUFRSQW04VjZaTVBlUGhyeDJ1a2laamQ1SW5wSEZa?= =?utf-8?B?a0dNWmxzRWVYUGs2VmkybWYzcFZkRXQya2pUSzBPeXBPMGQ2MEFzTjhncGNO?= =?utf-8?B?dGpXWjNPaXpMaEovRTNJcnBQKzcxazErNG1BaG1GUXE1TFRsajdGK1ZCZElU?= =?utf-8?B?TWZLYmcwQnpZSUVYRHdPRm5HS21md3hTMVRKM1lSKzV2dzEvUGVnbldKMlZM?= =?utf-8?B?b1BSWGhpVnJvSDkwZWl2M3N1RFJxNS9TZm1EdldEV3dwMEdsakRtSmFsV1Ez?= =?utf-8?B?ZVdEdnRZMWFDbHh5VFNNbnZvSzdVSVJsWTROUVhEa1FOc0M5Wjh5K2xEckk0?= =?utf-8?B?N2U2OTJENjBacmVpV3RnRWc4cWkwbHJhZUJuby9ZbzE4dzlnUTZTWk5FV1NB?= =?utf-8?B?SVBnMjZPaC9RMXhaTHYwWHF3NE5zOFRyWWRTR3pOV0pTYWxHOEhVaXFXWE1P?= =?utf-8?B?RUtyS2pRZzdvVFlQSUswVFYyamVKdjhLMHh4cXZxY0xwOEpvb1lGYWdsZW0v?= =?utf-8?B?NTcvTXlOVjRBZElQZmR6cm5PaGhhR3ZCOFNJN1h1Q1M5djVLRHJWTzN4cnZ0?= =?utf-8?B?YVU5NDFveWNIUEZEbXEzRkxXVjhpYkNuZjdJZE9wOGEwUnBxRGZITWcyNU5N?= =?utf-8?B?NjE2UUdNQjVFV2c4dHZnelNWSUJrKytCbnFBbWE4STFQaVdId2E4M0JTMHhH?= =?utf-8?B?enphNkp5T2M3bDFKcUhvSkR3OW5LbitUL1YxdXp5dkQ4TzhjQnVCVm1tOWc2?= =?utf-8?B?cHFYdHBhY0NFOGJxTnNEWTZMU1Bjc3JUQUxDcDZKVEtmY2crSmJaM0RtcSs5?= =?utf-8?B?OWJZSWVyOEVjM0ZTSlEzNWhHV1JGYnE4TUhIcGk4ODg0d0w3Qk42MGxEK3pG?= =?utf-8?B?U2xGUXdqajc5c0JBbktWSk9BTjJxQ3VGanY4UFlFTURkZFFwNm1GMUgzMlJa?= =?utf-8?B?VExVOXYyOW1vSWp2RjZ6N29XZThnNi83UDdFWGx3WERlV2g2dDVFcm9pNVlO?= =?utf-8?B?Yi9ueFlTUXFjQkxxUzB0S0FHYS9uUGE0L1F6ak80V09Od2MyT2EzekpyUkJJ?= =?utf-8?B?VjYwb1NWYk5DdWZhUW5TU1g5cUJzdU1sUkE2c0hTYTNQNERlMmthVzN3aWtv?= =?utf-8?B?NDFvVU16Q2RoaURGM3pEVTBZcmMwSlZ2bVZ4Z1FpUTM5aHFwVWszNENjSDV3?= =?utf-8?B?bUE4d1RyMFQ1cUszSFlZc0VqdHp1T25mTzc2djhJYlNqL0tLOUZUWExhdVZw?= =?utf-8?B?c1VkcDNucWpYOFFHUmJOVEc2Q04vMVp4TUQ2T0xVV0FlZmY4NHh6WTlxdkcw?= =?utf-8?B?K2kwUzV0OEJHeUI2Um85d0l0eXVLZXJXemtpTGNKY21rbHVPd3lMTG9XZ3dM?= =?utf-8?B?SkVRM24vZ0t5UWJLRkhFK2xIWCsyZG9WL1UrUGQ3TE5yeXVac1A3SC80Nmd6?= =?utf-8?B?TGs3OXhRc20wbkJsejBEbU5wUHc1Z3dBUnE3dFlpa0tMY3BlL1ZrOERRTllv?= =?utf-8?B?L2NTMGd1TTJHaURQaS9adTgxRjlxaXI3azR3RUprYmZTTnJvY3Z2dkJDRDJI?= =?utf-8?Q?OzkR88o652HAksMtuE3Ker9n2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4f1afa4-eb87-4b45-f568-08dabcc05843 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 10:52:32.8344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4WamFJu1wlL3MmLt/g7y1FhramEdfnVDWBLsFRIXwIqQTa0okUhU9cooT8HW/nTC2jP8PEI1quH0a6Z6frRYhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6776 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31.10.2022 04:05, Haochen Jiang wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -1098,6 +1098,7 @@ static const arch_entry cpu_arch[] = > SUBARCH (prefetchi, PREFETCHI, ANY_PREFETCHI, false), > SUBARCH (avx_ifma, AVX_IFMA, ANY_AVX_IFMA, false), > SUBARCH (avx_vnni_int8, AVX_VNNI_INT8, ANY_AVX_VNNI_INT8, false), > + SUBARCH (cmpccxadd, CMPCCXADD, ANY_CMPCCXADD, false), ANY_CMPCCXADD shouldn't have been re-introduced here. It now being there only means more code churn in my patch to sanitize all of this dependencies handling. (Unless, as I'll mention there as an option, we want to uniformly use ANY_... in [almost] all table entries). > --- a/opcodes/i386-opc.h > +++ b/opcodes/i386-opc.h > @@ -215,6 +215,8 @@ enum > CpuAVX_IFMA, > /* Intel AVX VNNI-INT8 Instructions support required. */ > CpuAVX_VNNI_INT8, > + /* Intel CMPccXADD instructions support required. */ > + CpuCMPCCXADD, Just as a remark: Personally I would have considered it more readable overall if this had the "CC" infix in lower case (like in the comment). Jan