From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70050.outbound.protection.outlook.com [40.107.7.50]) by sourceware.org (Postfix) with ESMTPS id 0BB023858403 for ; Mon, 25 Jul 2022 09:51:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0BB023858403 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cxXRoU2A8yciI9/giMdh85NVyu29jtr5KNtFH4RubTPrC10t7dilxP/g/B4LRxSCGWs1f04nLUDhBy+WXqOO0WGtu5UXkust5xsnUF1qlN+va/DRelmNwIW+vVOpgPZVaJp4HrtuIUQ1objnALHJpoHVuKFrsX8QutCDgzvqCFUXBRt2o7Yv2wDXpBq4dSmiXO40mU+GQYExjJErhHK0VCFYuHUnq6mgu9qo5adUqbAFr7l9/Fd5J/6D80CZ7uAHV9dQVzTNUocnhKEYaajnGHSUnUBGENSUprCVYWsHWV1Ptu7/W54pafzjfhuc75I5u3+9lamlnBchCP3DsK4riQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PP+S2KarZ/Beu1UfLKFbpDw10rBL1kqPUwVoOxfRFlg=; b=izOwwKMi/8QDLt90r8KNquXakyBB51DD2zx3V82CLdiwyrBbCwm+IUTkm9MfWQBIYT1+EfTkxzFurfpHffUJ/rQ8jkUTnkyrupPseaRj5eYvtR0SprAaElhGYGr9n2PwVjDbfVCTemmvd8S5OYT5EcZ0ql5StwtsQU0KDzrailt1c6XgyQVuFLOIVm+1JleFvBKy75rM07XybbWAuuqxRXAmKMYKcyaarYUlRQIdiQLCwF0w62tj+YQDnirZ5qOVNA/vvMMhZ7jCOR71PBwuOpMVMmkq2Xw5vL7zQCGByjaBCMHaZihgB2O6QiHF9nciYYP9umk4tgHuQxN3nkf67g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8284.eurprd04.prod.outlook.com (2603:10a6:10:25e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 09:51:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 09:51:21 +0000 Message-ID: <36a3fb2e-c06d-ef6c-93f7-18c5a88d71d1@suse.com> Date: Mon, 25 Jul 2022 11:51:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/2] ld: Add support for a new option, -exclude-symbols, in COFF object file directives Content-Language: en-US To: Martin Storsjo References: <20220722220203.1712670-1-martin@martin.st> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20220722220203.1712670-1-martin@martin.st> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0770.eurprd06.prod.outlook.com (2603:10a6:20b:484::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 11eef064-734c-49ba-8d59-08da6e233a93 X-MS-TrafficTypeDiagnostic: DB9PR04MB8284:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sXzXykIrWRpAh9ahj3wpZq0eSIfdLJy5lEguXsD1eqLzUKjz0F0imfaaFym0O93vXPfY3D+uPPEVyJogLH24ilR9c3JebnE42miSdxmWYuucBMBbCc4VaR2BSqFk0/9kYm8zdUODxp0aYNkuw0gciru+kmApTeyCeUH0OXtclO2ILLIXi2U5+5CBpDTXFoGr7Qk44dYIv9PZDtr6gf215dKuFTSM7cT9Ut2Q/s/jJED1YvLpe5FAT2sWZi1r5kSbXSkt3sFEXXxBprKkrT2s7CjzJobyfKi7iBy1hTQdYHg/cZx93iPTnVYCpFSJLcZ6qg4pcPuDqLYN5fEdiM4h4fHId20rTXcfrBoCMaz6ZeI7GhQaISnTeZV7Ke5BqlqiatuLuZu0jH5p8rFWEbVnwanXwtDjlQUvzDNhqPmwKzYfXFaTbvFo7AsO5oVb0HmO2WzzSEQm4knKtlBPlDxbsC+Qlm2oxC+FHoi0bTRyeKr8tkv6p4N9yK0s9R2l1QUaLOynsqQDDr3AEOv30b31Ms+B3uHEOiRRaZTS1/NQ6GEN1Z9KhaoZNQ7SZCTs0umN7QhOFInfgw4DhP6X3FebcRRwNTXj+oQaYLm07VCk7sR3I1V/IxkYnFZiH/CpNdVm7Rl64tWrPE6wS4o0OEsnNMu0G0m1vwQiVnZAhpGkljIFox+W4IzzyT+K/rM5O83sVKejLBpmYF64R1sR4HmaJr4rZ0EyFe//emeN7WAPt7miVFss5b18Zdd1da/zsh6suS2cZNaCqstUDNFI89tgnRcg02H4ZffH0pNzrUBjez8q52xXhc938r/s692M+6D2KN5jjNOK/OjlT3GxVmFd1A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(366004)(376002)(346002)(39860400002)(186003)(2616005)(31686004)(83380400001)(66946007)(6916009)(66476007)(6512007)(53546011)(6506007)(8676002)(4326008)(36756003)(66556008)(41300700001)(26005)(2906002)(86362001)(31696002)(5660300002)(8936002)(38100700002)(316002)(478600001)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nm5tdDBNWExTREE1OU82bTJhRm11TlNrVmxFSFRvYllsY3Yyc25STlQ2andX?= =?utf-8?B?R3VoZXNnL2xicFFGcXErWTVCWXFVY2xHOU1BaTU5eGkxcFNub1R4dTBJZGE4?= =?utf-8?B?ZTMxUXd1TXJ1RWZCaUhidzQ2UlcvRDFmcUEzT3BkRmU0eEhOODNaUDFZVStv?= =?utf-8?B?VDdOdUd5TWdNdm9lRkFuMUN2YmU1WXg2WEZSUzRsTTBvTFNidWVwMDd2ZGV0?= =?utf-8?B?RXVLUXo5M1k2ZnlVYjVuSFkzTmlXSmc5NnZNRzkxLzJiQURFRFMza0JvSTU1?= =?utf-8?B?WGU4a1FVMVl5UmdpemRFMkgyZWZuelhoNEM0dXl3NFlyd3dKSEpiQzA3NmxG?= =?utf-8?B?aWMyeENXNDI5RVh1L0poVnpTSHhoUHZMcjNVMVR3bGhZaDZBS3o3NERWdEZB?= =?utf-8?B?U1JTTzkvWjloM3diYVVvd1lmck9vU0VxenJ3dVREV1RiNUJPb2Q1eTI4cWFL?= =?utf-8?B?RC9ZbmF1VjgxM28wZjU0U3VManF5emFLVGJtMlBkMTFRNmJacHpIU21PSUlW?= =?utf-8?B?R3Q1UUNFVVRVUnRKM1ZPV2x3S1g2M1lhcmZVVEpsYTRjbG9yNGo0NkNtM3JM?= =?utf-8?B?Mm9sYjgvZDJOYTE2dGV0MXZkZjhEbFYyb2JEd1R1QXkyT2NMTzMyTEo0WXI4?= =?utf-8?B?alJzdm13Z1ppMGRJRHZnbTFKMjVob2laUmpBNlhLM3I3OERnMkcxV1ZML1p5?= =?utf-8?B?alRXVS9LVS9XZ21qaDdYcGxDalpuT1VQOXhhdVFGQVVKVkMyUUtLeGI3QmRD?= =?utf-8?B?VmZZUXBNS2FMOTR4ckszY3J4QzBPaWJ3eWdrdkloeVlUUkgwcVZlRGEzZXBr?= =?utf-8?B?K0REZHc1WmxQRnpLbklrNHFDZjFrM2Iwdjc5bzB4Y3hwcCtUTzlTMWNDSmVN?= =?utf-8?B?VHVkYkh4Q2dwbWpOMndFK1UrcTV6ZlhlcDdkZTA5d2E1Q0dDZTBIa2g1dTM1?= =?utf-8?B?VzhyeW8rWUptSDkrQnZrWHdNdEpHbVFEdlZNd0JHNFY4S1VpelcrTGRNR215?= =?utf-8?B?eVM4QXVMb0h2ZThNWVJCeUNDalhJMkFIZS9SZ1dQTzRZT202VHgwRjlaYkpO?= =?utf-8?B?RGpURWZscnF1SWpnK1I2cTgzaStrNzQybnBlQ0MrenlRUm0wdFZ5WDNBTm0r?= =?utf-8?B?TFF4RXpCRmVxWWp0MmVzTGwvOVRVWnRPTncyV01OanB4TG9hbm5tbDZmUnF3?= =?utf-8?B?SUxGRDdodWh2SWovb2dxRWc3RHFDbjk2M3E3RzhqbEhNWi9FNk1SZFJQaVpZ?= =?utf-8?B?NVdRTGNLQ2oxSExYY0VteUVCSGtjSGM5VUtHYlYzbmFtWWpWRzZMYmNSc2NG?= =?utf-8?B?ZU9PcmV0TjlSdm15YlJpVEFpTFR1ZjBpeU5BM0N0OEhzck1KYVA3RWY2VnRo?= =?utf-8?B?ZGNWeS9xQnZORkJLdnBnZVJ2eWk1WFdRdk1jODR3eE5BTWFGd3Z4c1ZoczNk?= =?utf-8?B?dGt6UjE2R0IyT3NOQy9DWU15Mmd3Q0txT04vSXRhSWN5VDRlVXRVelYva3NZ?= =?utf-8?B?dUVndDN3SW1Cd3NCUzNKWTJCTE9WV3RDTzhLTmppWjg0SG1nbEFQUCtyS2g1?= =?utf-8?B?T255aThqL0VHQ0lSMGJNME1WNjF4QUI4cHU4T1FrTHJ5c21RV0tNUmppWnUx?= =?utf-8?B?NlQwS0dCUU9ETGNhUUg0M3cxSWxCNFZIZTQvcWJPY2dFN2p0OVdma1ZTSThN?= =?utf-8?B?Y3JaTjg4TGo5aHlZK0ZwVVFzMFZSNUtpalQ3VWlXeEdyT3hlRXFZNm92T01T?= =?utf-8?B?MWZud2drT3BxMXR5RE9LOG9MSkFIKzJkZEc2SWEyckcyc3R1SkN0VnFmVnZD?= =?utf-8?B?MS94c2tsUjhiVFdqNlFKSkpYT1UyMVV2cUJINnc4RWR6azFHbXlVQTlRSGpx?= =?utf-8?B?TXYySVhLNGJoTjJ2cHhDTzgvSnBkeWE2WkMweEkwVzlhM2NBeHhxYURJMXAr?= =?utf-8?B?ajhRaVY0ZzErdVFWWDdXR1ZzN25tQjBIMGdieHlScnRkV1lUOGdScllRdjc3?= =?utf-8?B?SXNUa1hGd0NTakQ0N3ZFVDZ4amZNWmwyQzI3U3kyZzA4TE5LcFkyaUIyMm1Z?= =?utf-8?B?em96V1dZVHp0b1NSYUdyK3RYS1hrcW9kckNQNGswL3JpZlFBaGpwbFhDdDdQ?= =?utf-8?Q?+eCDFVr+gsiJ7t7D/AJGyoQ63?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11eef064-734c-49ba-8d59-08da6e233a93 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 09:51:21.3568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lUoSsa3I83gUbWt2ObSWfFhGt8h4smJNyUp4gdV/siDrbDjJ8ByxrrzC9ANIqrHH/cFo+yYM1NQ0xlzbC5GNjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8284 X-Spam-Status: No, score=-3030.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 09:51:25 -0000 On 23.07.2022 00:02, Martin Storsjo wrote: > This maps to the same as ld's --exclude-symbols command line option, > but allowing specifying the option via directives embedded in the > object files instead of passed manually on the command line. > --- > Fixed parsing multiple comma separated symbols. While pe_dll_add_excludes > does tokenize the string, the symbol tokens in deffilep.y don't > include commas, so we need to handle that at that level. This patch is about object files only, so doesn't all of this belong in the next patch? > --- /dev/null > +++ b/ld/testsuite/ld-pe/exclude-symbols-embedded.d > @@ -0,0 +1,10 @@ > +#source: exclude-symbols-embedded.s > +#target: i*86-*-cygwin* i*86-*-pe i*86-*-mingw* What about x86-64 at the very least? That's the most common target nowadays, i.e. also the one with the pest chances of catching regressions early. Also while I realize that there are several uses of i*86-* there already, I think that's a little too broad. Can I talk you into using i?86-* instead? Jan