From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id EFD3D3858285 for ; Fri, 16 Feb 2024 09:48:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EFD3D3858285 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EFD3D3858285 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::132 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708076913; cv=none; b=QjO4p3Yuu+yp1ufibu7o/KMO5E8v1FOzluqVxV2ni/yMlJgfbh+c9icOXHgLOAvDVC6RIiqmldQoPGFsyoC1/myz90pgK5B2aG3ZEKmQarFsoz4/QOSNk9cj1d2o2aIQ3r42Sbb71F/ecB0OJZtsbMO9ncGZQ8eGUIwiSslBxQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708076913; c=relaxed/simple; bh=Ou0HaEkg+2stWFRPmg6gWVj6Q3CXdzaC9gihl2JGsI4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=p1rvzRdogKSStP/bVTfTqoU4WTMo3loKgfB7Hqy3AwUfXfkkbOiMhjekgxiywV3bV+VRHM2nd17m3m9EDXcLwUFxR0jbTvamw8IKg2qhF4txiEzOod7DcrT1crxRNDAGM/R+/iSTMSmIN6NZ1c3ChrXXOOYCU/p9Z8xXqM2rl2k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-51167e470f7so654222e87.2 for ; Fri, 16 Feb 2024 01:48:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1708076909; x=1708681709; darn=sourceware.org; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=pqkonOwj9FO5X4vaPsFNm7zy2q9newnKMp8Dy+gX4d8=; b=MRvYb7efWlaaC/Ik+O913sFn8sIdKE3ivG7OgZcAfC/TERs0spm31eVGr81/1x4Slf g0Ym6mb90JUj+9g3Zmj4stCJVjego3iXM1JeNSBI8AVM3pa8xyqzFvJ84d5ER0DKShk3 Ay1UusEojrRnX0nvyI8nsQvnBonVERLfTK5KE1SHq2x7ume1btqX4T+cVaowSrE7QiJQ kRPHIgQ4m37Q4ELMRV37IsSz6Wpbe5saEm5jK0qJXBBj+0Ift21muJA+/BvhHUkhh0vd VFZSvCAtyEVzoHvUbDF2xcY3e4yPHOxhOFslYP1OtGamj/fBqUptD+GNIO+AfTm/3IZP Q3DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708076909; x=1708681709; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pqkonOwj9FO5X4vaPsFNm7zy2q9newnKMp8Dy+gX4d8=; b=wwuRTx8i9OGai/JCkbV92YSXkmTiFn7eOmGieZxjon3CVLQVZFE9Ou/bCTodQa/fa6 93PN2+kWcstF8q+fF2/MMp+J8BThLMnX36cDixxwrlHJ9ZApTgn8q7aNzxI+Dbs9w0AX zw97eTSJ6nr82fICv+fx7+HsNkWa1DGAW3Ht1SXgsVGa9yzZo7gDfBiEmgBnYqYirRg+ mw8RGTRyPxHUadfMvLcL2ICsej5AftY8Z/kf7lQLA+PQ8oU5mA3fuTPYLnSHscRXp/TZ 2YMEz5EDNZZTPSwmtCf5Pae0UbO4SdPRWa+OkAqmFWJAfxw2egP8CLu9PNd6M0lKa+b9 aSRw== X-Gm-Message-State: AOJu0YwoMoQa3pPvJKEE5gRcExd2XhWpwvovtyZZWIhJKdpFBHWx4eCL HDGYYnW8lPmKQ3S8wpwRT2Yscdlp72NN+RdRkEBwVDyFtIjEizJK40V+rUpNsd/JcX4q1KtvE4k = X-Google-Smtp-Source: AGHT+IFPk9zaNB5l3K2FeIhsEX1t0zJ6Y1lAAkaXGoVtpqfez+wiDFS7w/TyevSR6EDUC2A53xd65A== X-Received: by 2002:a2e:a548:0:b0:2d0:c996:7c99 with SMTP id e8-20020a2ea548000000b002d0c9967c99mr3276500ljn.51.1708076909435; Fri, 16 Feb 2024 01:48:29 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id z9-20020a5d4c89000000b0033cef5812f6sm1662038wrs.109.2024.02.16.01.48.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Feb 2024 01:48:29 -0800 (PST) Message-ID: <36c19d52-35e0-4c7e-9ac7-956f7efb2e6f@suse.com> Date: Fri, 16 Feb 2024 10:48:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v2] x86: adjust which Dwarf2 register numbers to use To: Binutils Cc: "H.J. Lu" , Indu Bhagat Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Consumers can't know which execution mode is in effect for a certain piece of code; they can only go from object file properties. Hence which register numbers to encode ought to depend solely on object file type. --- x86_cie_data_alignment, independent of this change, likely needs adjusting as flag_code changes. The COFF/PE setting of x86_dwarf2_return_column looks bogus as well: 32 is already in use for %xmm15 for 64-bit. Commit ca19b261ecc3 sadly has no explanation at all. Nor did it adjust objdump accordingly. Given that the author has moved on (couldn't find an applicable email address), I'm inclined to simply revert that change. If anything a proper complete set of Windows register number mappings (wherever those are formally documented) would need putting in place. --- v2: Also adjust md_begin(). --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -3276,7 +3276,7 @@ md_begin (void) operand_chars[(unsigned char) *p] = *p; } - if (flag_code == CODE_64BIT) + if (object_64bit) { #if defined (OBJ_COFF) && defined (TE_PE) x86_dwarf2_return_column = (OUTPUT_FLAVOR == bfd_target_coff_flavour @@ -5409,7 +5409,7 @@ ginsn_dw2_regnum (const reg_entry *ireg) if (ireg->reg_num == RegIP || ireg->reg_num == RegIZ) return GINSN_DW2_REGNUM_RSI_DUMMY; - dwarf_reg = ireg->dw2_regnum[flag_code >> 1]; + dwarf_reg = ireg->dw2_regnum[object_64bit]; if (dwarf_reg == Dw2Inval) { @@ -17461,7 +17461,7 @@ tc_x86_parse_to_dw2regnum (expressionS * if ((addressT) exp->X_add_number < i386_regtab_size) { exp->X_add_number = i386_regtab[exp->X_add_number] - .dw2_regnum[flag_code >> 1]; + .dw2_regnum[object_64bit]; if (exp->X_add_number != Dw2Inval) exp->X_op = O_constant; }