From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 96C2B3858C33 for ; Tue, 27 Jun 2023 14:33:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 96C2B3858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7724A2F4; Tue, 27 Jun 2023 07:34:03 -0700 (PDT) Received: from [10.2.78.54] (e120077-lin.cambridge.arm.com [10.2.78.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E22823F663; Tue, 27 Jun 2023 07:33:18 -0700 (PDT) Message-ID: <36eb5ac6-6c48-ca55-3b40-d35ab3314e57@arm.com> Date: Tue, 27 Jun 2023 15:33:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: Commit: Fix gas testsuite failures for non-ELF AArch64 toolchains Content-Language: en-GB To: Nick Clifton , binutils@sourceware.org References: <87mt0myyc2.fsf@redhat.com> From: "Richard Earnshaw (lists)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3492.8 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/06/2023 14:58, Nick Clifton via Binutils wrote: > Hi Richard, > >> This seems a little draconian (a test doesn't work so we ignore it)? > > True.  In most cases the problem is that an assembler command line option > is being used that is specific to the ELF targetted assembler.  (eg > -mabi=ilp32) > > It would certainly be possible to create PE/COFF equivalents of the tests > that use appropriate alternative command line options. > > >> I'd be much more inclined to rename the problematic .d files as -elf.d >> and then add variants for coff, with both using the same source .s >> file.  Only where the test is specifically designed to test the ELF >> format (or an feature of it) should we be skipping the test entirely. > > Sure - any patches to do this would be most welcome. > > Cheers >   Nick > I don't have time to work on this at present. Could you ticket it in bz, please? R.