From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2049.outbound.protection.outlook.com [40.107.105.49]) by sourceware.org (Postfix) with ESMTPS id 8D5CA3858C5F for ; Fri, 4 Aug 2023 12:04:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D5CA3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fs4DFWRzJqA55zVb9zcVP4ydNuxX3+H0frELQcFGXqCTTmbP6mWTSnerVN+BDOOHXqzgPdUHRtz2ChRrrfKHq+7YUO4POKyGIGs9cJT4XXdkkyGSG0BATjmsDnTDjAMXysbh8abRPtCANnhsneh2y78LsYvqNYE48JAmys/RS9VF0mxhde3nKs/K40J/+P6BH8tbJjdNQQ1s4f5JuY49Fw3auRGpZhaOKpUOkkekzuEd7VGX6IB+DWwlVvI5D3/KlGHsT9H9Jf43Vsk4NLiU6qaWr1lLO7H/JGhUaosx3yq2c8Ikd/uJabZ2m9LDJasvDr3DGGAUGu3JkD+TLytggA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zqLBeM7AWINwNOUamjHoTXUSNtfgZW/aBdw7DGCl9cc=; b=cJ/j3V/y2kL26j+JaEn5AmZsC+kUAqkQ6rFjSwjpyhkm/0F4UNxk9pgOetsFPaBhGJG1U/3IlaPoausjp/DUu7jem/60u2JxGhB4aH3Mwq7BrCr6QBos6TG83A2gFWmNl1Bk4fRTf37b31JSLt9v4XsL0nDboG1jw4Y3Rxi1D0lXeEHyE8IOvLimnhxlEAxMie5s2ixKyWXwHPv9juA5we+Sn3hydMqjir9DvFiWaZYcr9xT4x8P563c8KoBZ7TWR7UpYzkTfUtXG9nZ7D4L2F35RBfncEcYXXFSG6QHleuos6GLu2oqJWb0O/6VPz29vp5RTh35rxojYZNGmBaBFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zqLBeM7AWINwNOUamjHoTXUSNtfgZW/aBdw7DGCl9cc=; b=bZ7LjJF7pMgfXnc/fJGOOGoa5LoHFACNMvVP6CafaNJDn0y6o47e3mgcv8eaMuUGuWBkJl+7C/mU37Rd6hfJst5rx+M3hxf0FPGSG6pz+eoTy7fk4cwjJMTrw8EPZG37KS3KwhGCWR6tAyxgCaBIvlKo8BtgGR6phY82Yt4BlHIDO73kv3I9t7SsOHRc5ChTNwFhm5WGKq5G/eHepppnVv3/6JHltaBOJSUzYOJ9fkp+BBUo2ZWL35HcPSu1hB6tsTn7W0NwLUK4Lrmd7gZGIeSCgsTwCTRoXpoE6MxdUOj+2GHlPzQ1nPCDzIb3mSX7afRTtyhl+4xdzc4rJO9sOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB7178.eurprd04.prod.outlook.com (2603:10a6:10:12e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 12:04:46 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 12:04:46 +0000 Message-ID: <37394934-ef7a-bc51-2f2c-9b5999b2847b@suse.com> Date: Fri, 4 Aug 2023 14:04:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH RFC] RISC-V: alter the special character used in FAKE_LABEL_NAME Content-Language: en-US From: Jan Beulich To: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu Cc: Binutils References: <150b4184-62af-3f5c-c07b-24b0c2ae788f@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0167.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: c648fdef-c9f0-44fc-6818-08db94e2fef3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CAfcfXeeauPmfpLwgV+j/DnDAoJpQrJT9xxu5oXXC5qggHvnVyggKY+s+SNfxF8ttg0hHajhhPTpUQMBSVL1t4M5uU7xvPHTY1w8h+r3vZJ6ewDQ18UGFYGTOXpBbc8iiW88SFtZP4qup+oZRdc4z7wV2hpj+RkeYl/gINZ7UIv3dZHYNsAnxRhz3nianZypW58sTau4WioGwwkFwwVxolLg5VgwG3swpt8RiMjZNeVtfXMsXfEoV8wv9GzZWGdVpId2zDP6gWI136h6wVJnfVg+rwfBVkrs/OVmz08CBM76uNK5PRigLl0CoSbKS/licoxAtuN2cV1mnJGmMqneV7LHdf+51DHgC2i7ga3YKQDQKaCtXsnDWLwpFzB504Wcg3f1rrwBYeSj1Ev0c0GBZDiBjFxb0VVq3IkT8avlD28ubApuk+pFkABGrIKGxWGB8kv16L5wevsMzUtTKQYfCq8wqJimKYipOAPe8PEW6+rG1aApMn+BZiOwWcGQUgtnRDTQ1dWGB8E7XDsKYKGExMh4zjdXo0/lU0c2HV9qBFvATY1PjLDXLxbVqZd8kfChYKXP7xNHiYhqSP3uQzWzKZjQQVPmNsPV0xTVyUC6FXyH5jQAglSYHgVO67D0gTlUWETnX5FsC0j3qmpWh1nvVA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199021)(1800799003)(186006)(2616005)(83380400001)(53546011)(26005)(6506007)(8676002)(316002)(66556008)(2906002)(5660300002)(66946007)(66476007)(4326008)(41300700001)(8936002)(6486002)(6512007)(45080400002)(478600001)(110136005)(38100700002)(31696002)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWc0cURjYVlUYktoRTNBU1VWRm42bGgrSnMzZjBOSndPeGZPUFUyc1NqcFhv?= =?utf-8?B?RFU1Umx3UVJ1V2VXVTNsYy9QeTVwQ1loeGRBU3NjejBDWGtUOERmNDFSYXIy?= =?utf-8?B?dHBRckRCVlBYNWFzWk5WK1NlSDR4a2d3aFlhUG81Vk00eWdFRTVTRUlYNk9y?= =?utf-8?B?V05SQnp2L2Zld2R1Q3JFTmVXM1grVmJNL0VyN1BRUlRxd2oyTVpHN2ZsbFRS?= =?utf-8?B?YlcvQUFQbVpSdnV6TWtrekcwQjRsMUhQR1l2T1hyVk10VSszLytCWmpYODdI?= =?utf-8?B?d0pibGZGTHBIQjdGN3hlTkFBU1hNK2lnVVpFakFCWHorS2VHc0dnSVV6ZXlE?= =?utf-8?B?OFFIVVdZRjZPamRvR3FlQ2V4VDVPRVRHdkNVQ0NDSmw5KzB3bDJIMWViWTli?= =?utf-8?B?TnZhZHBFb0Z5dmx6NGcwdlRnL1ZIbjZ5RkRZTXVzQ09OZGtkOFRGSzhmd1pX?= =?utf-8?B?aUJhTEdwV0ZrbldjQnpzR0taWndSZENKay95dHNFWDNsZTAwSXErNUVFWnd2?= =?utf-8?B?TXFaTzlhTGwvazRnaHpSQnlJUzNSUWZXVk1ycENSWGhobUZWeHVhWlVWNUd6?= =?utf-8?B?OExaZG1QRmhMTVlVb1FlRXRQdFBHcE0yOVNvMEgrdmRrcVpnT2VmeFFjTG54?= =?utf-8?B?TUNKNGRXQ25UTVdGRlNYQ1VIQURaZFJPT0RUamFJdHowN21kUlVRY1VKdHdq?= =?utf-8?B?ZlU5SVQvaTgwbzQvYWJQMExZZWhzdmlsRkY0c0FMUHZFbkFVT2tKU3F1OWcz?= =?utf-8?B?eXFqOGtRNG83ZXpWbDF6bTZwRW1aTXc0NG1RYk5zTFZDbFlGdkJoVDVXZTZT?= =?utf-8?B?eVhLSEV4ZjNleUNGWXRaeWo4aVc0TnZENDlFNm5JYnhEQ0N0eEJncmRVS0dK?= =?utf-8?B?bnlEVHJWa2YzdzF4NnA0VzBDcVpKM050cm00cS9tdmdZZExNcTZ6TTJTcC9v?= =?utf-8?B?N3V2OStDK2Z3LzZKbDdEV2h6cUl4WCtGT1J2MjR6N294cTFxbkU2TWI4eHQ3?= =?utf-8?B?d0M3WjhOUWM3ejJJbW1FeUM4N1NBTERYaEkwSFY2V25JclBzekFDNWM5UGFJ?= =?utf-8?B?UUNmQTRHbmxRdEo1SmJ2NzVuQUdvS0g0cU1adlg4ZlNSRHdQNC9hWGZYMERu?= =?utf-8?B?TW43TXhvWnFiRERPWkJFRHBvK1YxWFBSYTRaMGM1YU16MHJodkwyNk84Tkt3?= =?utf-8?B?U2NBNXYvRHN4V1VwaUlhSGJXMXJ3SkEwS3phbXVQeUNRcTliMnM5dDlKSUJp?= =?utf-8?B?ZTluRytTTlBkRHFjd0RLOS9VSmFNc0kwSC9Zc21INlpWU08yMEg5Mi9nQnI2?= =?utf-8?B?cWtHMHlxdGZLc0xZcjhCbXNtdEk4cXVVT0dKZFZSbnUxVkMra2JjZXdpaFB6?= =?utf-8?B?U3J2WDA0aWdSWkk4ZUVvSm1qSE51bHpSL2djVDRiRjNWK0IycmtVaXhCeXJo?= =?utf-8?B?anBrMEc4ZThhY3dwd1BmdjNLK3lYbm5peUlFOTFRY215MDYvaWFLUHFYbEw1?= =?utf-8?B?eEV1dGpNTnEwTzIrK2ROZi9SR3RSbjI5YnZHSWtzUGlkYnpuSjk4QUxXNTFp?= =?utf-8?B?Mmx4OGlQNmpYZkg5K2M1NTc5a3FNOHh6UzVnR1FtSStlNVZWc1RFREpGdW1K?= =?utf-8?B?SEVXaGZKS0NxTlEyY3VmMkZOR1RybjlOREpJQ01Rc1FXbDJYN2s3U3JWSEVq?= =?utf-8?B?cnorbnp3VG5POXp5dWh2ekZrZnlYTmp3NUkza1kwRHBld1p4NE81WTRPZGxK?= =?utf-8?B?S1RGRWMxOHRxbWtaTjBia1FZbHNDRktxQ1NMY1NJWDFDYXJ4U0YxZXhWclhM?= =?utf-8?B?WW1qWGRXKzc4aElnZHlXMUtla1FqZUFacDZFcFpaUlN2eXpRT2JLbllTdWk4?= =?utf-8?B?VGI5TStFaFdiRUwwQkFZNHN0ZXBrRWhCQXAvSjEwUWJuSTY3U0NRdGJiQjlS?= =?utf-8?B?dldmZkJyYU94RnRsb1kwV3NTT3BwdGdJaHhyZ293VWRRWGE5c2VkTVJ3VFpp?= =?utf-8?B?Sm9LYUZwRnpSa2lwZFBTdktsVWl1cUpnUDBqQ0FVN3ZVTjQxRGRCdlJrNzRD?= =?utf-8?B?c2lvbC9lbmI3cVdYMSs1NmpqQndITkFGR2JLNFNZRFg0dHdRV2xOMCtBTDlE?= =?utf-8?Q?A+4k5gUWD0KIFVhqwG8J5EwOj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c648fdef-c9f0-44fc-6818-08db94e2fef3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 12:04:46.5392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H2lXm7T66gQXkIj+FcvEQwvkR89DNrGuFQ6AOkdYXR3cD3UaYmtE7z2aRu9hMXgxdnOatFhOnr8YI39PAt7kBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7178 X-Spam-Status: No, score=-3027.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30.03.2023 14:01, Jan Beulich wrote: > On 10.03.2023 10:36, Jan Beulich via Binutils wrote: >> The use of a space char there collides with anything using temp_ilp(), >> i.e. at present at least with the special % operator available in >> alternate macro mode. Further uses of the function may appear at any >> time. This likely is a result of write.h's comment not properly >> spelling out all the constraints placed on the selection of the special >> character used. Then again RISC-V anyway violates a constraint which has >> been properly spelled out there: Such labels _do_ appear in assembler >> output. >> --- >> RFC: Of course this breaks interoperability between older gas / new >> objdump and vice versa. But I don't see a way to resolve the issue >> at hand without introducing such a discontinuity. To limit "damage" >> a little, riscv_symbol_is_valid() could of course be tought to also >> ignore old style fake label names. (Personally I view this tying of >> functionality between assembler and disassembler as problematic >> anyway.) Thoughts? >> >> I question the use of FAKE_LABEL_NAME in make_internal_label(). The >> comment in tc-riscv.h isn't correct anyway because of (at least) this >> use - the symbols generated there are never used for Dwarf. And them all >> being the same makes it rather hard to associate relocations resolved to >> symbol names (e.g. "objdump -dr" output) with the actual instance that's >> referenced. Their naming should imo rather follow the model of >> {fb,dollar}_label_name(). > > I wanted to further mention the following: Using '?' or really any > printable character has the downside of (pretty much) closing the road > of making such characters usable in normal (unquoted) symbols. '?' in > particular is, at least on x86, used e.g. in Microsoft VC's C++ name > mangling scheme. Yet as per the comment in tc-riscv.h it is specifically > a goal to use a printable character here. All, with 2.41 out of the way, may I ask that we make some progress here? All I got back so far was agreement that the situation isn't nice. But that doesn't help determining how to improve things (a) without too much breakage and (b) with the goal of not needing to redo this yet again later. Thanks, Jan