From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2052.outbound.protection.outlook.com [40.107.22.52]) by sourceware.org (Postfix) with ESMTPS id 30CF73858D39 for ; Fri, 26 May 2023 10:52:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30CF73858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMzKoMYN4Akqwm6Kwbv9gslCnQxRasilhfEX4hd3gajAsPav+1qURl4hN9aR8K3QdWrSEd1oFLh0gjSDOEUxCYfdrGs2HvT0catSJfRMon6mIInr+i2SvwlM75BQcTx8LjI0uqfVlvSmk6DXQlooynOsDj5h9i+LS9/85RQGgAxjkQTM66CVsexYts4im5pIBtM8AiBX0QSNa2mgZ5sTz2FYi1jvSy+Yr5vCMOCQZAI34HiA3AmXrdieKOLjsQef0AsV+SC5WNNpqJqsMsLKRyeYPGDhI8FiWv2kkuONZyKAN3nY2il5T1i2cHODIDlYs2ckIZe0oRO9OsQDDec/Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GO4pRszLUrcjEVd3AWgqKrUayKXTc4S5M9SeP9gkkNg=; b=ZDLahvRT5oUkBq5aQukKuKKaGv9g8FMF7c5+HhRk2GiR/JmfJLY8qJ+cUwKxY1OYr0n6+iEwen8Ynvp6xKcOq6EA58ksA+TmAfdQ7L99kJGuIH7F5RfyFOo9bmEzDiCs3F8Uk49ChUKoYDQ8yI4+lRXIbK2l3vVDllTOfCuw+JCizxU9smWzES+wtNauFu7RU78LKafgTRE+3lz6Jpo9T7ymELtBiaah93h2NBRUbqqXLsF7sNb8kyXHqcNNMivYAVKSoY4JOizimxu9V8/TjKRa9XAOvE7S4gCiD/wMLup+/ZlGVIE9z3Vl8iQ2ftRbhEivgZPiAookVUNY61R0Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GO4pRszLUrcjEVd3AWgqKrUayKXTc4S5M9SeP9gkkNg=; b=u5GA1ljAnCfBlLiMBOkEUenHKxiqylUdMFIRf9MEbP2CS6RDd3hreDlL2VXE+/7UnZfZanZtWcuotJ/j70mC4zfiT8DuyzB6ZrqcwW1erqMmNn3egyJOgGN/+tHmg5c9joSshFRwfjvjh48nlF7UPl+RR8GW7TL1e4DGuEMOLKAWl8gSCMKY/O3iYtz3de35/CF8/eIt9SzaL/BuYAFLmukOQy3UvE4U/MBylD05rDH/j7qegf7hCvftpiUwB8IIz4gSeXcK/0W/BTuG9MUfNekureQMqEwmivVPxrSWSPP2YkeLg5KoVbRkoDKYwG6Jd5Mn26tvqR+yRhvQTLDYTg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9428.eurprd04.prod.outlook.com (2603:10a6:10:368::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.16; Fri, 26 May 2023 10:52:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6433.016; Fri, 26 May 2023 10:52:18 +0000 Message-ID: <37736f27-73d5-6564-e27e-5e7cd5bf27da@suse.com> Date: Fri, 26 May 2023 12:52:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] x86: Add Evw to emit w suffix for several instrctions for word ptr Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "Zhang, Jun" , "binutils@sourceware.org" References: <20230526082648.1503574-1-haochen.jiang@intel.com> <24df0b69-1a0e-22f2-c1ef-a986293d2231@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9428:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ec3d1c3-fd97-43c1-295d-08db5dd74655 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l1DJi5NVYpLCUUJ7T+/FSV5FMU6zPew0kG4otaCteVnHt+ZcUNGvqRr7aCDZ8sbE++sfm9a/KLigF6UZwqrAG/iP5lj2TI0pKTta+587dApatKM84gllLgRTqj9fh81LUoQhMnqLDJ7RMgeZMRYl4HazdlgCfnHcl1PQhLfNs+2w7NMmfCXIdYbviZFBtHLP9mI0p64i7DJSaogWyMu76pTbj7nx61KliZks4GjEsPUrPFP0avrTvCRYOUlm3mwez+i/D+9A3gY5Bdmvp63S2re+oym6c/GmY0XNvu+TTIThLOXTTmpz56XJWOzF9QpEjz2HJmPAxJi/lwR2nAt2hEK0CuPw7C2A9qigwtHawBpJdRJl5w81VG1zt7wFOfqKG98x7+65n15Me3ZWP00kR6/pHw3m3YD7e10UkJfkmnzsnsX62rC2Z9GHUv5xO4DnJQ1rVsIr0YYj4iKnJnR4TpNuFMG55+dprP60NtSHf3Ua3gO9mm+xqcDnw67yWz6VvZQ3Hf1RMY+kKuXjnV3L+bw7aj4HhLmQpsOEacxGrb3dPl7cfiIT/lM8yKCCzLbBeadLWhaDJ1qJjf7lN493XsJ6LU+FgQZN6BHUwgklvkRFOwx5fAJQ7Q6Cj1uSwTzIDf0fx5rEp9mWRjeNZM+J1w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(136003)(366004)(376002)(396003)(451199021)(36756003)(4326008)(6506007)(86362001)(26005)(8676002)(8936002)(186003)(6512007)(41300700001)(2616005)(53546011)(316002)(54906003)(6916009)(66476007)(66946007)(478600001)(6666004)(5660300002)(31696002)(6486002)(66556008)(2906002)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmlyRlJNSTR4bGxHM2ZuZFQ0M1M5dmttNThMQmkvY3dvNDE2c0h3ZDFSZEY1?= =?utf-8?B?T1dMSnpRQW5DcUg5U1RtQk81U0VselBmMUNmTUs4eFpaL1NUSEtjVzB0WE9p?= =?utf-8?B?SWZsa1k0WndiYmFPQ3NQdjlKSWNkUTdEUDY0UnEybFNMMzRXak1XU0F6T1lL?= =?utf-8?B?TU5yUk5lL1h3SVIxTkZ6Tnc4eGlDSVdVTkJOQzFMRDMwYVNVWVRSQjFlRjRr?= =?utf-8?B?M2JQUUZHSVFOUlQ2cWtJcWd3RXY4cm5xWFhXVllPVFhGdFlhN0dDZEJQN2oy?= =?utf-8?B?K2xOSGd6TTZ1TnZFbXI2UW05am51cVJjbG9UdVBhaXBPbWpGVDVKdlVML1h2?= =?utf-8?B?V01TU0YrK0oxd0tCTXpHRTludkI4VzVxZEQvdTNQTlovbnNKb1hkOE9zdmkz?= =?utf-8?B?RlNCSU1tQ2ZVaDBHa1dEMXA3aUZrSmMxb0F5S2gvL2VrSkhiVXZyL2tkQmVr?= =?utf-8?B?N0c3QVp6T05KUkpDN2xhVFRkekpKSlhXVW1ybWNwclRLN2JpOHl6eWNYcm5C?= =?utf-8?B?YUREZTBGQXN0MC81Q1g2eTk3VlhFRnExSm9PbkN4YmxDTTFTbUI5alZMb0k4?= =?utf-8?B?blArYnBiZDkwMzgxbmdGUExKVTZqdzVVSDk5bGxEK2cyemxoZDNCaGVkKzlh?= =?utf-8?B?eGJzMEY4aTN6L1BkVTBWd3RER0xzWDBCUkpLQkpaVzNKUWlzbEcwcUxMbVpi?= =?utf-8?B?LzU2NkZ3SGpmdkFnRXBxVnRmNDE5UVhEYnhiTXRKZ2YrYjhVNUtQT3NKL2VZ?= =?utf-8?B?alMyMGRzWWJnZ0JLZXRQb1p3WEJVVUtGVnJXU3RhWG5kRU53ZUZoOVl1dXNH?= =?utf-8?B?NUs3dmpRRXVEMENkMk5Kc2dNYjNPa1FUL2F2UGVNZ3NuUm5jQUhRNkxtOUJQ?= =?utf-8?B?MHBwcjdEZjBkWTBRWVRhREJ1Rk5WRGtBeFpCNkFuNTZYUWhiYTBYblFiZ3k1?= =?utf-8?B?bi9WbHUwUHUreC9oekJxNDQvRnVwakorbDJiZ1JNYjlxS2g1cFJjU2RpLy96?= =?utf-8?B?THNPdEpMZWZ1RklhNTV2T1NJWngvaHlBVlErV2Q2a3Q1WEE5MWZJWFlMVi9R?= =?utf-8?B?dzduT0JDM2ltM1pOMDVsNUhFMUxZa1JieENyZTVkTk1zcTN0SnZMalhnYXBX?= =?utf-8?B?aEwvZzdqSFBiYzlOek5ZcVpBQzlyaTczVFBsZ0ttNk9XbTR5R3Uya2hyTlNI?= =?utf-8?B?dHd3WTdBTzgyZm5SQzhTeCs0RlprVE5oVjlMN0lTVmdBamc0L3I2aUVXMVVo?= =?utf-8?B?aFVNUDR6ejY1aXRaRDFlYW14aFV6MEYxeVN6dkhYKytTM2pwTmdZRnlRZWxq?= =?utf-8?B?UmRQdWxWVzZnTTZ0eHhkRDF1T0t0anEvZDYrNEpRY0NyNjY2MXZxSXhJSXJV?= =?utf-8?B?Y2dTd3QrSlpFNHljK3pUWmNVb0ExeHpLa2p0Qmh0bDZUWE11N2tWdGhsUURD?= =?utf-8?B?Wm94dy95SEN5SFd0R2RhT0oxMkFwRHpTM0IyQWplZFhDRmQ2YXdsbFVMT0gr?= =?utf-8?B?dHdxRXh3Y0xOWGZIcUdTNGI3dC91a2U3Qk9FakdXQlF2bGJ3cDhEZExOMlg4?= =?utf-8?B?cHdLcGFjbjQwbU94ajVSVGZQZVBnZ0kyTWdzK0NHSnl6bU00eE1aMTJwQlo3?= =?utf-8?B?S0dJTlNvMlBoWTUxdDVzdk9qcG9RZXJDci9rMEtKVGY0SlpMOXJpeWx2bmVL?= =?utf-8?B?dGV0Smc5MTVrZDNlTDZHaUxESThObVVmYk9aZTBSSXk0MTFpVkttemF6S1dV?= =?utf-8?B?NWpwYklBTnVuZnlwTFRqRWMrdFJ1R0prRU9WSVh5eE04RENiaEJvb29odDBo?= =?utf-8?B?UURDZXYyV2lrZU9Bd0N6Y0YyYjhYZVNIM3R2SHNRbUMrSm0wYzM4WUhVbTgx?= =?utf-8?B?dENNcXNwNGdaQWRNakNLempDTW4wZmVnelNHL1ZTcWdEdUdGTllMQjJUOGhr?= =?utf-8?B?b1N0NWxUQkJ6YlRBRWwwU3M3SWFhcEFseWFDMk02SmZURy84L1F6Z1BlbkNT?= =?utf-8?B?V1BTMVprV3J5OGpZMjNnek8wWHh4aURBZTgya2UvSm9HbnU2emJ2MVNEM294?= =?utf-8?B?SkNWK3JST0hKQjJnWWZsK05FaTJCZi9NUFBDVjJ6cnAzNnpMVzVyMmhJUmVT?= =?utf-8?Q?Kb3kVC7EPKcaIRij9X14lo0sr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ec3d1c3-fd97-43c1-295d-08db5dd74655 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 10:52:18.3709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rq3Rqxk4dyqbLVNxny5jR+PzDryom748NqXbIYvQVOq6/aSUaEI7L8MaFHUoEpM6ScXEjkQrI1PyKCwXJSXr7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9428 X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.05.2023 10:54, Jiang, Haochen wrote: >> On 26.05.2023 10:26, Haochen Jiang wrote: >>> Currently, for instructions lldt/ltr/verr/verw/lkgs, we are missing w >>> suffix for memory operands like sldt/str do. Also the Ew usage is not >>> that precise under this scenario. Add Evw to fix this problem. >> >> So why not Sv? It's used solely for segment register moves, sldt, str, and >> smsw right now. We're aiming for consistency among all insns loading / >> storing segment selector values (and smsw fits that pattern, but note that >> lmsw does not), so introducing a new Evw can't be the solution (or else Sv >> users would also need switching). > > There is a little difference between lldt/ltr/lkgs/verr/verw and sldt/str. We need > to fix the register to 16 bit while sldt/str did not. That is why I am not using Sv. Sv > will emit 'lldt %eax' but not 'lldt %ax' for current testcases and I suppose that is not > desired. Did you read my reply on one of the "Support Intel FRED LKGS" threads, which I think I sent before this patch was sent? I do not follow why you think "we need to fix the register to 16 bit". Jan