From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2044.outbound.protection.outlook.com [40.107.13.44]) by sourceware.org (Postfix) with ESMTPS id 6EC1D3870568 for ; Tue, 13 Dec 2022 07:47:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EC1D3870568 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=El5Nlckm9ziB0GZlvaHPOqtAFTdO//nmKtHQt7uMssMIfx7P0jz4qqPIHQ5mQ9mWMiMk3Y9mDXmELZ3jFAyYlxGkU+I3exx3AL/TrQpT4NcXzVx6dEOgxBtA8jYhzgRzhrEHe6uraZIVlcP1yDvrgwqhL8VUozE9N+ohMEI8zqYXVqsWXGsmjs3yd01VQXbhRZknPO3OrrgtSEPtbi3jC/Xo1bObPE90ZntUfPHBsEgypf5QPi0lrJDJEkVOvJQTsqQBnp34r5T7Gh/WIbj1xfZa1sYeLJ/KVcTQngPowtGRpltArwb22rsbdjvzVxCJPP/uMeSYKYZAXrptVZHOow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7xAKFlw8URISa8OnJSUq32kW8sx+zHXhFIvMVDWRDEY=; b=Ks+FmGWUH1W3RoQiJTtWKsbIMjpJdZFi1Un0nvTeNlv+H4B6SakFT2FvfkydLeS409q0v/ms+P+1CZQO1UUp6vDbw/NgQYheSOTmfHwGB3u7PmLvJKboTAX37EyPFyJV4fDJIBWOIM5QHwCU2Ufj4Bzyw98djuEsCwqmdDfi6+rJVlNSPkwmfX4nRyiGIul7OH5G1cREGzsPMscnWyRIm604YdqV4ijf+AZwHHUlfGfwkBIeD3UqpOkqm72XPCgWb6/Mrt0Au0YqRzkusSgBcpoMGBhNj2Rmqj2AU0Gl8jCSdKU0PSDEGcULBNRskocya6l6RwcdHGNnAB8NFBDQxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7xAKFlw8URISa8OnJSUq32kW8sx+zHXhFIvMVDWRDEY=; b=x3ntSL6SC/tSxMoYP+RAEpmAsarcwy7ify3A6E3BK4Sgw4UMuAg15QIUt4WovZ3Li6BSxNKQxjb+6p9P0OfH7NtZ/bDsmkK6jhROw0ygHnu1m6jFKjWCRo4KMz8Fh7jYxPyskDpQRLJGVu/ed1WSbY87WDMZQNavd1rryaGEn6jTS0yuveCfkdT6QtfjYjdi14zS3MmUcZW083hkFIgA4QwEw7hLQQpNnHgCv+8eVV0yG0QuuTrDwWbneYLkhgDzEwemotjp//Is896FMcXEqsnJs6dvgQez5NlF1rirbTCBtFgRpWbgdwQSZRopa9IaNujEqxvwXVsb1yZjLMP65g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6968.eurprd04.prod.outlook.com (2603:10a6:20b:dc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.10; Tue, 13 Dec 2022 07:47:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022 07:47:19 +0000 Message-ID: <37a5019e-57be-9052-9b73-c2ce1dd05b50@suse.com> Date: Tue, 13 Dec 2022 08:47:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] RISC-V: Add string length check for operands in AS Content-Language: en-US To: Li Xu Cc: kito.cheng@gmail.com, palmer@dabbelt.com, binutils@sourceware.org, Nelson Chu , Andrew Waterman , Jim Wilson References: <20221213043428.33155-1-xuli1@eswincomputing.com> From: Jan Beulich In-Reply-To: <20221213043428.33155-1-xuli1@eswincomputing.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0092.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6968:EE_ X-MS-Office365-Filtering-Correlation-Id: bacc2f94-ce5e-41e0-3dbc-08dadcde42e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: of79FuDkT7Dcpza+UTOyu7xebjJfktRVklJ1SxV2XwWjpIEdhYPR3JXFGkR6vwzRUCxxCLbzvNqCYUTJi1NwhaB9ZWs0+V/YgfuoTIlD1wTaOEbA0fHgxhE9qGH9jyINwk+kPZ3M+zZoBL+3I1JKzIjJKIz9FVDAmnKw0N9wSTdbWuARJeJVAeRj5+Dw5eBgup0NKoBDZljytdQghFWK1VrANQ84PnWBg8Vwf6KQvSPFromeJEFl6L0vG74PI2ohMU+U7NtQBoo11RMj/2ZE7YKOLvb/rRKo2zv1q3vQgRdJeEhXCC2eJz/UTi7Ru2NMMo54O8r2hvw4rH7r6Ly0sxUpuAjIPoMoKGtva44INIeFEDG1j+0nUUdt8xDESCSMCLkJmjmU0sUNd1cd7ORtYKbeYTSecytHEox7OlI/HL9df/NPOaYCjNMHqsqN9eVEnhGZvQIFI5D7u9ELxNAIr2snwYgSr0S7TQXSHDUOGKn1YwI8+sT8lG82B5OLA9PspFwdvpMVrYh78hCZf276RK1/GXvivXz57h1vVenDtaUrtcUZLtTNLYqR8uC8tgNyc3sqnvCvINCk4S+TiMopjDXqkdgvAEl7/VEXPjpbNohggRxW5UbLEe4h+u6Gu2ODmMs6NAuTBX3w5YBd9gw/tzlmXJAGJDFJygnUsCkNqt+EV2TiO3uFY5uvxwKWXZoZCxPNT/0AUMlHS0+Ib8/xtBL0PWbQG6sOkZzlS0f6rp4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199015)(6916009)(54906003)(6506007)(53546011)(316002)(31686004)(6512007)(6486002)(478600001)(2906002)(41300700001)(66556008)(4326008)(8676002)(66476007)(66946007)(2616005)(4744005)(5660300002)(8936002)(26005)(186003)(36756003)(31696002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmZ2Q3QxbkloRUFOMmN2N3BDSFNLRWlXamF3OGM0ZmdJdFJyT1VRT29samEr?= =?utf-8?B?SEY1bSt2bmxtU1U0bkZtaVUrLy9kM1ZVN09vYzk1VXg2UXNuZFUwTXBRalBO?= =?utf-8?B?MUtPTE1aUnNSMnlha3lDK05CbGpaRG9KY2QveWIwVXo2YmxIQzZwWWFjaTRH?= =?utf-8?B?TkxoVzBJR2xueTRray9mOHd0dE84NmM4U0h3amN6NmtjTnV2RFN1aGFrRHha?= =?utf-8?B?SFFKSmx3L0cxZ2hJeDRnWC92dlZwWmowTGtjWmdwUzByZ2toRU5WWjR5Vy9U?= =?utf-8?B?QzZibzE2QmZFRzE2M01FdWd6TkdHazhJTWhTUlZySGc4M2I2ZUFNNHl6aERE?= =?utf-8?B?RjRWSHF2MWkvbGMvZ2NnK01qK2JHZ3Z6M05IV3prQmlGMUFQSmFuY2NPcDJN?= =?utf-8?B?SmFuaW44TWVnVWY4UUI0ZlZWWWEwNkttY051dWxEYmJSdXlVQTY0Z2gyYzRp?= =?utf-8?B?MjFOK2xFL21vRnBYTGdjdDhSNVhNVU5JTzBEdTJXMTV1T1JPd1BnQ2dDMjRR?= =?utf-8?B?dDJLOHcxZDdid240ck1ESktSNEpERnNSazB1bVNEdkhhU3J2NXNMQXhMTkIr?= =?utf-8?B?OXlsMFVVY3QweVJDNHN4b0lnSEs5SVFvdjVBTm5qMk83UTlQd0VkTUYwUXpt?= =?utf-8?B?SjUzUTJCaWdvM3pWV0tUemU1UHRPMWJscU14Y3RtNkN2bUViVnBEbDNqSmJo?= =?utf-8?B?b2M3UjBabmVnejd3NEdaS1VzZytuM0xCdTFNQ25SLy9SaE9DWGM3NUJWTnEy?= =?utf-8?B?bVg4VjVXNHVMK0RsYnVxNFg4VG1UdTArQVR6dW5jZ1drRmNkb0FkU3ROZFVm?= =?utf-8?B?ZnJ5bzBDbHR4cDRENGs0b0xUVUN5eXorUi9XdE82ZkZ6Y0NHeEhEWUprQlBV?= =?utf-8?B?ZDNNNnY2WkVyVHA2QjFVUmtCZ3ZpaHhQWXhkekNxTzdJRFlpZDdoeDhVZkVE?= =?utf-8?B?UnQ4REp1STZSZml6ZEdneHZxY2JpMzJKTkxhMlR5SnZPd1Vsak94SkZtUDlh?= =?utf-8?B?SWp0WmFoelc0bFBwMkpsOW1NWVlSOXFRRk9uSk0yVzRSVmhpOWJ0WU9vV3M5?= =?utf-8?B?UFV6MlMvZ0ovVno2d0hSYWkwa1FRd2U3eWMwU3B5QldTWk9ZTU1HeFQ3QXNa?= =?utf-8?B?Z0lOT1hLTmc3K3RGQU1XVW1aeVZEamh2MVNYaFU5anJRQndhd3lyOXF4UzJW?= =?utf-8?B?UzZuUnVxME1oMk9PS2lZbXF1MmY1STBxQXNXZkVkZy9jSXF1M2dPb2w4MTBE?= =?utf-8?B?TWpEU3ltTlJEbjRjbEpnV1dBTkdXRUp1M1FLVnpjMmtUYVNoOVRDQVM3cGls?= =?utf-8?B?Unlsb3pXc2w5OXFxNTFBYk5ndlVXa0V1dWE5Z3paejVPTGI2NlZxdVE5MUxY?= =?utf-8?B?ZVJpeG10aGZHN052eTlRZWpKZ1d1eW45cnNtZ2FUMUo1cm1vVit0c1pmWEdi?= =?utf-8?B?VXFtdWR2bVBLS2dDL3Z0NGdWSWRzOUxoQzN2Ti9rY2NNYVRaMUtoMFp6WVhq?= =?utf-8?B?OC90amRoVlAxZ1pPVFFlVjMwbHl0cVpTTmptN3RTVTNzQU1yamJ0YVhXTDVY?= =?utf-8?B?Vkt5bXVDWU1jYkkrN3VhQStvS2l4T250THJHa1lIQ3dMLzRlbnRmMUQycUlw?= =?utf-8?B?Yi94QmFab1lZT0l2c0xURUZlYnhFeTBqVUZVc0FRNmdtZFdMbXBSM1R1U1Rw?= =?utf-8?B?cno5Yng5aU1MZklHVGZwanpxdTJUS1Bzdks1dmVPRFMvVHNRVEo1Z3daRDVP?= =?utf-8?B?dW9QeTBPbk03em1aUmxJTTZjRlFlTU9iRzlyVmpHY1gzc3hQYU1sUjNZb2po?= =?utf-8?B?dzdVZUI3ZVNTcTBpRVRsa0V4ZjhuM2EwZXd6NWoyd2dnd3JqTkJDaFdpdU9X?= =?utf-8?B?R0QwYTVvTnNkRUVHSTJmOTNPWUNGbkMvcVd3RzJjZVJoYTRHM1o1UjZkVVRM?= =?utf-8?B?MmtZakNEc29FcXA2cFhBNnNWTm1kSkRXRE9ncE1rSjUvL2pxbnEzaVUrRzVm?= =?utf-8?B?d2g0YkxKS0R2Rmc3ejRjZHRKTVlsOHk3cGU1RGtEWVp2R053VzhibkczMTNC?= =?utf-8?B?bVA0c3N3ZTRjRWZycnlqaFROMXFNSHdocEo2OGt5c3Y3QUIyVW1mRDFHM25w?= =?utf-8?Q?qseb5TiE5y+quMs6xfsR1qSDb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bacc2f94-ce5e-41e0-3dbc-08dadcde42e2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 07:47:19.0570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2lFuFIXYk/SjCVYD6yKEAD+oesKXy15UPiZUJi/EdR1iiF6b5fZ0wFHjzvAJEYww81ULKSm9O1FiYn4QgqSGZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6968 X-Spam-Status: No, score=-3028.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 13.12.2022 05:34, Li Xu wrote: > --- a/gas/config/tc-riscv.c > +++ b/gas/config/tc-riscv.c > @@ -1206,7 +1206,7 @@ arg_lookup (char **s, const char *const *array, size_t size, unsigned *regnop) > return false; > > for (i = 0; i < size; i++) > - if (array[i] != NULL && strncmp (array[i], *s, len) == 0) > + if (array[i] != NULL && (strlen(array[i]) == len) && strncmp (array[i], *s, len) == 0) A couple of remarks: First of all this looks like another case where startswith() might better be used. And then style aspects: There's a blank missing after "strlen", and you will want to be consistent with the use of parentheses: Both pre-existing comparisons aren't wrapped in any, so any new one shouldn't be either (or, less desirably imo, all three should be). Plus finally the resulting line is overly long. Jan