From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 8A1D43858D20 for ; Thu, 17 Feb 2022 09:35:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A1D43858D20 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-11-SMm-qJpBNCKTZNglC07lrA-1; Thu, 17 Feb 2022 10:35:23 +0100 X-MC-Unique: SMm-qJpBNCKTZNglC07lrA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dJd1lp3+9aFCL1bvSo69sui6iBBCvAg3xAQINZzWAOLNxUYXkOMF4JNgjbiHPOX9miq5p6MBsg88mlTvwU1nuWbBlWdO2RmXsWzn6PQRfgOQMYf1dlU2XjDak8yxmBIkEQ6SIQsMh3CkWuD1NvFqstmVYwKfirjIqaNyhdHw8W381GpLL8nobC+NH3vklZG9qz3dCCbx7rt0HCyIvAyYZtXlH1l/CzotetvS2otlypM7OZIi9qllU40XoKAeI9JJOHgM7+uNdBJpr1qOAefukEzIDZkNiDHHSkOARI5QqBNiFeMDp5EVmcSQLCe9Y5iK75eM/POu3AMwz0W+VhLNqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UoFEEGoGYHErKxBZOvqWdvdQ4FgLWyuSbJYBv8GN1cY=; b=bu5UnEKL/XB+fB9OPnYT0AZDi720v9yFnJzQ0ZcDnAQjxi2WwwiMSPQqtzaVeoCpXk9PGDCszIejpeQhlMu5y+OwH+PvCMN47/wlADeB6sst/xoJshmluqw/TSHyHM2xNdbqgXvUzWJtwsfjHFXfhnv+4P421TaUY4MKUEQQKiXyeopnbgvMLMDOclF/ZcAHL51i27DjLYIhYL8IwM+axQ+wBzDTArvFik53T0w02VvzkwC0J8CRR9oELdPpo2FWlQ/Y0i0EdWx2RkwT7K+uFxqSiCXm9Yj0RdzdoV9pAduE6RfHwheqw2yeMXDszBhqz3mcDCJj3DAbeU05qtL12A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM6PR04MB5863.eurprd04.prod.outlook.com (2603:10a6:20b:a5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 17 Feb 2022 09:35:22 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022 09:35:22 +0000 Message-ID: <37ba6375-00cf-3041-ee79-21377558402c@suse.com> Date: Thu, 17 Feb 2022 10:35:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/3] opcodes/i386: partially implement disassembler style support Content-Language: en-US To: Andrew Burgess References: <11996f886e69218629abf81f8041269e8740a60e.1645043588.git.aburgess@redhat.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <11996f886e69218629abf81f8041269e8740a60e.1645043588.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0277.eurprd06.prod.outlook.com (2603:10a6:20b:45a::33) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b82f3cc-b987-40c1-43e0-08d9f1f8d181 X-MS-TrafficTypeDiagnostic: AM6PR04MB5863:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WDjL7bpu6YNjXdKWuyTmIAqKEHr1c3enYjT5iBWenOx4c0sIDnSUpxGtogmkWcRd38uE8RzzIaKtOCJFvpYaBYmjDK3pWUMXWJiBXRrFAMsBznPqoLt9KTrMTXGF3Y+YiUir/GSUeMAnMr7KDk2aaz4HdVaVgNSsMJWdYf1oTmdFms8e+z0efRG8MApP0T64e+G1UCMAwBEVzfYIwSQwSmUp4PM42b3jUwGbNRQKb1YkbiLdc/Tm6tm/ZC1L1LqxeMf3HAb17JtDMF2HiKW0H3pRwjgKGg3htZW/3njCTUZQ2mb5VR/7EzHgVNgeQ/disxAm6VxGPQdX+/NMzHDZMib9LYtQig7b3w+ZRAlH+37fuoWiRGMsR4zKXJCoH0rxt++H/G3fVq5qa/mfuzLrFmt7KJKvbPDzpfWS0fLUUK0YkgfWiOBQRVVUP+a8c4Vw6rwEfj8zejBchXsab1P1K2B8IhJL93n9UqFdmmkLav/XeXviHVEe9nOP/xDAXO3Lhre9A5bhPTUEKYt7SreEXZl9M43yNCV+KbxWarTkD6J2bQQTc6apmyW6gmpJMUF8IvaZSfGrgKg1g5hXYf6qIh8SFpVpDnLpt84lwwD3N9DCSFvEPLwOLfw8D62mM0XKvRmEouDbutEPA716Q3fVpqDDsKfu0UXf6EQMayAT0EPcDtXqO9VcbigNzQOxtyh6waiDpx1J9dxi+TaXkSKwcTL3gykWTMmqNeybhXaODCQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(6666004)(2906002)(8936002)(53546011)(6486002)(86362001)(31696002)(5660300002)(6512007)(508600001)(4326008)(6916009)(8676002)(38100700002)(66556008)(66946007)(66476007)(316002)(186003)(26005)(36756003)(2616005)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUk4Y0pXL1hKNy9xWTZGSzJYZG0xU21xSzM5WElsemNETFZadDJlbGpCaUtG?= =?utf-8?B?SjFhQmZHOHhWS1Y1bGJKOXB6dklUUWlqS0NIOENlMmJHd3pWTXFLb0lJZHdQ?= =?utf-8?B?OFhYMlJPbFFvZ1cwSnVLREZXcmJEcjI4WERaaUtERFZVTWZSOEFUck5ZOUVM?= =?utf-8?B?cVA5TUJybm1XbzlLMzFCR0RMVEpGTjlPa2tEc3lEVENNaTU3S2J3bklsTDdx?= =?utf-8?B?R3RxbFAwbmZLY1IwUGw1clNQcmRFYUUrZG92QmRWdmZMR2tLT3BqQkpRVjZ0?= =?utf-8?B?RnFoMTJIYnF5NldPaGZUZVdhYndNNmVnN2pXcFdLV3loTU1aVTY0Mm05Ujli?= =?utf-8?B?Y2ZwS3JNcTdldVVBeU10UHZoNkVpazVKTkZJZms5dW9QV0c2WURnMEFjN2tz?= =?utf-8?B?V3NyMUN5R0ZTUDBlZE9SeTl3WEo3YWJCOW1iUnlQdW94T1ovdlJudUZHaFZM?= =?utf-8?B?WkZhbFVTTWdDa2E1MWZtZmdqQmxucDhLRnRkT3JndE8raFNJTkc0V1FaY1JP?= =?utf-8?B?ay9KeXZVV3pFbEJSM2kwRk02MWVhaDVENnpwWDhVRnhoc0ZGcnFUVmZndGFp?= =?utf-8?B?WHZSVm9JVkNOMGRuMFR0YzhxdWlJbEhjVGZSdXQ2RElzWU5Cb1JLWlU5cDJY?= =?utf-8?B?ZzdMRFcrVmljcEIwVkhlQWdJNGRFeDdpd0l1T2MrRlIyYVRSQTVubTdCSzFG?= =?utf-8?B?dGVxbDh6cVAwazI0RmNNNTFBZzNwaUxUUnhsWk5NK0QrUGhaSXZDTUJDamR1?= =?utf-8?B?R3c3V3ZtMjZrYXZYMVAydHBySU9kY3lkdVdSWnlHV0tlRWdhdkNCTGVKWVBS?= =?utf-8?B?dzg4UmQ5NDFvWVRrTGVOZWRjK0E3T1pYN0ZaRFhKeVJ4ZHBXNjZobVNMM2Q5?= =?utf-8?B?RXJYajIrL1dXVlJhZUlxNkMwODhEdjgwVDZCU2F5cW0zdDk5bXRDMnFEd0Qy?= =?utf-8?B?MUhSNTlHQ08rbGNnckJlUzhBaU1hMWVINFg2MExRamJveHRMR2FQNXA2Q2ZZ?= =?utf-8?B?dDdSSkkvOUJiSXRQYmU3Mm5wb0xmaW9MMVNZNDJrK0kwNUZIb0RNaC90Q29F?= =?utf-8?B?YXBZVkpMa0Rzd1dBVjZ3MVUyRmdEWTg3WkdxOC9YYXJFWTQ4dmZvSHUxbXhP?= =?utf-8?B?cjhOWkhSYVhZdDE2Y2FJU3lQbVQxcWkzY3UzZ21iT1VWeHJWb242NE9uczFy?= =?utf-8?B?MzUrNnQxVmZIeXRidWpaRytPWHoveVAzNkRnRkJrWi9DMkUrYkExZjZsN0ZS?= =?utf-8?B?bkZTOEtaMkYxd3VDb0haRU94MnN2L1MyU0t2ZUdjajZNY3lZUEtoVEVxb2hR?= =?utf-8?B?RzR6UDRPd2F6UU9NMHF5MGc0eDh4dzVCL1F0RVN4VEhXKzhVOHVGZUhmWjVK?= =?utf-8?B?aWhOdFFDTFErTjhrQjZySGh2c09aYUU3bldUbXNyVytQTGN0KzltUmVtOVV2?= =?utf-8?B?a2J5V2NraXhPWmlsV3p1QlJycTh3VG15QnJIaEhlSFJmb2hUZk45WkhLdExo?= =?utf-8?B?cDVFQmg2eWRkSm96RFZtY1UwNWhCa2toZWlQN2R5Z0IvU0JSWjdkUXg1TDRM?= =?utf-8?B?NDk3Vk91am9hRHNqaWEwMFhpV0RMd3hURjZzT1h3L3Rhb0JBYUZyb0N2WVR0?= =?utf-8?B?RXBleHFLNXVSdGt2UVh3R3g0dW9iZjMwSm5yblQ4dFlRMnFDMlZzUVNydXc5?= =?utf-8?B?TFkxakhPSWFwMlZUemdtTXN2VXZ4VHlPM0I2V1lyZWowc2VicjNrU3FrbTIz?= =?utf-8?B?ZWRHSzRwVGkwR25pY1gxREtHbzVEQ3VlWDlubmswS1QwN0NJSytEL2hhbzU0?= =?utf-8?B?aDBLaHZMREFVOHNtWWJLUHlZRkxQQ21uNVM4Yis4Z0dDTXkwNW93V2U1RzVJ?= =?utf-8?B?QWM1S1hQOGZyMVdaYzZqQkk3T0JHVm9uYi9QRGdyRVdTeHh2ZWdiVXJBb1o3?= =?utf-8?B?MmxsZzRNdk9mZWFzcTd2ZStPY3ljUFJ3c0oya25KYjJrdW5GV1JOTG9SUU9S?= =?utf-8?B?WEl2U0x4QmxYU1ZNWmpIMk1XbUlod3Q3MVEyNUNjTzlMVUo1T2lCZjU4OWFU?= =?utf-8?B?T3lxQ0dEZ29VZ09BV0hGRUEzM3R2MVE3Mm4wbElrNCsrV0hlbXJtZXMwWFpL?= =?utf-8?B?NDZ3a0N5Z1RHYWwwRWNvMlVNN2hCcmFXdWJzY3dGN2t3Z3pJcFhlenVJUm9u?= =?utf-8?Q?Hn3y7T/VfG53UoSZfDFJiJA=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b82f3cc-b987-40c1-43e0-08d9f1f8d181 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 09:35:22.0447 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WaHUOfOaojNUWVCGhwcrFlcGmBFkVKi0paxZbF1UBxCbWmtDUMF0k7Jm+WGFdVZxmZwWUNFxrO3a0pQG8hxg7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5863 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Feb 2022 09:35:27 -0000 On 16.02.2022 21:53, Andrew Burgess via Binutils wrote: > @@ -9456,12 +9456,18 @@ print_insn (bfd_vma pc, instr_info *ins) > { > name = prefix_name (ins, priv.the_buffer[0], priv.orig_sizeflag); > if (name != NULL) > - (*ins->info->fprintf_func) (ins->info->stream, "%s", name); > + (*ins->info->fprintf_styled_func) > + (ins->info->stream, dis_style_mnemonic, "%s", name); > else > { > /* Just print the first byte as a .byte instruction. */ > - (*ins->info->fprintf_func) (ins->info->stream, ".byte 0x%x", > - (unsigned int) priv.the_buffer[0]); > + (*ins->info->fprintf_styled_func) > + (ins->info->stream, dis_style_mnemonic, ".byte"); Perhaps better have dis_style_directive for this? It's certainly not an insn mnemonic. > + (*ins->info->fprintf_styled_func) > + (ins->info->stream, dis_style_text, " "); > + (*ins->info->fprintf_styled_func) > + (ins->info->stream, dis_style_immediate, "0x%x", > + (unsigned int) priv.the_buffer[0]); I wonder if the naming (dis_style_immediate) isn't misleading. As per the comment next to its definition it really appears to mean any kind of number (like is the case here), not just immediate operands of instructions. Hence maybe dis_style_number (as replacement for or in addition to dis_style_immediate)? > @@ -9497,10 +9503,15 @@ print_insn (bfd_vma pc, instr_info *ins) > /* Handle ins->prefixes before fwait. */ > for (i = 0; i < ins->fwait_prefix && ins->all_prefixes[i]; > i++) > - (*ins->info->fprintf_func) (ins->info->stream, "%s ", > - prefix_name (ins, ins->all_prefixes[i], > - sizeflag)); > - (*ins->info->fprintf_func) (ins->info->stream, "fwait"); > + { > + (*ins->info->fprintf_styled_func) > + (ins->info->stream, dis_style_mnemonic, "%s", > + prefix_name (ins, ins->all_prefixes[i], sizeflag)); > + (*ins->info->fprintf_styled_func) > + (ins->info->stream, dis_style_mnemonic, " "); Does the style matter for blanks? If so, why "mnemonic" here, but ... > @@ -9744,13 +9759,17 @@ print_insn (bfd_vma pc, instr_info *ins) > if (name == NULL) > abort (); > prefix_length += strlen (name) + 1; > - (*ins->info->fprintf_func) (ins->info->stream, "%s ", name); > + (*ins->info->fprintf_styled_func) > + (ins->info->stream, dis_style_mnemonic, "%s", name); > + (*ins->info->fprintf_styled_func) > + (ins->info->stream, dis_style_text, " "); ... "text" here? If the style didn't matter, a single call (as it was before) would seem to suffice in both cases. Jan