From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id D58B3385735D for ; Tue, 25 Oct 2022 13:54:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D58B3385735D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1036.google.com with SMTP id u8-20020a17090a5e4800b002106dcdd4a0so16387574pji.1 for ; Tue, 25 Oct 2022 06:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j4qlpoPApcOE4ghPfjPQDasxxplafqb3R2p6VMgTvbw=; b=LlH/9TFiDnVQlYX40yjv/9u20ZHtC/uKvVAkYSnCsBd5yziNhiRl1ZgLrLCAgAeJhT 12k4yTzk3AUELpQTGwLEhSwwDavLMc0Kzpn7NBO/s+uROKOr9uUVMl5fAdBEE5wph5+e GQzN8eFuSUMWxCJzpHejB5Fq5cem27As17ezou1sy4NoA+lxo1HfVqxJffxITGRhbBSZ boneXlMot6bk5x/WceiyBZ9eMgQvKfL045rUXKHkmKwZrO9wt4d9K+huA1vS70IP1h8o shTrSzevw/vAnnhWaspGB4r80Qp1MdYjoXCfMH8Yodlm/wtpORlLnnkMInXQ+hzOlHgt dhSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j4qlpoPApcOE4ghPfjPQDasxxplafqb3R2p6VMgTvbw=; b=6HISroXxiQLweaI3trCRvcBBIouypF9hfbcF/+KhqJOi6qu8+FAR6SlQnAAAtxMObD fepPsYA55pGrLAKzKND1n/P/vgXe0v+5TymygsdVeR0TRiOS4Lnkapt0G1eOzvzOhP3S qGBvnJ/uIopc2Oz58u4GpXu4l42GjQJytyoBjbMtIknbjFZ8PXcoOpM7qZ/nEMZE28w4 xIrrLcJwtXzbAAzyM6E3fk07NvtOmtJC2qOWwuIBKjnam3a30B9elTfaegw8LrszAlX+ nQ3OtS6nbKlfqJQsz2M76wd1lGIlCbRJp0C1XOHaPfA+Xhw1KndHhEzFCzlsJwQj15HG 9Bfw== X-Gm-Message-State: ACrzQf3Q98YZqSUAAIrPacf4fMX71XOH64JZoeuRqaJaYOT0iRcd1VZC czurPU6Mnlf9qzFTfj0AsYY= X-Google-Smtp-Source: AMsMyM5gKkEAKQ9mAQb7oegU6pf6dPTVrT2Q4ymnP63YQ5iaCQV/x698PAUtP+POeFiQErPWaJw/3g== X-Received: by 2002:a17:902:d4c3:b0:185:4c1f:7457 with SMTP id o3-20020a170902d4c300b001854c1f7457mr40582032plg.117.1666706072827; Tue, 25 Oct 2022 06:54:32 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id p25-20020a635b19000000b0044a4025cea1sm1260438pgb.90.2022.10.25.06.54.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Oct 2022 06:54:32 -0700 (PDT) Message-ID: <37bcefe7-ad9f-f766-37b0-e682a66f1eeb@gmail.com> Date: Tue, 25 Oct 2022 07:54:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 15/40] sim/h8300: Add "+ 0x0" to avoid self-assignments Content-Language: en-US To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Nick Clifton Cc: binutils@sourceware.org References: <5ab303a5bdfc1da7832f8fa22f57678c9ef1a5fa.1666257885.git.research_trasio@irq.a4lg.com> From: Jeff Law In-Reply-To: <5ab303a5bdfc1da7832f8fa22f57678c9ef1a5fa.1666257885.git.research_trasio@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/20/22 03:26, Tsukasa OI via Binutils wrote: > Clang generates a warning if there is a redundant self-assignment > ("-Wself-assign"). On the default configuration, it causes a build failure > (unless "--disable-werror" is specified). > > However, removing self-assignments in step_once function makes the code less > readable. Instead, this commit inserts dummy addition to match the comments > "Value added == 0". This is redundant but will suppress warnings and > matches with other branches better. It will be also optimized away so we > can ignore performance impact on this. > --- > sim/h8300/compile.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) OK. jeff