From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 7B3C93860C2C for ; Wed, 20 Dec 2023 11:00:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B3C93860C2C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B3C93860C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::430 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703070045; cv=none; b=hl4nbxBlA7XNs9IHck9+p6xpS72rTCef8rb1xmwIystVqYjSSI90YFd5yh6fqkeHsvaRR+fksP+QYOtNRyc6l9NGrgr8ra9zRGlGYQnDphDW5RC2U07PiyFkfZfJSd/ONZX87cvn3ShrTO2/8EhgAGMLUa7b/QiUIGi8YqxP9S4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703070045; c=relaxed/simple; bh=obtoZePkrcMPvSEzS95FJaS6d8GHBs2L7rEtoZPKu4w=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=uEhJ+uL6QOZge301lnRRA3zdarGpU3/rsBJsdUSIiJCLUoxWSW996uOFf37q9JkquGK6aUhp46W8luMxIOgJK5z+fdlNqQykhVjvNyRk+fxM9FaKyoLdINEgtDKWpO+zWDFAQPRUbiSlPb3fzXDMe1pzzeE5SxnAnelqOxZIE8A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-336746a545fso366671f8f.0 for ; Wed, 20 Dec 2023 03:00:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1703070041; x=1703674841; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZduSULUA6SIEdkMUfrWH1q7C50LM7U/EN1uZ5H2cJdA=; b=AndEcqRZqH02S2sh9PXAcPl2EIhnKgpuVbRG/lJECNDc+OCkcBDKq7CE0lcPgO804I 1O4Hx+SLOeXKZfue1CSwZbyJ0lfoASD8Mgj2ef7UTK83Dm+cIf8/EqKJ1UUlrDumuZ3A 9vc30Zt0ptpQj+dvUB6CWnwBFTyECW6k+nFsr3dhMEhz6Qq/DrLit+6LCbxFPBZpeaY5 6MT5i/zFVGOMBEBkYbjRIz/fcfNKZr2+TWTjagZcqSknTPZXP2YYjrlQl5bACLszba7U S5sAWEkrhO9yFYyJlE1waDy7wwgojJiWNgsv+1QF56cxLyuUkE87RFlxM2NPOCcSnRzj Fd6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703070041; x=1703674841; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZduSULUA6SIEdkMUfrWH1q7C50LM7U/EN1uZ5H2cJdA=; b=d9o/dnVG6bD1R8YvBDdALxPk6kdZGhRXqyR+chgik+HYElOKM2g69DV+Wrd1vD+W3K dRZU3MaIId/aVl6ZjR+7hvjiDZ7hZQFzZda+y4X4sGQrprWdHiSNQ/mkUU+iyMqjYf/9 Q2L/RL3Rr6QmGqvH+aIJfh8nOgJc+OmVC4jJ3lZM5jnR09X5HAeapNkgvWcOn8Bz5IIn eLYyWJn9uMzAKpvUzKp6edXGVTWNAz1cmL7i3GFt9cMr/oqWDqIb0SItqWcs8RICGJnf hzvC6yrUJ7uD2FRQHCBJD4E3wpnWH6A4ut2yI90GV63b0LFfNvcu3S1ERgyd3eXQun9g gr2w== X-Gm-Message-State: AOJu0Yy3c0oEb10miqTSvKns+beMewjyEjhU5gOwCIekZTHmi5Nqd2xE 2fhKcoPzS8ku4LnPNfLSr56lcq0LjnlLGBacuD1H X-Google-Smtp-Source: AGHT+IG5h3kH+UfKBkOyYBfIU9Wv2zMLC2CTX3vyfsGxeTUGweDLmd2HxEW9R2O+PC+8nKRKpodCCQ== X-Received: by 2002:a5d:6906:0:b0:336:7041:6653 with SMTP id t6-20020a5d6906000000b0033670416653mr1233401wru.70.1703070041377; Wed, 20 Dec 2023 03:00:41 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id r2-20020a056000014200b003366224319csm10053869wrx.53.2023.12.20.03.00.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 03:00:41 -0800 (PST) Message-ID: <37bd6a7c-7960-4d6a-ac97-870172ab65f5@suse.com> Date: Wed, 20 Dec 2023 12:00:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/9] Support Intel APX EGPR Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20231219121218.974012-1-lili.cui@intel.com> <39ccd434-387b-4560-b5f4-6a1b7fd825c9@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.12.2023 11:42, Cui, Lili wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Wednesday, December 20, 2023 4:57 PM >> >> On 20.12.2023 09:50, Cui, Lili wrote: >>>> On 19.12.2023 13:12, Cui, Lili wrote: >>>>> *** BLURB HERE *** >>>>> Future optimizations to be made. >>>>> 1. The current implementation of vexvvvvv needs to be optimized. >>>>> 2. The handling of double VEX/EVEX templates in check_register() >>>>> needs to >>>> be optimized. >>>> >>>> I hope this is just stale here, and the dependency on templates was >>>> now removed again from check_register(). >>> >>> In fact, I didn't remove it in V4, I didn't find a better place to deal with it. I >> don't know if you agree with this implementation below. >> >> I'm afraid I don't, both because it still isn't clear to me what's wrong with my >> alternative proposal, and also for the formal reason of ... >> > > For the alternative proposal, do you mean adding a new variable to avoid introducing new loops over all operands? How about this ? or do you want to add other variable and handle it in check_register? No, the alternative proposal continues to be to introduce a new enumerator to record in i.vec_encoding (vex_encoding_egpr is what iirc I had suggested before, despite the naming anomaly). What you outline below would, however, still be better than adding another loop (as you had it earlier), imo. > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -464,6 +464,9 @@ struct _i386_insn > /* Have NOTRACK prefix. */ > const char *notrack_prefix; > > + /* Has Egpr. */ > + bool has_egpr; > + > /* Error message. */ > enum i386_error error; > }; As a general remark, when you add new fields to a struct, please try to find a slot that ideally is using existing padding _and_ is next to related fields, or at least one of the two. Jan