From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20058.outbound.protection.outlook.com [40.107.2.58]) by sourceware.org (Postfix) with ESMTPS id 756FA3858D28 for ; Fri, 12 Aug 2022 15:13:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 756FA3858D28 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZDmrQHMwY8P9NqamwbRLG+2kXWgEW0ywuxc3SwSd8rDat52Sz77KEGnvyWZM82D2IvljtIAHcUovKigS7SMYY/pXMYIRSXzT54VlkuXG1VaXqh/HDlQ+4YQ8kpIqcYIChIRav2njVlPSXCeEqZ/TwMuLpuvBJWzgFWV9r282dgwtFZvIqUUwF+77u0nFMsUdQRnYmc4msHQvIyvohmlORuHoGcVOZMVudCrUzJTA/Psa58NNs2/H+5lxkJGyPosTRfQB7q193E3aqGdTFD+AaS3/3x6Eol8bZgX5j2jITdslM6lgff1+bVnp72ZgyowgTBz1kL18u/yBDqDpAd55+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j9NusO3ZZGytdK8Obv8FmneUTBZJn9TEIShO5kCKoDk=; b=bzGagzFyu/f2/pUs+dErHtFlSu1U64C9y69IlkCY0gK6xCUtNAkgAe8JQD7lc52NTd4zU4T5SM3skEx8V2MwR6HqskmaA8cORESj2qHFGKpZvBFDskHjpksUBonO11SsZtXhI8fTm0EjkxRd5aTkcSGUvKG0kGl+hJD3iJ4C+jX9gMMGv1FDhEC1IEtadlODkZZRGr3YZEf1sEIQ2i2BHG6y3h1qg9pFi1wQsAiaQg2ainsxy+5jDTsAzhGaeyB463CQPHJcXIIpcX3xC0OoHyJ5SyN7P4tNgkYmYKilqUwFkZXfHiB9kwY9NKYo6yzhrptHaaTs6J+hC3ZdDbzFpw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB9PR01CA0006.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::11) by HE1PR0802MB2538.eurprd08.prod.outlook.com (2603:10a6:3:e1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Fri, 12 Aug 2022 15:13:15 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d8:cafe::6f) by DB9PR01CA0006.outlook.office365.com (2603:10a6:10:1d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11 via Frontend Transport; Fri, 12 Aug 2022 15:13:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11 via Frontend Transport; Fri, 12 Aug 2022 15:13:15 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Fri, 12 Aug 2022 15:13:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b0178eeed3ffda6c X-CR-MTA-TID: 64aa7808 Received: from c64c58844476.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F231A5EE-508C-4105-946A-596AA84B56F4.1; Fri, 12 Aug 2022 15:13:08 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c64c58844476.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 12 Aug 2022 15:13:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HEWy7n2c6pcxEPi/7UxTTU9iCZB0b2CDSi8LSJkqW5v394RotrCnKcE1Pp4jIy3pTGDNUnVEQT2xao0xG7J4FJQjRive8fLd0vMtQHYm3xcDPRkMCW3t/90TBCGJJMnGrnJXRn1b8L48kC+MXtRlfztPNsbcMvAFG5A/WZJAJZIUxPT64jG2gBwzjKHfGVJsGSOTvi/+GRux/25IMo57xmK16XsCG6X2KKR4ZIOssedjxW8NSHljcPY/Htfh8VOgq8J8wdcIMaAbo7K8BdGdhvHCB0qH8At+wXdImowTQQeYc1eG4vY5KHuUmm4I37BW+96dC8AxAhxQpUubwX1BcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j9NusO3ZZGytdK8Obv8FmneUTBZJn9TEIShO5kCKoDk=; b=NRY9TDc7cCYfR3C09DDmWJn7cBNIJDQi9nL7zezgBH90+nGgZFci8jeC41N5G1eVISe/33hZ9DG3Xso0OnyzPi94gob4dJOeJQh2Oloz1z27Ky/iTuRS+JvUmcHru/bWLFPNjP3WpoW1JP3uqDTLcIZ79g8dVmMtHh9q0sEVYVc/fijYyF+Cw/yYmz3lJD+4sHCaf2JUBnIY4TEzyjyUdjFu8QgF1Ut/cLorxMpAHukIigOyyoi8GPhkKB4kK6SzmLzsvagMGKmQ2wPaaE8HQff6KtupbBWF44+CajCV99zCXjSX6iWlH08x9bhxfT8QMZPgjQb+vCv5ICtZnga6KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by VI1PR0801MB1709.eurprd08.prod.outlook.com (2603:10a6:800:59::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.25; Fri, 12 Aug 2022 15:13:05 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8%4]) with mapi id 15.20.5504.019; Fri, 12 Aug 2022 15:13:05 +0000 Message-ID: <387a2065-7439-aee3-28d5-b0d9665b2a3c@arm.com> Date: Fri, 12 Aug 2022 16:13:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] bfd: handle codepage when opening files on MinGW Content-Language: en-US To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= Cc: Nick Clifton , binutils@sourceware.org, Torbjorn SVENSSON References: <2fe3fe60-4039-b9e8-4212-4d9f62e270cc@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0059.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::23) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 2b33664e-34e7-4302-72b0-08da7c752e0a X-MS-TrafficTypeDiagnostic: VI1PR0801MB1709:EE_|DBAEUR03FT049:EE_|HE1PR0802MB2538:EE_ X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jjl5JPKUAokLxq1rSpFPJW42cNziVYiqRKJ0CsfTz1GTDfwKV6llhNhfb8pK5ymPxGl73ltQo44JbWZITyn3K4tGRARlYV3H47HPr53wgKo3ySZIluMk0b04UxVGnXiTF/pVBt102QCJCDuUcn3uS5mr0L5Uw7gTpM9OlLFmwydXwEIVgn2bM6vyZfQoZns44IunhQ/d8uwd7dEcvmMYyiQUvsqlRj+ftOKhU732600kgsrKTtqs5hXoQQmm7BdGqzzjvHnimsJr6XIkCVxq23GwW0bgkIf0w5N0XM/ojZeUv6KTOyxtItPjd+KDCRoUfrYknLQHksDPt9SP0exLBcivwqEqyA3AXow+7BBdatUQx1M2XzAjJ8ly7E2eX3yUZ8uuJGQrOMkA40JlXitnDhS2jOWp0Edzq4PzVZPcspRbIZq3Nw40sF2vEopE+C596jmIklJogIrOM8Vxk8FvucGfxrdNodxKrqwWJzHAlht5W+gL7Kc452TbB7r5WbhYPgP83IOxEqI28pxg7fgwSqrfehCdRhHmKBlluaDblLFnY9bURwf7BZmX845YLMWvvWwwqQaEVqv+3WFdtC6CS39Bs6C4nrSNjpmhhCEP9ilxp5PSaTbPe7YHNMqMfT13PrpiuKZr1lWE4u+5K//brWH8RI3bWKIA8jx9J8fU9x6cUcAhVJw25IQwpvbWBVCMyqPwBXu/agOiljm50vfosg3/CO5DmKSfpwZDSce/2oMijNG0zMl8W4QuNaXEwYUM21A8A25FIEpeNcF7DooiqtifwjfFxmt/ckKEm4+BMNd5QOsbhpR3Jq4TI+cxa44u3uWPDCwwovhI3zKmLoo/+DDtxERwbrbzcuVWrWs3SJRaAgaz6TVVM7d69nwc/lEw X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(396003)(39860400002)(136003)(346002)(366004)(5660300002)(2616005)(31686004)(66476007)(8676002)(54906003)(4326008)(6916009)(36756003)(8936002)(316002)(66556008)(66946007)(2906002)(44832011)(53546011)(966005)(478600001)(6506007)(6512007)(26005)(41300700001)(6666004)(38100700002)(66574015)(86362001)(31696002)(186003)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1709 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ea480c4e-e026-4b3a-8420-08da7c7527ef X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2ldcFGoCW/X2OgvHSO+VpHSNyfBU/fm9MyXPvVL627yk5QYmRTPGHB0mRhl+v6wMZ4juq5fxd66+WA3gSzzRuTYR5WQQTPyrON/QLgLLYymWAuegs6O3hM4j+YkUaeTo0ciJrlVcqP7sgDsBSKqF4Eg8uYnz2JElU47kaNN9LuIn2c2mkoy5H/mkK3sneZ1x1QADBpE84kxStdKRCfMunAP0oCWJHGmtyMdNmot2IzBWfhpMeFlVUBkoJAZqKAapMMKYkCr6a0zu8SK44hv/l7Vc//H8i6TJrR94WhlMo8Vjw9RogoWEjdi2TyI0jeeNMzMDsNw/7Mb//7rVEPWYn3FPGzX/ZW7bkjG9cJh+/aR7yoVPWvzlskOCO+9EzxwSWlZ6apD7jUFf2MJe7OqBlTIVrpfLGfm1DtQQUC72A/J340btps3xfCjkpw3j22hn78EmKiU2sVzD+WBnBBC0R/6VmguULFPbykaoCGb1KM+qq8YIklowbBkZlk6SqKTUNgLynvYncOLZXIh39o/vWcOl4KGWNmc2UNmAZSAQhbkS8ffcBtTILvww8qOmwGspvMONz1579meNVGr6tl5AA5mFIRMsmXpZ4tFXS+6JnuLEpxRAOI2GGxdiuJSNSEDhkWneN5GooiOxM9deAMsKgySOBXKoIGPr1EclQnfUDF//rhWzl1asNyWMMzbPB/OaRQuMavysXMzDM6FtlnMcPRRirSUEw9vUKMnVPJanW2tDTu6pIwDhJ/BAh0DYJJDsJioSuj3B2cOf2dScofSgkdq6tUGX03wWbHrZ6I4gCwU= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(136003)(346002)(39860400002)(40470700004)(46966006)(36840700001)(8676002)(316002)(70206006)(5660300002)(70586007)(54906003)(4326008)(40480700001)(82310400005)(40460700003)(8936002)(2906002)(44832011)(82740400003)(36860700001)(86362001)(81166007)(36756003)(6512007)(31696002)(6666004)(478600001)(41300700001)(26005)(53546011)(356005)(6862004)(966005)(6486002)(2616005)(47076005)(6506007)(66574015)(186003)(336012)(31686004)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 15:13:15.1801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b33664e-34e7-4302-72b0-08da7c752e0a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2538 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2022 15:13:21 -0000 On 8/12/22 16:11, Clément Chigot wrote: > Hi Luis, > >> It's been reported to me that this is causing some issues building binutils with mingw. >> >> In fact, trying to build master binutils-gdb with Ubuntu 22.04's mingw-w64 8.0 or Ubuntu 20.04's mingw-w64 7.0.0 runs >> into the following: >> >> bfd/bfdio.c: In function ‘_bfd_real_fopen’: >> bfd/bfdio.c:125:28: error: implicit declaration of function ‘___lc_codepage_func’ [-Werror=implicit-function-declaration] >> 125 | const unsigned int cp = ___lc_codepage_func(); > > Looking at the commit exposing this ___lc_codepage_func, it seems to have > been integrated only after 8.0.1 (cf > https://github.com/mirror/mingw-w64/commit/64cb5e8582d9004cfa4d90b189c80c6e1a35d7af) > > I don't know if there is any define providing the version of MinGW (I > didn't find it). > Otherwise, I guess it'll have to be checked by the configure. > > I won't have time to create a patch for that before next week (probably on > wednesday/thursday). Meanwhile, you should be able to recompile binutils > without this patch. As long as you don't have non-ASCII characters in your > filename, you should be fine. > > But thanks for bringing that up ! > > Clément No worries. I just thought I'd mention it in case more people are seeing this. We can address this later.