From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id ED46F3858D28 for ; Thu, 10 Feb 2022 12:45:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED46F3858D28 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-34-vwljnFqjMcie6PS2q3hG2A-1; Thu, 10 Feb 2022 13:45:00 +0100 X-MC-Unique: vwljnFqjMcie6PS2q3hG2A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MThxq/H8lBst7WBnV2CFlMOTz5e4+DbAR07PDvjNdvoDzRav1rucGcam4gWc3V90AgHiTXolZ7Z08wz/kabFoViLDodaBr37/tMUnfkan+X7n3IkG9qxCz84NiIXfZSLuzVga1xW3Q48knT26DsxwN4Z4gST4MOp+jNKQcXCJBlIonLfE4QCyUJssiZ5sXxCpLEHuwYHVSAKl/daYLZYTNV+Jta+xMKr8m6gwYF3PA6PUyC4r4e5hYRY9AzngZ1fmn8qTEgNZhJbjC6qBJRmG4fPaxDGp+23gqWM9i/yBK6wbhpjruQcXMcAHyV6VQVLC7hBmm2chG0YW4qx34BUyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y60OquY9MRpXsWz1BAIOkSkYqSp+Pa2J9cYPopEhVWo=; b=QsOz6gLw8J23GKU2cW4KO0Fq4+ZHuO14iylWciOqVQluVhmNKn7nyeHPfH2WJrWnK/bgirlkzjjY2T8sUdeMOaTD9WOjRbltu5vviE0WNuZammZeXtp+jzL9yDHnnYemaVJViox+oKJhx+QPIZ0uEW1q0nEXHNyzmRVg2J/6ulTLkAK3i12/HJyiGf99Z7T5mS9yiXBCsHl3H7TFyKbDf3f/oFvKOlKR6wg2I8yZJM0an7jkj4xuurZndjiIb+jU6t2UFibz5/zanAv2mTOGoELfVMJ00Ev/amlhajlxckqjIcn1KfWZjsC+DUu6OHLK6k0rzc/XbOjrTPsNp8et9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) by AM6PR04MB5368.eurprd04.prod.outlook.com (2603:10a6:20b:9c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Thu, 10 Feb 2022 12:44:59 +0000 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::54e:e7d:545a:da84]) by AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::54e:e7d:545a:da84%3]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022 12:44:59 +0000 Message-ID: <38e538f6-200c-e6cc-bb64-400f4234f00b@suse.com> Date: Thu, 10 Feb 2022 13:44:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v3] elf: Set p_align to the minimum page size if possible Content-Language: en-US From: Jan Beulich To: "H.J. Lu" Cc: binutils@sourceware.org, Nick Clifton References: <20211229193949.146079-1-hjl.tools@gmail.com> <31e68092-781a-7787-cf6f-2668e47e5e61@suse.com> In-Reply-To: <31e68092-781a-7787-cf6f-2668e47e5e61@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0288.eurprd06.prod.outlook.com (2603:10a6:20b:45a::19) To AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10f64aae-3290-43dd-da10-08d9ec932644 X-MS-TrafficTypeDiagnostic: AM6PR04MB5368:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yW20waip3Q30HOVDxMsb+tiH8EYFXj/vNV6i/5HbmA//AlpAGrf8t87zdPJU1UR4fK74MFGdP3/LOzSH17e6GF6E1Iae1cuAbkCnTN/J/3ZzKcS2qnjiltW1hiB67z1oKQfT+EsiPQJO7+7GuYWdp+H7anipgqJNVVCWwuN/Zk72OqD9cehca6/TgMVLUtYaEDfTMhSh2QqymZvWdDXz37qFX6qxvVh2nSF9yQbwg0vrgAeqlPCqIjh+osVieUptUxu4b+ukubB2r9vcwe9tLLT+hd76BbFWPE4wcBsOUvc4m37kH1kNv0rVMUqabzx9VHCnDF+cmyTP+zI8FeMo2ukbeZw05uqKMlGYR5vKu4ZBCrxNO/u6IvWdQdAwpB9WTo9a0nqpGPlezCFRqRJxQ3wgDvRFcE92nu7DcWLz0Szs0MJfP67eKEtdXBLQIBySQ5EOQwZkXrFL3T8/nVVEdKNIVsxTUB1MhJ0SnLJunXJNYFHOc+lJXpsHfJe2Z+sBljmTNzs8LzpJ0OgCV4jIpC8M4P+bnzl247hA7uhU2JGyOcQDKJ7vAUUs3qWc3t1DjWqhY+R7GyeemIwHAaPGIpeJF3emJJpB3Lw67bpiEYMKTNurattLINuRhUtQIun6/OXFLu4gpcDMyebnGs60GSCm90N3vaxru9jkLMJUGjDxi4dJ+A0cMlRWMUl3Gy7PKWYPPwAXV/ja7BCc7w95WgZldYuDUB01qShAHlcTKyE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB5587.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(8936002)(31696002)(6486002)(186003)(26005)(31686004)(316002)(6916009)(36756003)(4326008)(8676002)(66556008)(86362001)(66946007)(66476007)(508600001)(2616005)(2906002)(5660300002)(53546011)(6506007)(6512007)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1hHdTV2S2pIWlJrN2F3dlZBcm10ZmVoSDRDc0hET3YrakZNM1NHY3czcjM3?= =?utf-8?B?UVFGTmJWL2MzV1ZzQVhKS2VxSnY3U1pvNVhBdGZYTUdncFV2SzN1aEdrRkxj?= =?utf-8?B?Qkx6anMydTdaQWpqNzdCWHEyVG9XMDZ1dXQxb3BjcnV3NnpBU05FM044b3JV?= =?utf-8?B?UEIvcGFlUGxnbGxHOWxDWk1TUWU0N2NBYVE5T3hFRHAyVUREbTF1amxGY3Vy?= =?utf-8?B?Vmx3LzNHYzNNOEpvcThQRUp4UW8yZlJvRFl4b1RDVHo3MlcvNk9QbEdyV2VH?= =?utf-8?B?OElCUU8zYUZzTVRRWHAvSlNaL01IbnRsM053TU5PdXNuM0Z3ck4vNWV0c21n?= =?utf-8?B?N1ZDMGNwSk1uOXpxT3BWRUtPNnRXLzlpdytUcG1VVnc4MEdNS1lmN0VNRjBr?= =?utf-8?B?NDZVYlNvM0NTZnVGb2cvcURKSzRaV2hFcEFsVm43dnFZSlJMR0dVVWpYK0lU?= =?utf-8?B?Z0I5MFFieUdTTVNBRE10dmFaMGRDK3JyRlhSbWRqQ1RmMmxGWVplL1RvVE1B?= =?utf-8?B?eVlmL3lhUk9XbnpSNGlzQm0yRVNlR0ZLL0ZjYXBIOXQ1WjdFYm5qRFBoMkRH?= =?utf-8?B?cmpXVzVvd2UxUGhmY0cvVEhtYjQyd0ppc0hlYUVzYXAyMHAxWFV4MGJoM05J?= =?utf-8?B?LzFiWVh6NTdMeVZaM3dKUTdpbEFoci9YOHNaL1R4MkRsZ3NrUDd2MXVqVEVK?= =?utf-8?B?NmpxQXZvN3k4d0RUSGY5VDRmUGdLQXRrRktFblA3T2s2SS8zOHlLU2E0VUt6?= =?utf-8?B?VWVMd2YvNjl4WlRGOElQMytWZ21JTkJYUlc1b0dodlpweHBCRFdQOXkwLzhZ?= =?utf-8?B?N3ZMOWRoNzRmcTd0L1YyOHlBYjRITUE3WEloZ2xRZFRGV1VsaFAxcUU0U3VH?= =?utf-8?B?Q2tLR1piWDdPeFpQS0RzNDJxN0NPYnZGZ0dTakRjNUFvTytqYVU0TEpnZW5O?= =?utf-8?B?LzhTUnVGT1JhRXMzc05IQzVxditIWmYzUVRVTDFCL2xKNGUyOGRPUW9XWk9F?= =?utf-8?B?ZkZuekNFQ2xOVlpMRU1BNWxnUUYrTkc4NFhFRmRzRTJqRU9UZ1hnV2JrakFH?= =?utf-8?B?TS9rd09qNnhtYTd1bEhlQkwvanppVk9MbUFxYUZXaitEZ3FBTStZWjlCR1Vy?= =?utf-8?B?b3I1MC9hc2xTdGZBU2ppWXUxa01peXJNcTh1dXhDNmNOcHZSVzR2MUR4OXEy?= =?utf-8?B?NzBaV0krenZLSkxnQXZtcFRnSHliME4wWFlBTytMNkJVT3YzL0VOZEpIV1Rx?= =?utf-8?B?OVJZMjRWV0Zsbm5TTW9oVHExVU9vdlR5UWZHdzhaeVhKcGQ1RCtpekJoTzQ4?= =?utf-8?B?TllwVk1MalJqaDZkcE9keGdvSDl1NUIyZ25YVzczNUZRUk9RS2RpbHFIYUlQ?= =?utf-8?B?Z293ZjBPUDZacGhJVnhYRDIxT3BNOUwzQjNvdVVyOXQwVkRwWURlZG1WZWdP?= =?utf-8?B?QXI5ZXIxMktza2UvbXZ1MGRZSHczRlo3b3grSlJNcFRaeml0aDYxd3dRQXRM?= =?utf-8?B?THNOb1psWkVCOG1WbFdEU05DcWhGZ0Z0U25WMUJCMVVtbGZDKzBGK0F2OTY2?= =?utf-8?B?SEZqQzJiengxY2F5dGEzblV5cUhZQXQ0ckJ2VHZtdk9WUURrV0lNV1ZoZTBS?= =?utf-8?B?b3VBS2tMc044Zm1sMWR0Qjl2RnN3bTh6U3ZOQ2kwYmFoTHpaYTdGcFp5bUVj?= =?utf-8?B?Y3ZjQ2hiQnQxVmEwcklzOXFPcmFNZDFDR1U0N25mZ3pPbGR4cW5BTGNvSURR?= =?utf-8?B?d0ZtdXhDRUlYT2MzMGwvNjFYT3l2Z05GNE85S216cUtiSzFsUEZzOUNCWFNK?= =?utf-8?B?UGZtK3d5Z3RSalVZcnRzY2VqNUt0SnZSWHp1TE01WXJHdmFXSWpzMSt1RTVm?= =?utf-8?B?bE1xSzlmUUpVaDFraWtwd05BcXFKWkZEMStmUjdWV2xwNVBHT05jY29teXIz?= =?utf-8?B?T2Z1enA0cUVWNHZFYVRsOUlsNktyQ01MVVlzdWpHTjl5V1VSUXdQdEFWQjdr?= =?utf-8?B?emNGV3llVUxDL29Md0NCVmk0cUxKeGJDa2FzdGVUTnBoR21ETDZsbmJCYnRX?= =?utf-8?B?Wi8vVGZnUzRWOUw1Z1Q1SnBxTVFoaFRiVmdTS3pWOXMrbERXNUNOV2JTTkts?= =?utf-8?B?QUF5RkMwbVZvY1l4MTN6Q1RMK3dlaEx5azBvUWtVY2V1ZTdVWHpGQ2lqdUda?= =?utf-8?Q?3OlPH/D2w+T8l/k0/rvC+J0=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10f64aae-3290-43dd-da10-08d9ec932644 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 12:44:59.8373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BUBDH2vhtBqPT6qHGpGAvpZwgzdQgvG8BsK+gOx9GPrAY2T3uuum35U5+etJe4EELLZg5f5wmW8tEiA0kTHRTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5368 X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 12:45:04 -0000 On 14.01.2022 09:12, Jan Beulich wrote: > On 29.12.2021 20:39, H.J. Lu via Binutils wrote: >> --- /dev/null >> +++ b/ld/testsuite/ld-elf/p_align-1.c >> @@ -0,0 +1,25 @@ >> +#include >> +#include >> +#include >> + >> +#ifndef ALIGN >> +# define ALIGN 0x800000 >> +#endif >> + >> +int >> +__attribute__ ((weak)) >> +is_aligned (void *p, int align) >> +{ >> + return (((uintptr_t) p) & (align - 1)) == 0; >> +} >> + >> +int foo __attribute__ ((aligned (ALIGN))) = 1; > > Alongside newer distros I also continue to build and test binutils on an > oldish one. gcc 4.3 looks to silently ignore[1] alignment values larger > than 1Mb on at least 32-bit x86. Hence all 4 derived tests fail there. I > think you want to verify that foo's alignment is actually 8Mb in the > object file, or use an assembler source instead of a C one (albeit I can > see that this would undermine your PIE / non-PIE test variants). I have to admit that I find it disappointing that this and the later reported failure on glibc 2.26 (or, as you were suggesting, an unpatched kernel) have not been taken care of in time for 2.38. I understand that I did not come back with results of testing your proposed workaround, but as said in an earlier reply I don't view adding a gcc version dependency as a viable workaround, let alone a fix. Hence I didn't see any basis for putting time into testing that change. Jan