From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60055.outbound.protection.outlook.com [40.107.6.55]) by sourceware.org (Postfix) with ESMTPS id 6F222383D832 for ; Wed, 25 May 2022 10:42:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F222383D832 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nEBueCr9eAGks4OS00xGcowGYGapeKfpIgbFpytMD4PYCR0dHLBMyBZwaJJAIiZekLV5q8LA20F5MqnocA4DK9IgHuVvhdmsn545x0O0T0tJiRyCQ6lVmRcbea09Y1Snl4+MWrt2EWPvj7BBzLOn+ZJwHTPi7INGzZPrWggi5f6SnaRCzAIr3/Pdqnev3xdX7LAyLUR6YsKNgy0m90MXMnpI5evwRYawcnIgeSEBJUH6If8mv4n24lW7/Luco9n/jk4w3xOQEd9d3he4um5XenstcPDUTsHUb1tNgF9tYGYOQyWq8uDhCGR8vZylVlb67izTzi/rE7As97KsEHDOpA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0vBWwdHfzp+mZovEBDwNgLmNFZWix8ndKMUYvI+fAQ=; b=d1+QNIYhCnaouSNoAQdUSVMUz5O4+jqXg+926sbpmShrmPPoUI3azbvu1JUfAJcLCiSqK2fAIsa8mztOqn59Qkx2bjXCOGOl9X1zK9x525Lbq0Rzz6w979RWUBuLb8Mllg2juQcPXzM+9R404x6g5NFOTIt/rDXNgVD6czDq8TiANiD1l+GK2WxQBEauo9juFAIi4JubJ9xts3WuC+cwfqpq9nLrw5owhpLZdyT/GK/fIoHsf7ZUtS3vloxlN+Hc7EUuF079OpBs84++Ti86BRXnzLqP7lEcTGHer6Ea8hX6H1z3ecJPRyUt/3s94wnZf6Yd0SAIM6fJx3dIFoDwHw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DU2PR04CA0288.eurprd04.prod.outlook.com (2603:10a6:10:28c::23) by AM0PR08MB4193.eurprd08.prod.outlook.com (2603:10a6:208:125::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Wed, 25 May 2022 10:42:40 +0000 Received: from DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::f6) by DU2PR04CA0288.outlook.office365.com (2603:10a6:10:28c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23 via Frontend Transport; Wed, 25 May 2022 10:42:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT007.mail.protection.outlook.com (100.127.142.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Wed, 25 May 2022 10:42:40 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Wed, 25 May 2022 10:42:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 28cedac7b8cace80 X-CR-MTA-TID: 64aa7808 Received: from a7c9f7b559c7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5579A13C-DD8F-4078-A9C6-F9066FFE051F.1; Wed, 25 May 2022 10:42:29 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7c9f7b559c7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 25 May 2022 10:42:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eScYgP0xi1FnCpmvpeiWxgfO/zHeLCJm757rdMzvXY9ldiALmVa4LbswJlfHs3pPn0RB/HjzgE/zeNwqg5rK9EWHCdl73LziYqfv3adL9Spd4l28uL+XqhRxCDqs9i2GRNwSj4xfay9EwXceFGsKWlr58ZTojLZ0nHG2DBMBa9oxAfhPexh5ykg/6HVCWcfzueAo/fO2qncZ7t2NhENClRQ8vpm2vSd/kXsC6fEgf2pLHh8xBrpjPqNiploKHf+pfagd5kAbIhtlMA16goS3uxtidNrv9y0YL5txRMDkzLFjOvawNlFIgTnJW7bUMagXs7nDvg2Z9md+i07sHGIscA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0vBWwdHfzp+mZovEBDwNgLmNFZWix8ndKMUYvI+fAQ=; b=TZAsvZReRF8pkXsb6h3S4O0O5yY2UAAoDeUQK6SCUJ5L2xjcVls3lG1DHQDHi6WcspRoVRvAV/j5TF5kLibn8K2tvRa8fULvHgwLYKd8Q2isbLFD5/7dwcJWM3f+Gzn0oxUr0EUSY3k9gWVobB34ktZ3H2uIZHibM80NbAjlTCtBrh8h5QdgjbsNTTn7fJlV2yhMVljoUOJVxyGgjMRv509sZ8dbXSQ+lGD4MfqKOumxKt3thdMlPvC6RXITwwpj7Qwj4sK0ClxVk9aHgaZ6Vq74UFoSiSS6RJzu2/+ODYBNec/BtK8G27ocsQKFIW6NKWjMtd4ID/bWEi9xISJeIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by VE1PR08MB5198.eurprd08.prod.outlook.com (2603:10a6:803:10d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Wed, 25 May 2022 10:42:27 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5273.023; Wed, 25 May 2022 10:42:26 +0000 Message-ID: <390db654-9a1c-8448-f1be-e466d9b39331@arm.com> Date: Wed, 25 May 2022 11:42:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] [Arm/gas] Fix broken build Content-Language: en-US To: Richard Earnshaw , binutils@sourceware.org References: <20220525102852.106812-1-luis.machado@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0127.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::19) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9caa1a65-ad95-4d25-eb24-08da3e3b4afb X-MS-TrafficTypeDiagnostic: VE1PR08MB5198:EE_|DBAEUR03FT007:EE_|AM0PR08MB4193:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: khr26S+s2gsDhvjxOs+EMIop4lkSBQHIl/mrU+pcyz4cXgs5DfX/BJa/+lKSHTWhHJvF4hdf5oN42FvW29xf6YulInHiJoxVEZosrM2vMNgFCDejHNf0ivpY5FEx4b1Mz6Pdq8YPn6iTKSNxK8NjvKCF6Lb/dJt11WB8Z2P/t5B6DmtcH6WGkfEsD1yEEv03KwTK+ngJCJtu/2Otc4WHVzQFp+mPEBdhIdwedoFINiDq3Lo3MMLd178PM/gtQYR7DFMLF5roUDuW8SB/AhhZ5jlxADXCmWA+1jNaPd8JYfVXaj0Jt+HagBqiRmB++L8Hrpxa0xOYF3alrsVpdB61bJtn/rOgZPqONquifCeK49HYk3NI+RqNw4M9hzjBofeJ1gpKwlPYDYUD1KmnH3j5fSGJ9gIW02xwHOBqj+bGn6NVZCSYfrtwEktxETjEGVAyR47PhZx3PtjC/0bkH3FhReFSuN+x6ngTq11njtpeXR/Wuy8QAEv7dwRQ+JtCVTdEJbdT1pc0Gxqb+kN9yRXHNtRJ1IYZxLNCmbUrOM+Lxvb/IclUplmD23N9vBlKmtSQIAT3cVTcGL/JzXdS1orZbcOohCer+nOWXz681tzTjN3zLOQkkyXhw2O7JHGoydy0EEuGUdvJYomhtzAKYUGj3sFq4i+HLhnA+d+JEt9oHJVLahDgQeOhMjs8KLQQ892U0UtHZQzreRvGFdi43Cz+h1axSNy71uXZeXQ7wsl5rag= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(38100700002)(6486002)(508600001)(26005)(316002)(2616005)(8936002)(5660300002)(2906002)(83380400001)(186003)(44832011)(66556008)(86362001)(31696002)(66476007)(66946007)(8676002)(6512007)(36756003)(31686004)(53546011)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5198 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 53b23e59-4736-4ca9-f958-08da3e3b425e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lg3oZ7paT+V4DKd/aLCGP25FS5fEPaduNnQ6Fsjn0d7XHXccxLCsgcxR8Ra5Aaz0NP+uIauavGw4e+LAZ7ZABb5By/1Wi/1ET/52/w2706kj2s9j9jP9R9zco3QnzScAbjYyVr3nzGCWgTnc+hXUlkxGXSYT9fdJU0pslnXFByEHkOixeTBHx8gN1NwT0bPNoaR/xHBt1NWhcWYF2hrcz4iQ5fz0h9Z0z94/qGPXk62mlR4fT0dv0s887oEwKEpOPDkBvEiwafxdHp6WXIukaQ+mtiYm/AKMmLq6Wu9APuea4Rwhcn0IMvtKDvZqr/Q26xh4+OU8abx2avyezSR7MChJDks8Hbcjky3k5LAP+NqYphKAbTNfN+5iIsqgII7zhE/J8aDM6zzhz5R0x3AaosthCm+eb4KPV/hMr7Vk0IOuDSbTnkKU7001KjCRTZ5PttzZQXNb6hRZk+Fcq2yMfTqtbRRwt0XnUNaIywVEk6GDDB314+J68Drv3HVZ+wkzZ5eGInsmRhW6APaHw8Sb6Af09AhoCSlTt3L8oeiNVCPDBDfu59TERMGjm1mjjMejTzyqeUuPxZLCvNNdK5oq9PZs0Df4sv5Fa/k+8xEd5G1VjwnRpc97/+pXAnyRxJ+Lp59pZ9K4WY6oIaDQotpTglIXdwyRT/ELdOcU8k9MNh7MHZsyPPWkrBQ+RPlwwxbweVwTTuMseEgJhfAaR9zQXw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(44832011)(8936002)(8676002)(31696002)(26005)(316002)(70206006)(83380400001)(86362001)(36860700001)(186003)(508600001)(6486002)(70586007)(2906002)(6512007)(53546011)(2616005)(40460700003)(36756003)(47076005)(31686004)(336012)(81166007)(82310400005)(5660300002)(6506007)(356005)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 10:42:40.8206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9caa1a65-ad95-4d25-eb24-08da3e3b4afb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4193 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 10:42:45 -0000 On 5/25/22 11:39, Richard Earnshaw wrote: > > > On 25/05/2022 11:28, Luis Machado via Binutils wrote: >> Currently the build fails with: >> >> binutils-gdb/gas/config/tc-arm.c: In function ‘s_arm_unwind_save_mixed’: >> binutils-gdb/gas/config/tc-arm.c:4730:17: error: comparison of integer expressions of different signedness: ‘unsigned int’ and >>   ‘long int’ [-Werror=sign-compare] >> --- >>   gas/config/tc-arm.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c >> index 538d83f5462..9682db974ed 100644 >> --- a/gas/config/tc-arm.c >> +++ b/gas/config/tc-arm.c >> @@ -4727,7 +4727,7 @@ s_arm_unwind_save_mixed (long range, long mask_range) >>     unsigned lim_hi = 0; >>     /* Iterate over pseudoregister to establish subrange bounds.  */ >> -  for (; lim_hi <= roof; lim_hi++) >> +  for (; lim_hi <= (unsigned) roof; lim_hi++) >>       { >>         if (mask_range & (1 << lim_hi)) >>       { > > Why try to massage roof into a different type - it's defined in this function and there's no obvious reason (to me) why it has to be of type long. > > So IMO, both lim_hi and roof should have the same type, then a cast would not be needed. I considered that, but assumed it was done that way for a reason. It might be an oversight then, as all the other types are signed.