From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2052.outbound.protection.outlook.com [40.107.14.52]) by sourceware.org (Postfix) with ESMTPS id BBFB93894C18 for ; Mon, 5 Dec 2022 12:22:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BBFB93894C18 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YRIuW+eoSLAH4ILc7+kqE3lDbHZAxXA85yyOm9CkrAGYyvCggSv4jz000rw577rBYDrNMz1VMaK0xLBALlQTCw4ngiQ98QlpZ9QzH29XI+NL/GOYlvJSnNdhbzepse+tQK3ulD4aGSzfJ+0DHvTqhvu/j0mBYHWSe0QPXZgs3HafNIQ+mg4PB5opbQdNIHULW3biEUQx6d2KMwi5fQbU2wyNxdpeOGl5WhLagQEzbaTy7dcyZxvwNlQ/m0RSwBOxgWSyWXnH/bQGVJsOxlzxO8fAitEGJn9G9TFc3hzupfnl80mhFOtZc3vf7toGV4ha7G4gVXVGVxuJcVi5DWTF8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fxo+1dg5B7GPMVb4FkECgydqyjZOs9p3HgaLv8N+cmw=; b=lDI2FB5YpMYlo5vBJg5n8YD+cfWL6WXuywcTbCNCNacl/v3jvDY7ptZFFiUyXdBkyeo2pBL/9MnbVe1mO3G7UYpf/rSQKbkLqmShUiBSVvrfG7KNcbrT5goPXmF6bviXSYUzEGdb0zXUPS9UuIsd7q2L4f5CGo8WTzPk6uzP33gZGCiS5MEp7DAe4f7Z0WAV+JfSrWQ1z2r14h9riVXS1b6F2ecwzZxtis46Dm+kjbwYCHLJaa6dmlp5uPCYl1B+N0Tf6G0JgqPE/lj9IheQwFF83SylwbPGaeGYWG30vnNf9328nbIeGz06Bnhmy/147SxRdGDy73qG0Q24IQpcLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fxo+1dg5B7GPMVb4FkECgydqyjZOs9p3HgaLv8N+cmw=; b=zd0f9ns3QZhDsm5FuSm0DUNRlmGS5BPOeV8oX3rp0keBlHdgak7BGwKHR7sBJXb1Y3wtxW7mz5ksd0bFxoUG7aL01ekR5VStHbtuizLZKI/n9ZbMgJFsZATG769abSWDBvLSyjzdDmQNik+M1jC1ml2l9ixDs37T2Uwv0ws7ifyn0ZJXL/nFGaxT3Beq7vxujnTKOTUt89/QUsTruc3dkAsPmAY7S8gSjBBTZyO/8PvVHvsJNNNXb1Og6TF2Mw+ahwvqMD+HQw9KBQ8yd7OmuDn3Z62N+VxMyAFcwN6wfK9ZldN5NAPNtD8/Tl6BRGFB4zkcTCcaAujk7YSX5FtxxQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9138.eurprd04.prod.outlook.com (2603:10a6:102:22d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.10; Mon, 5 Dec 2022 12:22:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5880.014; Mon, 5 Dec 2022 12:22:41 +0000 Message-ID: <390e89b4-f7ca-8147-60df-fa1094ded1eb@suse.com> Date: Mon, 5 Dec 2022 13:22:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] testsuite: support mold linker Content-Language: en-US To: =?UTF-8?Q?Martin_Li=c5=a1ka?= References: <76253e84-a7c3-5d09-c6a7-422573ca2d37@suse.cz> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <76253e84-a7c3-5d09-c6a7-422573ca2d37@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0168.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9138:EE_ X-MS-Office365-Filtering-Correlation-Id: 51e99d88-9bb2-47a3-1c33-08dad6bb6713 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fcts10a+yfoaxil6M8BJ1JfUNvgKfXV/j5es6PQTGXXLlY5BCC5+3afudm2T16Cu1q/emMa/20/UpS8YhBLmor70EKVbY/MPBdLl1DO47alBpYdAxnc+t/fZxweQQr8I6+XgTcySdRCTyW4/1oaM/ZZvl4Rz6/XicaMnFiy6qVJoSnnpOJM4qtYEeGNDAX+lqehOJ4milQFR6mDSvXRFwrOYCfu8aHMeBxpRSbeiV8I++d0NU1pJKBWf5QqfZYtoRoUI0RlQBwYHaZD3oZZdv2v9Pj48spz8P+dgH9bVELD0dcmq8vGJ8XUH9S1gQzg54CmOOdXIR3sSGqdbSRZmsmttWLr5LNoUGu1X4JLeHnS0DxPFqAZ67y/8pl9PZFoSkGBb9XzaB//io/gv53xk55dojsruVDeoUJraqgQKsBJ4um2PKuTjSnpLuYx4jCBanAgm80sYp1EaMn9AwLeA9E4w7Ej6YI8zkuOOw1vObH1Aoz929N1DUZpOlrwgI69EbWjZYSRpHjJ3zy8zJLfdDhyCXjaJxztbU4g7+Q/xJOPkU7q/VkCIUs6iUbo2woGip8OIBTLq53rmSJxC1WU2zbwXX57g9KIeE55+0E8sTR0zGuDpCf/FHBmsaiAUqa+0ARdwUKw2wg3bUWy/AZku2dCzjigxnTTA3XqryxW+tGIzlUkxiYjjJwr5FIH6bUDlB0/BMBKMpd87ayxlPLvYBPe3BEYvZp4tQrQm3ACFbTo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(346002)(39860400002)(396003)(451199015)(86362001)(36756003)(38100700002)(31696002)(316002)(6916009)(31686004)(6666004)(478600001)(6506007)(26005)(6512007)(6486002)(8676002)(53546011)(2906002)(66556008)(41300700001)(186003)(4326008)(66476007)(2616005)(83380400001)(66946007)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bm55NCs3SVNKdVg2L2pBRll1S3dDaWZyenFZN2lZSlZXYXEwN2lIWGdRaDJ6?= =?utf-8?B?TmZNdndaUCs1L3lLcWM2RU1QRkJiR3l1TTBYY0p0N3NFSDA5QWFNQ2JVd2FP?= =?utf-8?B?bDRWUnk5cmNha3NVSVNick1CdHdIb3NJa25jU0w3NDJRYlJaOWgrTVFJT0VL?= =?utf-8?B?aWx3WmNLNUMzZE9uT29EbkZFV0xxWWoxS0RLdXlMMjJYK2pXMWxsQUVodHJV?= =?utf-8?B?MTROSHprcjRSR1Z0Qmx0Q2l1ZlJ6WkdQcHArbG1KWDkyREFGY1NBUUp4djVr?= =?utf-8?B?NHZldCtzR3VYb25nODQvMVJvTDVUQ0htZGtXS3dJa3h5blRPaHU2VTVhM2c5?= =?utf-8?B?SkIyemFLZ01JTmROeVZ0MGp5K2REN0IzMkRZMmp0Z3ZTZ0dnSW9sR2FpbDNM?= =?utf-8?B?NUpZcUFXL0M0SlZPa08wS3hxbzdkRmZ5UEpyUDQxZFdVYXNlSkF3UCtyM01Z?= =?utf-8?B?SHdxVFA3eVMxRjVkc0NwQ1dKZE93SWRQek1uWXgxY0hQVUxIdFpQYWZycnAz?= =?utf-8?B?TE1nVkRuTDZTSW51TCtseUw0aTRyV3VVWDMxZC84eUxhUUJhM1dZSC9ZQ1ZW?= =?utf-8?B?UUk2aVIrbGNaV2VEUnRISVI1Zk5ic1Y5QlFsREREcUVyQU5ibStOSU5HMkRR?= =?utf-8?B?NFdxSzBCT29zd3JZSG1jTExDZGMrUE9NMTdVcm45Y0Y3Z3JNcVFyWERSRXdB?= =?utf-8?B?UWg0YW90ZE4zcjgxVjBrTXVQMXllcDlHTUVDV1grb2oxVGxvNk14NFQzT0lY?= =?utf-8?B?ZmFTN0VxNjJtRFBXa2Ewek5RMkc2TG9IV0QxY295bzVIMmhZc2JCT1cyQ2U0?= =?utf-8?B?Rjgyb2lQb0UvWXFVR3ArMktJNkxqNW9PY1NBZFU1a1VQVlY2MHF3dGpQc3py?= =?utf-8?B?SEkzWDRmWWY2anhVQTN5bVNKMTlzS0piV3hFNXEwa3QwQjFHbjg5QWovSCs5?= =?utf-8?B?Vk9hOXBoWkZmT1dXVnhZcWF6OU5OVlRLUHl2SC9RbmUrOWNmVnh5ZHlsSW9Z?= =?utf-8?B?YjJyK0lFT3FJbldMVEhUdXZqK0l2TzhTY3VSckkvMzMxdjNGVklFWXF5YkJC?= =?utf-8?B?R2NSQkFEbmwyU29uUnRZNG44UlBFa3RXR0d6bnM0RUF1ZThla0pkSlA4VHRu?= =?utf-8?B?V2YxelM5M2EwTG1uMWFqNHhHc0JSU2Z4YVZlYmlxTTZsU2E2aGF3YlJLUFlB?= =?utf-8?B?MllrZlh5S2hWZElvTlVSNEtEcUxHb0xzM25YUnM3L3hZS3VVZmlTZ2FKaUl2?= =?utf-8?B?MlBGQXJTbkNYM0I4YldmZUduenc5MHFzQTB2eDlMenNZc293S3h0ZHYyNE81?= =?utf-8?B?RlhDSE5JUS9HTThReWh4M1gvOVE3RlFlcjA1Z3hHcFB3d2xnRk4zODFKN1lI?= =?utf-8?B?emUvM0Nwd2xQK0psbzJHQ3MzUmdmRWZzZUZ2a2dlYjUyMDFhVTgvZ2VrbHpO?= =?utf-8?B?VkNiMXVYV1lvcmt3eC9PMWViN00vYTYwRk9Qb3RXQVdLQVB1ZlFoc3FUQ2FT?= =?utf-8?B?b2NxZ0ZkRDhMSitaRjV2OXc3M0ZDYjM3ekJ1NlM0Uy93QW1OVW1FNnJWS3Bi?= =?utf-8?B?OWxUYVZvb3V1aWF1NkFwbGNiaDRvMW5iL1hPSWZOODZEL0N0SWUvZkZwSnVQ?= =?utf-8?B?cFRjdCtQZHdKRFlkZE5RTUxpdGdqZnRKTmplZEV1eE9KSm56d3pOOFAreDl0?= =?utf-8?B?UVFmcVdHemJia2MvM3k1TERWMTlLeEJyYnhLNWljRWhHZHdYbVZia2plODZp?= =?utf-8?B?cG9LWXBydmFjRDFWenhvMDFVVFBmZ3dQa0YwVElLZE5tbXNWSmcyaWU4RFRk?= =?utf-8?B?SmMvQVYrVjI1SWJIZkVJdDBFODR1WjlRYjZzK01ZNFQ3ODBhVHlpUVpGYWFW?= =?utf-8?B?bjBnSVlES3VXc1Q0UjAyRzNRTEExcmZLeVlScWJWeEFRaFRmOEhOMHlIRVZp?= =?utf-8?B?RFpST0xpbHpIUnV2N3JXcEdNbnhEU0tWUVZ3b2gwdmJBRE5oTkQwMm5tTWxT?= =?utf-8?B?ZlVTbkYwYUYvb3pLZlJGRzRqY0wrcjdZeE5nQzNXTDZ6eEppNFhBMlFvK3J2?= =?utf-8?B?bk1xbkkwV2Z4MjUvUDRDWXFwMVU0M0FwbTdZQUhXT2d0ZjRta0ZZLzcxVkpa?= =?utf-8?Q?Ay771+xFT0sWdA3REIExvmJFr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51e99d88-9bb2-47a3-1c33-08dad6bb6713 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 12:22:41.2567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6/fQeIBVY1jV0YUmOL5ph1hMYcdRIBizWqmDDsw/g8mnHOWrWuJnjX21aGK1KSMQTDVhCrin23Adf5Wj9dkDkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9138 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.12.2022 13:10, Martin Liška wrote: > --- a/binutils/testsuite/binutils-all/objcopy.exp > +++ b/binutils/testsuite/binutils-all/objcopy.exp > @@ -652,8 +652,8 @@ proc strip_test_with_saving_a_symbol { } { > > set exec_output [binutils_run $NM "$NMFLAGS $objfile"] > set exec_output [prune_warnings $exec_output] > - if {![regexp {^([0-9a-fA-F]+)?[ ]+[TD] main} $exec_output] \ > - && ![regexp {^([0-9a-fA-F]+)?[ ]+T _main} $exec_output]} { > + if {![regexp {^([0-9a-fA-F]+)?[ ]+[tTD] main} $exec_output] \ Further below, for libbacktrace, you also include 'd' in the check (and 't' was already there). Could you clarify why 't' alone isn't sufficient there, but is sufficient here? > + && ![regexp {^([0-9a-fA-F]+)?[ ]+[tT] _main} $exec_output]} { While orthogonal to the purpose of the patch I still wonder whether you wouldn't better take the opportunity and fold the two regexp-s (also elsewhere): if {![regexp {^[0-9a-fA-F]*[ ]+[tTD] _?main} $exec_output]} { (with a simplification to the earlier part also included). Looking at strip_executable_with_saving_a_symbol, which you also adjust, the [TtD] vs [tT] difference looks to be accidental rather than deliberate. Jan