public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tristan Gingold <gingold@adacore.com>
To: Richard Earnshaw <rearnsha@arm.com>
Cc: Marcus Shawcroft <marcus.shawcroft@gmail.com>,
	"binutils@sourceware.org Development" <binutils@sourceware.org>
Subject: Re: [Mach-O, committed]: Add definition for arm64 cpu
Date: Thu, 27 Mar 2014 08:18:00 -0000	[thread overview]
Message-ID: <3926D95A-988F-4E93-ADF2-014C0CEA3647@adacore.com> (raw)
In-Reply-To: <53330500.60906@arm.com>


On 26 Mar 2014, at 17:49, Richard Earnshaw <rearnsha@arm.com> wrote:

> On 26/03/14 16:43, Marcus Shawcroft wrote:
>> On 26 March 2014 16:34, Tristan Gingold <gingold@adacore.com> wrote:
>> 
>>> In fact it is consistent with the macro name defined by Apple :-(
>>> Hard to be consistent with two non-consistent usages.
>> 
>> That justification does not hold for the name string in bfd_mach_o_cpu_name[].
>> 
>> /Marcus
>> 
> 
> Nor does it hold for the internal names, eg BFD_MACH_O_CPU_TYPE_ARM64

This is not an internal name, but was derived from an Apple header file.  Compare
the definition of bfd_mach_o_cpu_type with:

...
#define CPU_TYPE_MC98000        ((cpu_type_t) 10)
#define CPU_TYPE_HPPA           ((cpu_type_t) 11)
#define CPU_TYPE_ARM            ((cpu_type_t) 12)
#define CPU_TYPE_ARM64          (CPU_TYPE_ARM | CPU_ARCH_ABI64)
#define CPU_TYPE_MC88000        ((cpu_type_t) 13)
#define CPU_TYPE_SPARC          ((cpu_type_t) 14)
#define CPU_TYPE_I860           ((cpu_type_t) 15)
/* skip CPU_TYPE_ALPHA          ((cpu_type_t) 16)       */
/* skip                         ((cpu_type_t) 17)       */
#define CPU_TYPE_POWERPC                ((cpu_type_t) 18)
...

I added BFD_MACH_O_ prefix as a namespace.

Tristan.

  reply	other threads:[~2014-03-27  8:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-26 15:10 Tristan Gingold
2014-03-26 16:24 ` Richard Earnshaw
2014-03-26 16:34   ` Tristan Gingold
2014-03-26 16:43     ` Marcus Shawcroft
2014-03-26 16:49       ` Richard Earnshaw
2014-03-27  8:18         ` Tristan Gingold [this message]
2014-03-27  8:22       ` Tristan Gingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3926D95A-988F-4E93-ADF2-014C0CEA3647@adacore.com \
    --to=gingold@adacore.com \
    --cc=binutils@sourceware.org \
    --cc=marcus.shawcroft@gmail.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).