From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id D379A385E017 for ; Wed, 20 Dec 2023 08:57:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D379A385E017 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D379A385E017 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703062642; cv=none; b=s97Oxav0ImIa9vxM9YX0k5icGo/fGxetX9pittbWSxUhFOQAHKAB5G6zo1bVCSytu1Uyq+wY3KngadgMrqiGme4kwwuBsxpXIwyRvSwQpF2rtLIdzDRyvzzkBcOYBl/z8hc+B7Uvb4JgAeq0vadH46JR6ymgQGAWHw6rdONwEEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703062642; c=relaxed/simple; bh=F0urUNZefPFh72G2pyHbr6t5tQYwQaKqeHrmLtmcLLw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tqXh7WaUo6U4SK3D6JQ+ui2FFA3kHU5HuCCDyQ/BksvuuwUiVUrZBEHQJ/NsYs/lUZ0xhhKfFHguvpphraeDjH8XD3fD6TjATDs58PTKTFiL1/lSv7Go+KgnjhbsxGOqahqGEopzK56MW3MDnbRdSprx68VRiFMsGgWNWrSytXw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3365752934bso4433788f8f.2 for ; Wed, 20 Dec 2023 00:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1703062639; x=1703667439; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lG6UqLPBG6QIcXPuLuaG1RZPSVCe5MorurxBtpaBgn4=; b=bLShDq6V+iYyNMauscXWpcXcgkHImLqxLGZlgaScZxUNXbkAiprG1A9D3VNNxkb6ae E/+Xj5jLVyP01Eq6EjffXQiSHLwU/x/8NS6iuMU2p6plTgYVPITqlNK8d7ox4ugOI5gS dQ1Roa6Rmj1f1ICX/Yc7J5t+mYO8U8Ao8Kjump/e9/VBiSRO6l9h2SsSaCglpP9rlD9h +baGH2ESy0W3xIrZfIZ4vlamlP0sF4NGDotipbOJbc7iIWWhBZYTI4Gj8L9SpQxuiBHU WKUwkUs1tuplttLdh1tZrcI/qGjMS6xfI9XKABEvpXIJvZTwfoxPACDmfRhlt84RVlCc XveA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703062639; x=1703667439; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lG6UqLPBG6QIcXPuLuaG1RZPSVCe5MorurxBtpaBgn4=; b=h8X2RWZYmHczI3GR4ewuysFMAxO9zJxRBatoqdwsGnh0x0K2sN+j9uHiGCN7o52JgZ y+5++JCqS9UBq0Yuwxarn9f7s3zFXxE3g6+BtCQBTGVBoVQcRTt1ccmMhj2ylnPTJr8E P3Zvuugd7EcABGiWuypsO5nSJOh4Th9q8RnxMseVUgqIYuicYVQUryKyvf4zuULvrAW/ WhrSht8LpSvZy+OJ9r2Su9smeYzzYkG7RHbJ8AN0I/rTOCHPRE7z2IsBTmdqRzAtBOjH /HhDhgY6SgpkYHrzD9oAjxxLlPNME2wwJED7max6KNGEGeRaILzt/DIexKGCgCbiVj1/ z8yQ== X-Gm-Message-State: AOJu0YymKP5rxpHV8sJ9hHWNdqB9TJLrXpEMREkLQPgms9lY8+pKNWIC X7a7sP+vv6uXFJlD+SX2eGgi X-Google-Smtp-Source: AGHT+IGj8Ed12OPfkJzqKuvq4/3NzfdG21So8qr6Z9+KwH611fHjhL+xktf1YRQXNqFXJQRFJ6LfWw== X-Received: by 2002:a05:6000:18d1:b0:333:5920:eeac with SMTP id w17-20020a05600018d100b003335920eeacmr10453820wrq.128.1703062639591; Wed, 20 Dec 2023 00:57:19 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id b18-20020adfee92000000b003367b7a5581sm945724wro.28.2023.12.20.00.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 00:57:19 -0800 (PST) Message-ID: <39ccd434-387b-4560-b5f4-6a1b7fd825c9@suse.com> Date: Wed, 20 Dec 2023 09:57:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/9] Support Intel APX EGPR Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20231219121218.974012-1-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.12.2023 09:50, Cui, Lili wrote: >> On 19.12.2023 13:12, Cui, Lili wrote: >>> *** BLURB HERE *** >>> Future optimizations to be made. >>> 1. The current implementation of vexvvvvv needs to be optimized. >>> 2. The handling of double VEX/EVEX templates in check_register() needs to >> be optimized. >> >> I hope this is just stale here, and the dependency on templates was now >> removed again from check_register(). > > In fact, I didn't remove it in V4, I didn't find a better place to deal with it. I don't know if you agree with this implementation below. I'm afraid I don't, both because it still isn't clear to me what's wrong with my alternative proposal, and also for the formal reason of ... > /* For dual VEX/EVEX templates, evex encoding is required when the input has > egpr.*/ > static INLINE void > vex_with_Egpr_requires_evex_encoding (const insn_template *t) > { > for (unsigned int op = 0; op < i.operands; op++) > { > if (i.types[op].bitfield.class != Reg) > continue; > > if (i.op[op].regs->reg_flags & RegRex2) > i.vec_encoding = vex_encoding_evex; ... it not being okay to override i.vec_encoding like this, when it may already have been set to another value. Jan > } > > if ((i.index_reg && (i.index_reg->reg_flags & RegRex2)) > || (i.base_reg && (i.base_reg->reg_flags & RegRex2))) > i.vec_encoding = vex_encoding_evex; > } > > static INLINE void > install_template (const insn_template *t) > { > unsigned int l; > > i.tm = *t; > > /* Dual VEX/EVEX templates need stripping one of the possible variants. */ > if (t->opcode_modifier.vex && t->opcode_modifier.evex) > { > vex_with_Egpr_requires_evex_encoding (t); > > > Regards, > Lili.