From: Tom Rix <trix@redhat.com>
To: "H . J . Lu" <hjl@lucon.org>
Cc: binutils@sourceware.cygnus.com
Subject: Re: An rs6000 patch for bfd
Date: Tue, 29 May 2001 06:42:00 -0000 [thread overview]
Message-ID: <3B13A749.313BF512@redhat.com> (raw)
In-Reply-To: <20010525143001.B15080@lucon.org>
This looks ok with me, aix 4.3.3 builds...
Fixes undefined core functions.
Tom
"H . J . Lu" wrote:
>
> Hi Tom,
>
> Your rs6000 change breaks ppc-linux. I checked in the following patch.
> Please double check it.
>
> Thanks.
>
> H.J.
> ----
> 2001-05-25 H.J. Lu <hjl@gnu.org>
>
> * coff-rs6000.c (rs6000coff_vec): Use rs6000coff_core_p,
> rs6000coff_core_file_matches_executable_p,
> rs6000coff_core_file_failing_command and
> rs6000coff_core_file_failing_signal only if AIX_CORE is
> defined.
> (pmac_xcoff_vec): Likewise.
> * coff64-rs6000.c (rs6000coff64_vec): Likewise.
>
> Index: coff-rs6000.c
> ===================================================================
> RCS file: /work/cvs/gnu/binutils/bfd/coff-rs6000.c,v
> retrieving revision 1.1.1.15
> diff -u -p -r1.1.1.15 coff-rs6000.c
> --- coff-rs6000.c 2001/05/25 04:22:40 1.1.1.15
> +++ coff-rs6000.c 2001/05/25 21:19:56
> @@ -37,10 +37,6 @@ Foundation, Inc., 59 Temple Place - Suit
> #include "libcoff.h"
> #include "libxcoff.h"
>
> -extern const bfd_target * rs6000coff_core_p ();
> -extern boolean rs6000coff_core_file_matches_executable_p ();
> -extern char *rs6000coff_core_file_failing_command PARAMS ((bfd *abfd));
> -extern int rs6000coff_core_file_failing_signal PARAMS ((bfd *abfd));
> extern boolean _bfd_xcoff_mkobject PARAMS ((bfd *));
> extern boolean _bfd_xcoff_copy_private_bfd_data PARAMS ((bfd *, bfd *));
> extern boolean _bfd_xcoff_is_local_label_name PARAMS ((bfd *, const char *));
> @@ -84,7 +80,27 @@ void _bfd_xcoff_rtype2howto PARAMS ((are
> #define coff_bfd_copy_private_bfd_data _bfd_xcoff_copy_private_bfd_data
> #define coff_bfd_is_local_label_name _bfd_xcoff_is_local_label_name
> #define coff_bfd_reloc_type_lookup _bfd_xcoff_reloc_type_lookup
> +#ifdef AIX_CORE
> +extern const bfd_target * rs6000coff_core_p ();
> +extern boolean rs6000coff_core_file_matches_executable_p ();
> +extern char *rs6000coff_core_file_failing_command PARAMS ((bfd *abfd));
> +extern int rs6000coff_core_file_failing_signal PARAMS ((bfd *abfd));
> #define CORE_FILE_P rs6000coff_core_p
> +#define coff_core_file_failing_command \
> + rs6000coff_core_file_failing_command
> +#define coff_core_file_failing_signal \
> + rs6000coff_core_file_failing_signal
> +#define coff_core_file_matches_executable_p \
> + rs6000coff_core_file_matches_executable_p
> +#else
> +#define CORE_FILE_P _bfd_dummy_target
> +#define coff_core_file_failing_command \
> + _bfd_nocore_core_file_failing_command
> +#define coff_core_file_failing_signal \
> + _bfd_nocore_core_file_failing_signal
> +#define coff_core_file_matches_executable_p \
> + _bfd_nocore_core_file_matches_executable_p
> +#endif
> #define coff_SWAP_sym_in _bfd_xcoff_swap_sym_in
> #define coff_SWAP_sym_out _bfd_xcoff_swap_sym_out
> #define coff_SWAP_aux_in _bfd_xcoff_swap_aux_in
> @@ -3050,10 +3066,10 @@ const bfd_target rs6000coff_vec =
> ((boolean (*) (bfd *, void * )) bfd_true), /* _bfd_print_private_bfd_data */
>
> /* Core */
> - rs6000coff_core_file_failing_command, /* _core_file_failing_command */
> - rs6000coff_core_file_failing_signal, /* _core_file_failing_signal */
> + coff_core_file_failing_command, /* _core_file_failing_command */
> + coff_core_file_failing_signal, /* _core_file_failing_signal */
> /* _core_file_matches_executable_p */
> - rs6000coff_core_file_matches_executable_p,
> + coff_core_file_matches_executable_p,
>
> /* Archive */
> _bfd_xcoff_slurp_armap, /* _slurp_armap */
> @@ -3307,10 +3323,10 @@ const bfd_target pmac_xcoff_vec =
> ((boolean (*) (bfd *, void * )) bfd_true), /* _bfd_print_private_bfd_data */
>
> /* Core */
> - rs6000coff_core_file_failing_command, /* _core_file_failing_command */
> - rs6000coff_core_file_failing_signal, /* _core_file_failing_signal */
> + coff_core_file_failing_command, /* _core_file_failing_command */
> + coff_core_file_failing_signal, /* _core_file_failing_signal */
> /* _core_file_matches_executable_p */
> - rs6000coff_core_file_matches_executable_p,
> + coff_core_file_matches_executable_p,
>
> /* Archive */
> _bfd_xcoff_slurp_armap, /* _slurp_armap */
> Index: coff64-rs6000.c
> ===================================================================
> RCS file: /work/cvs/gnu/binutils/bfd/coff64-rs6000.c,v
> retrieving revision 1.1.1.7
> diff -u -p -r1.1.1.7 coff64-rs6000.c
> --- coff64-rs6000.c 2001/05/25 04:22:41 1.1.1.7
> +++ coff64-rs6000.c 2001/05/25 21:19:56
> @@ -410,10 +410,6 @@ _bfd_xcoff64_put_ldsymbol_name (abfd, ld
> return true;
> }
>
> -extern const bfd_target * rs6000coff_core_p ();
> -extern boolean rs6000coff_core_file_matches_executable_p ();
> -extern char *rs6000coff_core_file_failing_command PARAMS ((bfd *abfd));
> -extern int rs6000coff_core_file_failing_signal PARAMS ((bfd *abfd));
> extern boolean _bfd_xcoff_mkobject PARAMS ((bfd *));
> extern boolean _bfd_xcoff_copy_private_bfd_data PARAMS ((bfd *, bfd *));
> extern boolean _bfd_xcoff_is_local_label_name PARAMS ((bfd *, const char *));
> @@ -457,7 +453,27 @@ extern unsigned int _bfd_xcoff_swap_aux_
> #define coff_bfd_copy_private_bfd_data _bfd_xcoff_copy_private_bfd_data
> #define coff_bfd_is_local_label_name _bfd_xcoff_is_local_label_name
> #define coff_bfd_reloc_type_lookup xcoff64_reloc_type_lookup
> +#ifdef AIX_CORE
> +extern const bfd_target * rs6000coff_core_p ();
> +extern boolean rs6000coff_core_file_matches_executable_p ();
> +extern char *rs6000coff_core_file_failing_command PARAMS ((bfd *abfd));
> +extern int rs6000coff_core_file_failing_signal PARAMS ((bfd *abfd));
> #define CORE_FILE_P rs6000coff_core_p
> +#define coff_core_file_failing_command \
> + rs6000coff_core_file_failing_command
> +#define coff_core_file_failing_signal \
> + rs6000coff_core_file_failing_signal
> +#define coff_core_file_matches_executable_p \
> + rs6000coff_core_file_matches_executable_p
> +#else
> +#define CORE_FILE_P _bfd_dummy_target
> +#define coff_core_file_failing_command \
> + _bfd_nocore_core_file_failing_command
> +#define coff_core_file_failing_signal \
> + _bfd_nocore_core_file_failing_signal
> +#define coff_core_file_matches_executable_p \
> + _bfd_nocore_core_file_matches_executable_p
> +#endif
> #define coff_SWAP_sym_in _bfd_xcoff64_swap_sym_in
> #define coff_SWAP_sym_out _bfd_xcoff64_swap_sym_out
> #define coff_SWAP_aux_in _bfd_xcoff64_swap_aux_in
> @@ -2146,7 +2162,7 @@ const bfd_target rs6000coff64_vec =
> _bfd_dummy_target,
> coff_object_p,
> xcoff64_archive_p,
> - rs6000coff_core_p
> + CORE_FILE_P
> },
>
> { /* bfd_set_format */
> @@ -2183,10 +2199,10 @@ const bfd_target rs6000coff64_vec =
> ((boolean (*) (bfd *, void * )) bfd_true), /* _bfd_print_private_bfd_data */
>
> /* Core */
> - rs6000coff_core_file_failing_command, /* _core_file_failing_command */
> - rs6000coff_core_file_failing_signal, /* _core_file_failing_signal */
> + coff_core_file_failing_command, /* _core_file_failing_command */
> + coff_core_file_failing_signal, /* _core_file_failing_signal */
> /* _core_file_matches_executable_p */
> - rs6000coff_core_file_matches_executable_p,
> + coff_core_file_matches_executable_p,
>
> /* Archive */
> xcoff64_slurp_armap, /* _slurp_armap */
--
Tom Rix
GCC Engineer
trix@redhat.com
256.704.9201
prev parent reply other threads:[~2001-05-29 6:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-25 14:30 H . J . Lu
2001-05-29 6:42 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B13A749.313BF512@redhat.com \
--to=trix@redhat.com \
--cc=binutils@sourceware.cygnus.com \
--cc=hjl@lucon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).