Prototype of __rtinit.rtl in include/coff/xcoff.h?

Prototype of __rtinit.rtl in include/coff/xcoff.h?

[Andreas Jaeger]

AIX (?) experts, what's the parameter for rtl in struct __rtinit (see
include/coff/xcoff.h):

/* 
 * __rtinit 
 * from /usr/include/rtinit.h
 */
struct __rtinit {
  int		(*rtl)();		/* Pointer to runtime linker */
  int		init_offset;		/* Offset to array of init functions
					   (0 if none). */
  int		fini_offset;		/* Offset to array of fini functions
					   (0 if none). */
  int		__rtinit_descriptor_size; /* Size of __RTINIT_DESCRIPTOR.
					     This value should be used instead
					     of sizeof(__RTINIT_DESCRIPTOR). */
};

To silence warnings about "function declaration isn't a prototype" I
need to know whether rtl takes parameter and which ones.

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj

Re: Prototype of __rtinit.rtl in include/coff/xcoff.h?

[Tom Rix]

Andreas Jaeger wrote:
> 
> AIX (?) experts, what's the parameter for rtl in struct __rtinit (see
> include/coff/xcoff.h):

This is my code, 

At the current time, this element is not used so just make it (void).  If I find
out what it is used for,  I will change it.   

btw, this was a cut-n-paste from the system header rtinit.h, no help on proper
parameter there.

Tom


Tom Rix 
GCC Engineer
trix@redhat.com
256.704.9201

Re: Prototype of __rtinit.rtl in include/coff/xcoff.h?

[Andreas Jaeger]

Tom Rix <trix@redhat.com> writes:

> Andreas Jaeger wrote:
> > 
>> AIX (?) experts, what's the parameter for rtl in struct __rtinit (see
>> include/coff/xcoff.h):
>
> This is my code, 
>
> At the current time, this element is not used so just make it (void).  If I find
> out what it is used for,  I will change it.   

Shall I commit the appended patch then?

> btw, this was a cut-n-paste from the system header rtinit.h, no help on proper
> parameter there.

That's what I feared.

Andreas

2001-08-27  Andreas Jaeger  <aj@suse.de>

	* xcoff.h (struct __rtinit): Make proper prototype for rtl.

============================================================
Index: include/coff/xcoff.h
--- include/coff/xcoff.h	2001/05/24 20:32:58	1.1
+++ include/coff/xcoff.h	2001/08/27 07:43:21
@@ -1,6 +1,6 @@
 /* Internal format of XCOFF object file data structures for BFD.
 
-   Copyright 1995, 1996, 1997, 1998, 1999, 2000 Free Software Foundation, Inc.
+   Copyright 1995, 1996, 1997, 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
    Written by Ian Lance Taylor <ian@cygnus.com>, Cygnus Support.
 
    This file is part of BFD, the Binary File Descriptor library.
@@ -425,7 +425,8 @@ struct xcoff_loader_info
  * from /usr/include/rtinit.h
  */
 struct __rtinit {
-  int		(*rtl)();		/* Pointer to runtime linker */
+  int		(*rtl) PARAMS((void));	/* Pointer to runtime linker.
+					 XXX: Is the parameter really void?  */
   int		init_offset;		/* Offset to array of init functions
 					   (0 if none). */
   int		fini_offset;		/* Offset to array of fini functions

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj

Re: Prototype of __rtinit.rtl in include/coff/xcoff.h?

[Tom Rix]

Andreas Jaeger wrote:

> Shall I commit the appended patch then?

The patch looks ok to me.

Tom

> 2001-08-27  Andreas Jaeger  <aj@suse.de>
> 
>         * xcoff.h (struct __rtinit): Make proper prototype for rtl.
> 
> ============================================================
> Index: include/coff/xcoff.h
> --- include/coff/xcoff.h        2001/05/24 20:32:58     1.1
> +++ include/coff/xcoff.h        2001/08/27 07:43:21
> @@ -1,6 +1,6 @@
>  /* Internal format of XCOFF object file data structures for BFD.
> 
> -   Copyright 1995, 1996, 1997, 1998, 1999, 2000 Free Software Foundation, Inc.
> +   Copyright 1995, 1996, 1997, 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
>     Written by Ian Lance Taylor <ian@cygnus.com>, Cygnus Support.
> 
>     This file is part of BFD, the Binary File Descriptor library.
> @@ -425,7 +425,8 @@ struct xcoff_loader_info
>   * from /usr/include/rtinit.h
>   */
>  struct __rtinit {
> -  int          (*rtl)();               /* Pointer to runtime linker */
> +  int          (*rtl) PARAMS((void));  /* Pointer to runtime linker.
> +                                        XXX: Is the parameter really void?  */
>    int          init_offset;            /* Offset to array of init functions
>                                            (0 if none). */
>    int          fini_offset;            /* Offset to array of fini functions
> 
> --
>  Andreas Jaeger
>   SuSE Labs aj@suse.de
>    private aj@arthur.inka.de
>     http://www.suse.de/~aj

-- 
Tom Rix 
GCC Engineer
trix@redhat.com
256.704.9201