From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tracy Kuhrt To: binutils@sourceware.cygnus.com Subject: fx_offset Population Date: Thu, 30 Aug 2001 13:03:00 -0000 Message-id: <3B8E9C1C.861BE80A@microchip.com> X-SW-Source: 2001-08/msg00697.html In working on testing a new port, I found a problem... In fix_new_internal, the fx_offset member of the fixP structure is populated with the offset, which is the value from the expressionS structure's'X_add_number. The problem... X_add_number is an offsetT (which in the end is a signed value). fx_offset is a valueT (which in the end is an unsigned value). When setting fx_offset to X_add_number, X_add_number is converted from a signed value to an unsigned value. So in my test case, I have the expression . - 65536. When the fixup is created -65536 is converted to an unsigned 4294901760. What would be the harm of changing fx_offset to be an offsetT? Tracy