Re: bfd target lists

[Andrew Cagney <ac131313@redhat.com>]

> If anyone has taken a close look at the list of targets printed by
> say, objdump --help, when compiled with --enable-targets=all, you
> may have noticed that the default target is mentioned twice.
> 
> This patch corrects the situation, but since this may affect gdb
> I'd like some comment from the gdb camp before I commit the change.
> 
> 	* targets.c (bfd_target_list): Don't return the default
> 	target twice.
> 
> Index: bfd/targets.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/targets.c,v
> retrieving revision 1.78
> diff -u -p -r1.78 targets.c
> --- bfd/targets.c	9 Oct 2002 19:03:57 -0000	1.78
> +++ bfd/targets.c	15 Oct 2002 07:24:00 -0000
> @@ -1279,7 +1279,9 @@ bfd_target_list ()
>      return NULL;
>  
>    for (target = &bfd_target_vector[0]; *target != NULL; target++)
> -    *(name_ptr++) = (*target)->name;
> +    if (target == &bfd_target_vector[0]
> +	|| *target != bfd_target_vector[0])
> +      *name_ptr++ = (*target)->name;
>  
>    return name_list;
>  }

Turned out to be harmless, thanks for remembering us :-)

BTW, how does:
	*name_ptr++ = &bfd_target_vector[0]->name;
	for (target = &bfd_target_vector[1]; *target != NULL; target++)
	  if (*target != bfd_target_vector[0])
	    *name_ptr++ = (*target)->name;
look.

Andrew