public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [patch/coff] Remove exec_hdr
@ 2011-03-30 10:12 Tristan Gingold
  2011-03-30 16:01 ` Nick Clifton
  0 siblings, 1 reply; 3+ messages in thread
From: Tristan Gingold @ 2011-03-30 10:12 UTC (permalink / raw)
  To: binutils

Hi,

the definition of libcoff.h:exec_hdr references the 'hdr' field of struct coff_tdata, but this field doesn't exist.
A quick grep also shows that this macro is not used (hopefully).

So I propose a little cleanup: removing this macro.

Sanity-checked by rebuilding powerpc-ibm-aix.

Ok for trunk ?

Tristan.

bfd/
2011-03-30  Tristan Gingold  <gingold@adacore.com>

      * libcoff-in.h (exec_hdr): Remove.
      * libcoff.h: Regenerate.

diff --git a/bfd/libcoff-in.h b/bfd/libcoff-in.h
index e2b60c5..9d24748 100644
--- a/bfd/libcoff-in.h
+++ b/bfd/libcoff-in.h
@@ -26,7 +26,6 @@
 /* Object file tdata; access macros.  */
 
 #define coff_data(bfd)               ((bfd)->tdata.coff_obj_data)
-#define exec_hdr(bfd)                (coff_data (bfd)->hdr)
 #define obj_pe(bfd)                   (coff_data (bfd)->pe)
 #define obj_symbols(bfd)             (coff_data (bfd)->symbols)
 #define        obj_sym_filepos(bfd)          (coff_data (bfd)->sym_filepos)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch/coff] Remove exec_hdr
  2011-03-30 10:12 [patch/coff] Remove exec_hdr Tristan Gingold
@ 2011-03-30 16:01 ` Nick Clifton
  2011-03-31  8:14   ` Tristan Gingold
  0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2011-03-30 16:01 UTC (permalink / raw)
  To: Tristan Gingold; +Cc: binutils

Hi Tristan,

> bfd/
> 2011-03-30  Tristan Gingold<gingold@adacore.com>
>
>        * libcoff-in.h (exec_hdr): Remove.
>        * libcoff.h: Regenerate.

Approved - please apply.

Cheers
   Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch/coff] Remove exec_hdr
  2011-03-30 16:01 ` Nick Clifton
@ 2011-03-31  8:14   ` Tristan Gingold
  0 siblings, 0 replies; 3+ messages in thread
From: Tristan Gingold @ 2011-03-31  8:14 UTC (permalink / raw)
  To: Nick Clifton; +Cc: binutils


On Mar 30, 2011, at 6:01 PM, Nick Clifton wrote:

> Hi Tristan,
> 
>> bfd/
>> 2011-03-30  Tristan Gingold<gingold@adacore.com>
>> 
>>       * libcoff-in.h (exec_hdr): Remove.
>>       * libcoff.h: Regenerate.
> 
> Approved - please apply.

Thanks, committed.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-03-31  8:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-30 10:12 [patch/coff] Remove exec_hdr Tristan Gingold
2011-03-30 16:01 ` Nick Clifton
2011-03-31  8:14   ` Tristan Gingold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).