From: Jim Wilson <wilson@tuliptree.org>
To: "H. J. Lu" <hjl@lucon.org>
Cc: binutils@sources.redhat.com
Subject: Re: RFA: Please comment on this ia64 patch
Date: Fri, 02 May 2003 23:43:00 -0000 [thread overview]
Message-ID: <3EB2D89E.6020803@tuliptree.org> (raw)
In-Reply-To: <20030502083054.A16112@lucon.org>
H. J. Lu wrote:
> I added the support for 'o' and "unwind" in section directive for ia64
> in this patch
The part I can't answer is the question about having a generic letter
that maps to SEC_LINK_ORDER. Someone else would have to comment on
that. I suspect it wouldn't be very useful at this time because
GNU/Linux doesn't actively use SEC_LINK_ORDER.
I noticed you didn't put 'o' into the IA-64 error message. If we are
accepting 'o', we should document it in the error message.
I noticed you don't set the SHF_LINK_ORDER when seeing the 'o'. This
does do something useful, though maybe not for GNU/Linux system. I know
that the IA-64 ABI and HPUX require that it be set. This has come up
before. Note that bfd/elfxx-ia64.c tries to set SHF_LINK_ORDER and
SHT_IA_64_UNWIND for unwind section. So I think your patch should
return SHF_LINK_ORDER for 'o' to be consistent. See also the code in
elfNN_ia64_final_write_processing that sets the sh_link and sh_info
fields which is supposed to make SHF_LINK_ORDER useful.
Otherwise the patch looks fine. The non-IA-64 parts look like obvious
bug fixes, so I'll approve the entire patch with the two suggestions I
made above.
Jim
next prev parent reply other threads:[~2003-05-02 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-02 15:30 H. J. Lu
2003-05-02 23:43 ` Jim Wilson [this message]
2003-05-03 16:05 ` H. J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB2D89E.6020803@tuliptree.org \
--to=wilson@tuliptree.org \
--cc=binutils@sources.redhat.com \
--cc=hjl@lucon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).