[PATCH] PE IMAGE_FILE_32BIT_MACHINE flag

[PATCH] PE IMAGE_FILE_32BIT_MACHINE flag

[Jeff Muizelaar]

[-- Attachment #1: Type: text/plain, Size: 128 bytes --]

It seems all the pe's I have seen have this set and as most machines 
that use pe's are 32 bit we should set it as well.

-Jeff

[-- Attachment #2: 32bit-machine.patch --]
[-- Type: text/plain, Size: 420 bytes --]

diff -urN binutils-030703/bfd/coffcode.h binutils-32bit-machine/bfd/coffcode.h
--- binutils-030703/bfd/coffcode.h	2003-06-04 07:38:30.000000000 -0400
+++ binutils-32bit-machine/bfd/coffcode.h	2003-07-08 21:54:02.000000000 -0400
@@ -3878,6 +3878,8 @@
     internal_f.f_flags |= F_AR32WR;
   else
     internal_f.f_flags |= F_AR32W;
+#else
+  internal_f.f_flags |= IMAGE_FILE_32BIT_MACHINE;
 #endif
 
 #ifdef TI_TARGET_ID

Re: [PATCH] PE IMAGE_FILE_32BIT_MACHINE flag

[Jeff Muizelaar]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

Jeff Muizelaar wrote:

> It seems all the pe's I have seen have this set and as most machines 
> that use pe's are 32 bit we should set it as well.
>
The attached patch does the same except inverts the #IFNDEF to make 
things a little more clear.

-Jeff

[-- Attachment #2: 32bit-machine-invert.patch --]
[-- Type: text/plain, Size: 493 bytes --]

diff -urN binutils-030703/bfd/coffcode.h binutils-32bit-machine/bfd/coffcode.h
--- binutils-030703/bfd/coffcode.h	2003-06-04 07:38:30.000000000 -0400
+++ binutils-32bit-machine/bfd/coffcode.h	2003-07-09 20:18:49.000000000 -0400
@@ -3873,7 +3873,9 @@
     internal_f.f_flags |= IMAGE_FILE_DEBUG_STRIPPED;
 #endif
 
-#ifndef COFF_WITH_PE
+#ifdef COFF_WITH_PE
+  internal_f.f_flags |= IMAGE_FILE_32BIT_MACHINE;
+#else
   if (bfd_little_endian (abfd))
     internal_f.f_flags |= F_AR32WR;
   else

Re: [PATCH] PE IMAGE_FILE_32BIT_MACHINE flag

[Nick Clifton]

Hi Jeff,

>> It seems all the pe's I have seen have this set and as most machines
>> that use pe's are 32 bit we should set it as well.
>>
> The attached patch does the same except inverts the #IFNDEF to make
> things a little more clear.
>
> -Jeff
> diff -urN binutils-030703/bfd/coffcode.h binutils-32bit-machine/bfd/coffcode.h
> --- binutils-030703/bfd/coffcode.h	2003-06-04 07:38:30.000000000 -0400
> +++ binutils-32bit-machine/bfd/coffcode.h	2003-07-09 20:18:49.000000000 -0400
> @@ -3873,7 +3873,9 @@
>      internal_f.f_flags |= IMAGE_FILE_DEBUG_STRIPPED;
>  #endif
>  
> -#ifndef COFF_WITH_PE
> +#ifdef COFF_WITH_PE
> +  internal_f.f_flags |= IMAGE_FILE_32BIT_MACHINE;
> +#else
>    if (bfd_little_endian (abfd))
>      internal_f.f_flags |= F_AR32WR;
>    else

Could you supply a ChangeLog entry to go along with this patch please?

Cheers
        Nick
        

Re: [PATCH] PE IMAGE_FILE_32BIT_MACHINE flag

[Jeff Muizelaar]

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

Nick Clifton wrote:

>
>Could you supply a ChangeLog entry to go along with this patch please?
>  
>
Something like this?

-Jeff


[-- Attachment #2: ChangeLogEntry --]
[-- Type: text/plain, Size: 143 bytes --]

2003-07-11  Jeff Muizelaar  <muizelaar@rogers.com>

	* coffcode.h (coff_set_section_contents): Set the
	IMAGE_FILE_32BIT_MACHINE flag for PE.

Re: [PATCH] PE IMAGE_FILE_32BIT_MACHINE flag

[Nick Clifton]

Hi Jeff,

> Something like this?

Yes thanks. :-)

> 2003-07-11  Jeff Muizelaar  <muizelaar@rogers.com>
>
> 	* coffcode.h (coff_set_section_contents): Set the
> 	IMAGE_FILE_32BIT_MACHINE flag for PE.

Patch approved and applied.

Cheers
        Nick