From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2076.outbound.protection.outlook.com [40.107.21.76]) by sourceware.org (Postfix) with ESMTPS id 0E9E3385AE43 for ; Tue, 5 Jul 2022 06:53:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E9E3385AE43 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/+5OM4M7BDE9GzVvsOnUmm9a4/JToIvZEjF+FJCmf33t3afwYLnB8tYMTMbtZIVSRacWJCTQqpvpHmy4w5DJdj566KkZHAqIVXTrsle7johL5V8yPn4b1sdsIQyv0RyIW1i29oKFJc9EaEtICYU0MrQM5pWOTQ/BLL7RFyABgSNaN/X9RKot50seCn4LcD9SlWS7ERcjVlFQkSc+FdI1twbuEO4M06im36inPfqFtcb9I4d6wzbsC4d7GDo/yHcRlxNqzcXu8iZXLIVm07UTOcp7S3j9vv8aGl0PPtn8Ew0EoT8SOhRPttMDwA+IPtae7WgdEnlbg4VUGQANKv4XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EbeYWiv+XrVzSuGNNK0QSO4vdnwqlGOtMsjXZ4sy9U0=; b=Dn1156qVrRuYjRn5ccliRgz9ZJGWQ2mlfd8UIbsJBs3y/YinpfFKrXICrzOr51VewwalcYWHrIPaeBVrwq6ZGLGBl6zMCDmqp2vFrdDDY0yAavOf21ib/WPLV+9nfmZhr0VbfkOdnGBd58vi7cOXfIfqn+FDiLeen61uFN3n9rqzdqJTU8FNllZZtL5i3ngMD0Wh6s6Ndm+kSBLXVK1it3jLxtgYFt3XFbcII9wVi9c+Bmk65B6mV1WA6IJF+YI1zdQhkI+NE/nQ4z57dH3/ELJ+2i8OeBcHbPTwiiRQhBbI5BmrEeQ2lMaKi/25Kh1iq4kmXHkwQAWlCRvENIlMbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM4PR0401MB2356.eurprd04.prod.outlook.com (2603:10a6:200:49::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 06:53:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 06:53:42 +0000 Message-ID: <3a03da91-a1a5-c25c-cf06-53fee674b833@suse.com> Date: Tue, 5 Jul 2022 08:53:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH 2/3] x86: fold two switch() statements in match_template() Content-Language: en-US To: Binutils References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a0662d8-2099-41d3-d093-08da5e5318e4 X-MS-TrafficTypeDiagnostic: AM4PR0401MB2356:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gjBlnCY+/S0oQ8O1/0e3zx755QCs0NEWuSCDwyHQfeWnmQdGwixhA9oRHGAl0RpMlmwSeahBRYQKQCBKMGVTbmw1QWYJrSeHOMbT2/3A+KXvq3+XpQDxKwvOnZy3duq9cnegBuA7XNuKVwZZhiXyt3ciJf5NRdB5fPNA8biYTVNuuEtgQbwbMboK3Zw3a0+Zrp46CNOKA+iygsR2LnLra+0ziPEt/dGjbtmrGbwEnvGNmkQd7dLFGR85DnBUzYaOzn2+sU9w31dxJa2UBVAJ7KAmD0KzP4/KQTpcN8e9LHdMOhpTxinu58rvAlq0szDWP1PgpbraqicKaJ0UQAwtq2b53/mWZllUo+22syQGrhAeBgcULp5v47ysbIdCkPuCYdb27ZAtHokyurv+oOGP0/drq6x1qcsMfhuIRLn4QzR1C3RFVB6lW/N6xA9LhhQISGnU9+K3zAmV1W+9hrouldGw11K0ZnOR+GypXXUhodusz4+iKa1H3+1Q3OnAVoID6WDhwkQ7XM5H8zYhc82vJf2zajiC2CzA+Y7cLJ39f1cKloV3t7NsoMRtFy6zSQDnxKUXg9BaizkoPi8PRJqiugBjYXJdqmFQoBXmIzoX7SX8zjohh62kjdwfUmXOa6p2m42Q0Oi4GagD3SSMp69ksOLUHuNf8jIp6pETEQII6XfMHOiqomLdeJNcPNoIL//pxohBi3MXoRy5NVtXZrxarMTGrzkgHdOoCARQnCe4qVqREhwokDFeKwVbZ+kADWtJdrN6iGsxFZ8Ro9rRVg2/lKH9HtomzA1bjYZIad8ljBurstZrPBzsckiH0vYUZOeug6L2yWxlZo1EMfFrLtdTqmghct0oSYjWYQhiEmiVgeg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(346002)(136003)(396003)(376002)(366004)(316002)(4326008)(8676002)(66476007)(6506007)(6486002)(478600001)(66556008)(41300700001)(66946007)(6916009)(8936002)(2906002)(5660300002)(31696002)(86362001)(31686004)(38100700002)(36756003)(186003)(2616005)(6512007)(26005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3Q1YWxYYjNEcENYQzJOanpMdWZodWdaY1FJNHdvK0ZkamV6NFN2ZlBHQms5?= =?utf-8?B?TlZzRk9RdkI1ZWVpdGY4Vm1sU0tRc29LQVZtZGo4b2pwdWFiNmpPT1dtNUhl?= =?utf-8?B?ZFFaOXpTWVAwa0I2N29ESHVaWjdyNndmMFBGaHZ5blRBdm9PQk9YT3hNcE1G?= =?utf-8?B?US9BMkMyZlBoOG4wNEsxMHBFVloyR2NDelA1YWZOOEo3Q0tJMzArbG1Va2tL?= =?utf-8?B?Zmw3MVZaUTZvbTRoNFdxc09EMm44dzhPU3pzZWkrakVPWm9zemptUThFZERa?= =?utf-8?B?RFFEbXIxVnZnUExOMjJCQlM2K05oaUpWYXkzRFFsQVZwcllUTTBpR3ArNGRi?= =?utf-8?B?UEMwWHlHWE1LY0pObEdRZ2R6Tm9jYnk5SGNIL1VYWk4zS0ZTSC9YREJBV2Yx?= =?utf-8?B?bk5SOTArajN0am9hVEhWbGlGVjdhYmluNENlU2dLWXdhVXl5Nk5iUFpnQ3lV?= =?utf-8?B?ajU4ZWE1dTQ0eHoxV2VRZ2xVSjdlVGQ3bVlmY2NrZkpSTWovZVhBeGd2ZHpK?= =?utf-8?B?NEU5QnZCN1JSZ2VRbEQyQ1l1YXVnQUJKd1REanBwVFU1bkZaUXFVWWFKOW5K?= =?utf-8?B?YVVqUElva0R3dWFPQ1dLTlcvMzRKRXlwTCt2cXdkSDNMbitoeHNucml2cmY0?= =?utf-8?B?WU9HNEIyNGtTaytnY1FXeEI1THI3Q0VIZXFRajZLYXdYR2FMbmNPSmQ3MEp0?= =?utf-8?B?VVZlVmtzakpNeEZydHdSVnpnQTlpaGorRWNSdE1idVlLR2xoWFZ4TjVJQXMz?= =?utf-8?B?RTBMNmpnTnZIa1FuTFdtY1ArclBCZjhRcm1PS1J5UXNSOVlaT3VtMWUwQlRh?= =?utf-8?B?RjI1LzRvL1JEZkRHRXFuNldUKzRNWmVJUy9jTTZMZTkwL1QvMDI4WGJLOTN5?= =?utf-8?B?dGhJMXpYSW1jcW05eTdlL0dNdSsrZFFJd3dkcFpDcHN4Y3BuYk90QkZ6T09p?= =?utf-8?B?Mmp0UFVLUkpVQnNIdHoxUzlkb1djZXlYNEd1NXpzeW54YVdyOEFoRk52Qk1Z?= =?utf-8?B?MlU0ZXZkb2xPS29HbWxxL0pUWTNYeUZRb3duQzFQS3huWmVmbkx3cmlsUk1q?= =?utf-8?B?TWJ6OTIvRDNIVVRiZVplMFpRc0dnZjNvWFlvamtkdml1VUxnZXlwMFVSNnUv?= =?utf-8?B?N1E2NXZJelh5SGhSdDQxT0NjdlEzU2Y4aHYzemJlY2RySU84MEJKK0s2NW8r?= =?utf-8?B?N3ZhWndMU0ZuZlg1WEw4aHl4QWFrMFdxVldKSERPNEJ5K2NuaFhPZUtKbnRy?= =?utf-8?B?cjR3b1BISFZpTFMzTDl4RVFWcm5Zc2Y2WFh2dStHMVBzQTdwRWpMYlFveGVx?= =?utf-8?B?bllWY3FQTzZPRURVZllpdGliNnBDM2t6Mi9LaEgrZ1RqM01ZVUQybVZud21X?= =?utf-8?B?Snh5VFZYNjE0VjZiWWRRSGl1eUJPQzRiWUw4aHYvQVVKdFBkenVrT1hpT3Nx?= =?utf-8?B?Q2hkSE84TDVybDRTTVplcHpIRGNGSnlMajFXODNMMHh0QzloRGtwd3RISWpT?= =?utf-8?B?dXF1cVk1U2llMFpmWlpOUTV6ZXdwd21JcHRWZ1VOdE1pLy8waFVKZTFBdEov?= =?utf-8?B?c0Vib0VWYi9iVFlUQTdGVmYzbFBlZkY5enNibFg1UCtlUUY5d2tRMFphb2Rm?= =?utf-8?B?TklwR3AvS2dpYkIwL0NHWVM0c0htbUYvYzNYeEVYZkc5N0MxU1d4U25WdTVL?= =?utf-8?B?Z1ZYQUNzTGpMUmU5QmlXa3hYM1I2YUx3NW1BRWpLM0tseUVUOUZ2TGFTUUc2?= =?utf-8?B?Sm1UVmhuYUo1NzhPYVRXZjNLMUx5YVZKTEsrOTVlY204NXNadWoraE8zRjdW?= =?utf-8?B?dmFqVGVzenJpRFNXUzdTREhZYi9LT2RmQTNYcjZEbHFITzVGYTJJamlNTU9p?= =?utf-8?B?ZGNvV1lkSGl2RTRLOXlSMXQ0UVVkTkNDWXhWN3JlbHpVS2Z2VFJOMVV6NEE1?= =?utf-8?B?bXRJcUwwK0pPckxPNEJrd2cwdWE2UmNMT0lXNVM0VTgrcXJHaUJzT2RkWjFW?= =?utf-8?B?RE9WNTFxeHBBeUtDaUsyeGpFSTltdWlCNzVDSG1TV3dNL0pHNnQwb0NEdjU4?= =?utf-8?B?SlFoaW5SbkRHWmZ1bzhBU2hueE52dGV5cFFHTlgzOXhjdTBaOVdBYkQ2cFJ0?= =?utf-8?Q?hX8XjdEq/Hw3UP0ff/bSwwhsa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a0662d8-2099-41d3-d093-08da5e5318e4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 06:53:42.0541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LGGP58VK8I/iDaBgVUuq3eGRwWycoddgjg7E94m5L7dIYvH19Y9Cmc78IES5W6j57s3ijV3dlEId0ez9zVuP0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2356 X-Spam-Status: No, score=-3030.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2022 06:53:45 -0000 I don't see why two of them were introduced (very long ago) using similar fall-through logic. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -6763,22 +6763,7 @@ match_template (char mnem_suffix) switch (t->operands) { case 5: - overlap4 = operand_type_and (i.types[4], - operand_types[4]); - /* Fall through. */ - case 4: - overlap3 = operand_type_and (i.types[3], - operand_types[3]); - /* Fall through. */ - case 3: - overlap2 = operand_type_and (i.types[2], - operand_types[2]); - break; - } - - switch (t->operands) - { - case 5: + overlap4 = operand_type_and (i.types[4], operand_types[4]); if (!operand_type_match (overlap4, i.types[4]) || !operand_type_register_match (i.types[3], operand_types[3], @@ -6787,6 +6772,7 @@ match_template (char mnem_suffix) continue; /* Fall through. */ case 4: + overlap3 = operand_type_and (i.types[3], operand_types[3]); if (!operand_type_match (overlap3, i.types[3]) || ((check_register & 0xa) == 0xa && !operand_type_register_match (i.types[1], @@ -6801,6 +6787,7 @@ match_template (char mnem_suffix) continue; /* Fall through. */ case 3: + overlap2 = operand_type_and (i.types[2], operand_types[2]); if (!operand_type_match (overlap2, i.types[2]) || ((check_register & 5) == 5 && !operand_type_register_match (i.types[0],