From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 914963858408 for ; Mon, 27 Sep 2021 17:17:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 914963858408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 505177D01E; Mon, 27 Sep 2021 17:17:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HJ8Sw1WDLz4QlN; Mon, 27 Sep 2021 17:17:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id C05FD4717; Mon, 27 Sep 2021 17:17:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH] Add support to readelf for reading OpenBSD ELF core notes. To: Frederic Cambus , binutils@sourceware.org References: From: John Baldwin Message-ID: <3a221d66-5dc8-40ea-bb16-9589a730ce88@FreeBSD.org> Date: Mon, 27 Sep 2021 10:17:02 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2021 17:17:05 -0000 On 9/27/21 3:24 AM, Frederic Cambus wrote: > On Sat, Sep 11, 2021 at 11:30:22PM +0200, Frederic Cambus wrote: >> binutils/ChangeLog: >> >> 2021-09-11 Frederic Cambus >> >> * readelf.c (get_openbsd_elfcore_note_type): New function. >> (process_note): Add support for OpenBSD core notes. > > Friendly ping. Anyone willing to have a look at this? Thanks. I think this looks fine, but I am not an approver for binutils. I noticed that there are also #define's for NT_OPENBSD_XFPREGS (presumably for SSE regs on i386?) and NT_OPENBSD_IDENT. Did you want to handle those as well? (That is, does modern OpenBSD generate those?) The first one is probably a simple change to your existing patch. NT_OPENBSD_IDENT might be more involved if it is similar to NT_NETBSD_IDENT. -- John Baldwin