From: Ulf Samuelsson <binutils@emagii.com>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH v4 0/5] Add support for CRC64 generation in linker
Date: Tue, 21 Feb 2023 14:30:21 +0100 [thread overview]
Message-ID: <3ab0da79-b284-fcd6-26d1-ff5c96ddadf7@emagii.com> (raw)
In-Reply-To: <fa127236-f02e-631d-23eb-71aaabd68cd6@redhat.com>
>
> I am going to post some individual reviews of the patches as well, but I
> wanted to give my overall impressions here.
>
> Cheers
> Nick
>
> [1] Well except for TIMESTAMP and DEBUG ON/OFF which are valid new
> features in their own rights.
>
One issue with the TIMESTAMP is of course that the output changes
the timestamp value every time you link the code.
You cannot do a static compare on the result.
One way to test it is to build it twice, extract the timestamp value of both
and check that is has increased with a reasonable amount.
Best Regards
Ulf Samuelsson
next prev parent reply other threads:[~2023-02-21 13:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 19:45 [PATCH v4 0/5 " binutils
2023-02-19 19:45 ` [PATCH v4 1/5] CRC64 commands documentation binutils
2023-02-19 19:50 ` [PATCH v4 0/5] Add support for CRC64 generation in linker Ulf Samuelsson
2023-02-21 12:02 ` Nick Clifton
2023-02-21 13:10 ` Ulf Samuelsson
2023-02-21 13:30 ` Ulf Samuelsson [this message]
2023-02-21 12:53 ` [PATCH v4 1/5] CRC64 commands documentation Nick Clifton
2023-02-21 13:24 ` Ulf Samuelsson
2023-02-19 19:45 ` [PATCH v4 2/5] CRC64 testsuite binutils
2023-02-21 12:42 ` Nick Clifton
2023-02-21 15:13 ` Ulf Samuelsson
2023-02-23 10:10 ` Nick Clifton
2023-02-23 10:53 ` Ulf Samuelsson
2023-02-23 11:01 ` Nick Clifton
2023-02-28 11:11 ` Ulf Samuelsson
2023-02-28 12:37 ` Nick Clifton
2023-02-28 13:01 ` Ulf Samuelsson
2023-02-28 13:06 ` Nick Clifton
2023-02-28 14:24 ` Ulf Samuelsson
2023-02-28 13:45 ` Ulf Samuelsson
2023-02-19 19:45 ` [PATCH v4 3/5] ldlex.l: CRC64 binutils
2023-02-19 19:45 ` [PATCH v4 4/5] ldgram.y: CRC64 binutils
2023-02-19 19:45 ` [PATCH v4 5/5] Calculate CRC64 over the .text area binutils
2023-02-21 13:26 ` Nick Clifton
2023-02-23 8:36 ` Ulf Samuelsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ab0da79-b284-fcd6-26d1-ff5c96ddadf7@emagii.com \
--to=binutils@emagii.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).