From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2054.outbound.protection.outlook.com [40.107.7.54]) by sourceware.org (Postfix) with ESMTPS id 601EE3858C2D for ; Mon, 27 Nov 2023 14:07:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 601EE3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 601EE3858C2D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.54 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701094023; cv=pass; b=Sf/GoTk/QEeNT/O3QGenZ0nTLal36iEUoO9AM0QOttIcBy8oLX+D6Em63d12k6RfR9R1Ko0781r4nrr6GqGVYYoWxk10jPgm3cbD8xAg802Xno+PN+9fufjTm6A/NVeyZIVV3PFrD91q/wZwo2C6ie1dzMC+ICcPYfrCRAkXQAs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701094023; c=relaxed/simple; bh=L4ptsenLJ4sVp6hjqgKysQ2hHNkv8RoB4Hd3jfp7j9M=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=lW4Tg0LH05IV79q7GyY3EA6+5zwQn4JaoNfOhhlHif1gOGo7q9NR6BGyXMzt50Y+WcIAOWCusV1ov+Of+nRMF398xg4gDFZWq1GFyxSJV+dfjCvCFlD60nAfqc92B1l4S2CwQZ823zzuGhzvSmluyqVjismQ4H/XhdT4wif6ua4= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AIrWFVkwCPKn0Dxvls4zU3IOJhbABoygTQ31YPzg3UWe9ojYH3ed/y6oDQR+33Zcm7AQRS+Q9FcFDNPQ0QA+54Ouy4yJ/uTzqVpkq3Mi90GJcN7UIlhKCT8poEB4VweJFHpXdGZ9IUvX6/O5/PU60ZPPzoR97V3C2NkDRQ7tsIAtgg1HnC5ZRRCCPudzJoHmsIWoAqSODhcvghE+vTteDz26BSbPDy/ZdZ2gssyXQBkbB37dwMIAtSUkcKtw7ZvBRURvSHGL6VTuXcMxfKKmxjoT23exwI2vpVR9AENAkWcFk2P7/fUajz/z6GhAxaEX9R2tUVeLrYpjkWDhZqgx/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qDfVZbZgKoab9TQE0qCZNgfiCIGWTBPcumfjovnl+zw=; b=Ckr4WfWF2K7MLko4uJu18TZIrJbzqcqXjrKMFR8cOYRGCXw7PL3poGk18FmR5h3fWUY7wlw1i6n1SqsfoFWBbCZyxR09X7zA9DzxXgRKwA4NQ2t3YJrIho8u3Fjtwv1ZpcQASw2KClQZdXKJuGs75zbCGAtP4ANX0Ok/PKKVfhx6imbZygNUNUqa08XPtlJJgYlBo3oL4Rlj9ONSJba7XPV4cxt405rCYCf/ldnILksZ6mR5wdu+L/scBBDk291sMXNsO/iAxRt/agh8uya05zD/jOu0nEz9zjFa0ax1Z0VKMcoPiwa4UnxtoIZ/bRsHqQGz2VKtB3t42CBU5Fh7zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qDfVZbZgKoab9TQE0qCZNgfiCIGWTBPcumfjovnl+zw=; b=Ma2A+Vtar7U66o7jzWhpXjx+LQGDdsaqBCeQAjKDYH0Lab8ZJQDFFl57uV3T09i76jMmWbBZnv5TAO7pRxQ0noVunEi/rLWZvGgw+KXdMuH5Q5SxQYDZHgwIYTiopUlhdL6/4uxjFg7OlDsFttmskBENGKpddkSS/lpviTQR9kuTQkjv65LwsMk/g2KzZjcGJeIU2kfNg/9Qg25p08HtYlZF4/KXd447r//KRYTfn8oz09C3Xx4Q9XHCVThvMfsZ6yfG6GWemRLUnx79LufxUIDF6PdrwFEheU3Mo2VQI0KzMXQuQiFuYKbGsxn9DsNcc4O4rpiHaTK/p/fJuQTraA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS4PR04MB9244.eurprd04.prod.outlook.com (2603:10a6:20b:4e3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.19; Mon, 27 Nov 2023 14:06:57 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.015; Mon, 27 Nov 2023 14:06:57 +0000 Message-ID: <3abc4b98-59ab-48b4-8690-99d00e55ad1f@suse.com> Date: Mon, 27 Nov 2023 15:06:55 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Support APX PUSHP/POPP Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "ccoutant@gmail.com" , "binutils@sourceware.org" References: <20231127123106.3600817-1-lili.cui@intel.com> <4f005f5c-52c4-4631-bee7-6396add7c5df@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS4PR04MB9244:EE_ X-MS-Office365-Filtering-Correlation-Id: fb93cfba-0645-46c1-a7dd-08dbef521e14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X1noa/rIS4AUHV22oLWbQWpWojQNCzf+sra6Ay9yEGwI+soKNZv5S8PErT8+xDPgvALVwlJjh13GISxl+lewPLxqK8Wy2dPSN8f5+M9Mcf/v9OGxfFz4s2RLtnAdMFXKgbq8qdZcsfxyK1ofri34slYoOBHVmRqh6tiC8pcJcJti9yyH3nhwY05vwcZhcGpOfvhGRAQaxlLW1HBeF3xrJybHd87f6a2xctl2XqLbLDSJW/tG7rCV6UUbYukJ6jDbjEdhpekGlMV3KeS7uegdEzi0LGyRLDOSNmsm0vj1yqusBOLqL26oMyLiU1c1ltAR0ZAUYFZlLhejEwTvA7ny3alTNRFKaehg9kM1KBqWtFpHIn4Ec3kyEBcqqoB/bQqSSCrDtlCAe600oX6H1Vm1IMZ91mBOZVX9IgTbZgxUCFv2kNwDkkxEsblSl4uqZvy43Z3R/u2A1Om12iiXyQbaLgnYQJBvKq/G3ws55WeOkeFLAWFNZuBoS5sb0X3vfMbyyZWDZZsNnDg+ZZoaZrRCHd2a7J08UeifqV0WzhCBE+RDNDoEfmatsGdtK8ycJ084a9JAisHZRTEr7Gr0XduRS6boWNjgMeh7+VvGgJJef1IvS8UkWwb6TdB80JGzuoFF+OBK8euIUiWEQGKSCw9gDg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(366004)(346002)(39860400002)(136003)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(31686004)(26005)(6486002)(2616005)(6506007)(53546011)(478600001)(6512007)(38100700002)(86362001)(36756003)(31696002)(5660300002)(41300700001)(2906002)(66946007)(83380400001)(66556008)(54906003)(4326008)(316002)(6916009)(66476007)(8936002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmRVY0FLL1lXSGRQOVE5bGdvc0NHY2NCK3EyWXpWSVhkM3RmR1NOZlUrRWpS?= =?utf-8?B?dmhqSmRrbDdyNWVUUWF3aWJybU85bE5kVWFpb0I4aDhCelNFSFNhNHVVMW1l?= =?utf-8?B?TFZqSVRWQTJTcGZibG9zTTZVazlBbkxieU1pTUUxdEY0Z3BPY3MrMnU5N3ZI?= =?utf-8?B?UURFV3hYbFBzK0E4bmZLVkk4WVNvK3lOVFc4bUhWSGx6YkkzQ1VVb2E4akI0?= =?utf-8?B?UjJNSUw4WEtIakc0RStLY2NISnQyaHJLZHRZQjRLbUtBUDM0UjA5aTR6UmF4?= =?utf-8?B?M0ZMMUJQRk1za2lhaklkcU1iQ093V3lvN3NJdVJNdkxXSnhTN1owaHFaN29V?= =?utf-8?B?L1doSzAyNUI5SWhwTDFXanl6amwrL1NtL2lQcUdqZmVBZjRPRzM3bVQwb3p5?= =?utf-8?B?WDFVcUxCWnZpMXIyaWRXVmhnWWhjMHR2bnRxa3ZoUUNGQjNUZVFQZERZL3R1?= =?utf-8?B?ZEkwaUl2bjkya3FxTWJuMWxwOU1QenJXcmZXS0RURGhyb3R6SDBlZEk4ZE5N?= =?utf-8?B?SExMVTdVNjFNQ3BJYVU5Sm5wTTZIQkxmS0Q2MWtpUTE3OGhENUlMMC9zZHhC?= =?utf-8?B?RU5UZDV2a0FyNnJmd09GMldhZUJLLzhuVmtHNFBINE9zQXltbjhSUXdETm02?= =?utf-8?B?cGp6NmxlWGRnazc1ZmkyQVFpSVZkV0RyY29xbVhnNnk4RzYrZis1UlljSGpL?= =?utf-8?B?N2R1emJQYkxMM2F1R01MVFpKZzRwNU12NVVaQVhyNFZ6U3FXdWZySnkzSHZC?= =?utf-8?B?eUZCSk5pMWhtNmQxMlZCbUtiRnArbUYvQjB5d0ZHLzVJOEFFMUFMT3FMc0JQ?= =?utf-8?B?UWNTZCtJSlpHR1BKRTk3Wm5HdjZjR1ZqaDFiRWtXbFdqWWlmTER1dGRHWUJ6?= =?utf-8?B?dktvMHhscXA2VHNTYzgyTVZxelIzUTY3RVdJOE1kaVRhbGJYN3gwVlhyRkd5?= =?utf-8?B?QW5yQ3F4dVdxNmJCaStBV0RFS1UrLzE5ZVZCaVAwK2JvbWV2SlZwZW5Iaysy?= =?utf-8?B?U0djUXZHc3hQdmU2ck9WTEI4bWQ4ZkozZ0pyWnVtM0lWbWI1dFdDS0hNR0ZU?= =?utf-8?B?aTJucnk1RGV6RXRIM3MvVGlGY1RrN24wNWJpM2xEWFhkWmZkS2I3UHVSTmJs?= =?utf-8?B?d1FZZHQ3SmNYcXlSRUw1b2JxdUJpU1U4cjl4ZnFrckx6QmxCSWFKWkZwWDRH?= =?utf-8?B?QWpOcTNYNlVKd3JNdWFNQUhHUjJRQi9YUC9PRFBESWs5cUxJS1k3TkI3Z0FE?= =?utf-8?B?STIxemlLRExlMVpxbmI4amZ6WWdrL0FUNFZOcEd6RlA1bVBidGZFRnZvVkpo?= =?utf-8?B?SXJTZURHcllkd05jU3BQWnhGcExWWElXZTV5aE9zZ004WDVUeUJYTyttdVFu?= =?utf-8?B?WnF4L282cmE2cEd4NVhsQlNLZ1Qza240U0hEdE5jYWl6WTFDY0E2QXFSbHpo?= =?utf-8?B?a3JNSnh5V1lUVnVtRkltZGUvSUxwclA0Y0tMV2IwbTJHL2VZN1ZQSkNYT0R2?= =?utf-8?B?V3ZIV3dNeTFvbGFSbkhvRkhTUi85a3pxQlk0L003NUxXMjN6ZW9ET3Fmejht?= =?utf-8?B?blBFMGxwOC9FYjl2REcvRDh5VmVudC9pWjhwYUdCQVFwS2VBbkxEQ1NwOWgw?= =?utf-8?B?ZEtUb1ZhMGROQlRnR3VWdjNtOFdaVUdPMWxjRVZ2QXdvREVNWndmN0FGUzJs?= =?utf-8?B?VlRiVnEyaTVkcnhTZmNxelNoKzlXRmRsQ1JkSVQva09hRlFzZUZONkN3cFRy?= =?utf-8?B?Zkg4MXluSEJvR2NqanFtbDFJNElJT1ljUUQ3RzdOZTdsSkVtQ1Zmd2VTUm93?= =?utf-8?B?ellXa0dxZnBWNmI3OHVGbVFFL1RCaXdxaUp3VWNDek1idGZZZS9wVE8wUlN4?= =?utf-8?B?MSttUUc1QU0rcktJQm10d0EwWGc2c2NPcjZwOEVuRXFEUzQ0UXUxOS9XMWFl?= =?utf-8?B?NGVIb0V2ZHFVTXVkMjlXTFl5bWdqNWYwbjRXR1lSMzJlblpTdS9sZFNLbUgr?= =?utf-8?B?cEJUMWhLK3JUdXdFR1ptdjVlazBRM1J0M3M2OC8zOHlXQ1hreno5SjZtUmsv?= =?utf-8?B?YmdrZmhFSmk1QU1kRURtTFdDTlB2LytDbWdpdUVUSFpLOU9aVFEwZlJxek0v?= =?utf-8?Q?wtcyoDzW+96OQXkYO+pm30vmT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb93cfba-0645-46c1-a7dd-08dbef521e14 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 14:06:57.5684 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rOQr85hqtobhTrH2IO202FKQ74mWGTi/MmV1UZjdsY4AJADeTbiUhg2ZBcf4lUZjS0TqBRgZyNnKgrv3gwPabQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9244 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.11.2023 14:45, Cui, Lili wrote: >> On 27.11.2023 13:31, Cui, Lili wrote: >>> --- a/opcodes/i386-dis.c >>> +++ b/opcodes/i386-dis.c >>> @@ -1931,23 +1931,23 @@ static const struct dis386 dis386[] = { >>> { "dec{S|}", { RMeSI }, 0 }, >>> { "dec{S|}", { RMeDI }, 0 }, >>> /* 50 */ >>> - { "push{!P|}", { RMrAX }, 0 }, >>> - { "push{!P|}", { RMrCX }, 0 }, >>> - { "push{!P|}", { RMrDX }, 0 }, >>> - { "push{!P|}", { RMrBX }, 0 }, >>> - { "push{!P|}", { RMrSP }, 0 }, >>> - { "push{!P|}", { RMrBP }, 0 }, >>> - { "push{!P|}", { RMrSI }, 0 }, >>> - { "push{!P|}", { RMrDI }, 0 }, >>> + { "push!P", { RMrAX }, 0 }, >>> + { "push!P", { RMrCX }, 0 }, >>> + { "push!P", { RMrDX }, 0 }, >>> + { "push!P", { RMrBX }, 0 }, >>> + { "push!P", { RMrSP }, 0 }, >>> + { "push!P", { RMrBP }, 0 }, >>> + { "push!P", { RMrSI }, 0 }, >>> + { "push!P", { RMrDI }, 0 }, >>> /* 58 */ >>> - { "pop{!P|}", { RMrAX }, 0 }, >>> - { "pop{!P|}", { RMrCX }, 0 }, >>> - { "pop{!P|}", { RMrDX }, 0 }, >>> - { "pop{!P|}", { RMrBX }, 0 }, >>> - { "pop{!P|}", { RMrSP }, 0 }, >>> - { "pop{!P|}", { RMrBP }, 0 }, >>> - { "pop{!P|}", { RMrSI }, 0 }, >>> - { "pop{!P|}", { RMrDI }, 0 }, >>> + { "pop!P", { RMrAX }, 0 }, >>> + { "pop!P", { RMrCX }, 0 }, >>> + { "pop!P", { RMrDX }, 0 }, >>> + { "pop!P", { RMrBX }, 0 }, >>> + { "pop!P", { RMrSP }, 0 }, >>> + { "pop!P", { RMrBP }, 0 }, >>> + { "pop!P", { RMrSI }, 0 }, >>> + { "pop!P", { RMrDI }, 0 }, >>> /* 60 */ >>> { X86_64_TABLE (X86_64_60) }, >>> { X86_64_TABLE (X86_64_61) }, >>> @@ -10621,6 +10621,19 @@ putop (instr_info *ins, const char >> *in_template, int sizeflag) >>> case 'P': >>> if (l == 0) >>> { >>> + /* For pushp and popp, do not print {rex2} for them. */ >>> + if (ins->address_mode == mode_64bit && !cond >> >> I don't think the mode_64bit check is needed here, as without that REX.W >> cannot possibly be set (nor can a REX2 prefix be present). > > Done. > >> >>> + && ins->last_rex2_prefix >= 0 && (ins->rex & REX_W)) >>> + { >>> + *ins->obufp++ = 'p'; >>> + ins->rex2 |= 16; >> >> Please no new use of magic constants. Have a #define with a suitable name, >> and use that here. Also I think the comment you have ahead of the if() actually >> belongs here? >> > > How about " #define IMPLICIT_REX2 16", PUSHP/POPP can share it with JMPABS. But what's implicit about the REX2 prefix here? >>> + break; >>> + } >>> + >>> + /* If "!p" printis nothing in intel_syntax. */ >>> + if (!cond && ins->intel_syntax) >>> + break; >> >> The comment isn't quite right ('p' is printed). Also (nit) "prints". >> > > Added "!cond" here, since just removed {} for !p, I think P has its way of handling intel_syntax. All fine. Yet still the comment should reflect reality. >>> --- a/opcodes/i386-opc.tbl >>> +++ b/opcodes/i386-opc.tbl >>> @@ -225,6 +225,7 @@ push, 0x68, i186&No64, >>> DefaultSize|No_bSuf|No_sSuf|No_qSuf, { Imm16|Imm32 } push, 0x6, >> No64, >>> DefaultSize|No_bSuf|No_sSuf|No_qSuf, { SReg } // In 64bit mode, the >> operand size is implicitly 64bit. >>> push, 0x50, x64, No_bSuf|No_lSuf|No_sSuf|NoRex64, { Reg16|Reg64 } >>> +pushp, 0x50, APX_F, No_bSuf|No_lSuf|No_sSuf|Rex2, {Reg64 } >> >> Since Reg16 isn't allowed, you also want No_wSuf here (and below). Note also >> the missing blank after the opening figure brace. >> > > Done. > >> The new Rex2 attribute is not only wasteful (it can easily be a new enumerator >> used with OperandConstraint), but also misleading. We don't just need REX2 >> here, but we need it with REX2.W set. Even if from the tc-i386.c changes it >> looks as if that was happening implicitly (presumably due to the absence of >> NoRex64), naming still needs to properly reflect the purpose. >> > > You are right, rex2.w is set in process_suffix, since there is no NoRex64. > > How about Rex2W? > if (i.tm.opcode_modifier.rex2w) > { > i.rex2_encoding = true; > i.rex |= REX_W; // add NoRex64 back, and set REX_W here. > } > > > Or just add a special judgment? > > if (t->mnem_off == MN_pushp || t->mnem_off == MN_popp) > { > i.rex2_encoding = true; > i.rex |= REX_W; // add NoRex64 back, and set REX_W here. > } I'd prefer the latter over a new attribute (albeit once again with the comment actually matching code), and perhaps I view the latter equal to my earlier suggestion. > By the way, Is our APX patches (V3) review still in progress? Since we have to commit them into the trunk before the next release, time is a bit tight ( many people may have vacation plans at the end of the year). Hmm, not exactly sure what to say. You posted v3 only on Friday. Plus I have spent an enormous amount of time reviewing v1 and v2. Please be patient, I have this queued for another round of review. And no, there is no "we have to ... before the next release". You (Intel) may want to, but with a large new feature like this it had to be clear that getting all pieces in will take time. Jan