From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2085.outbound.protection.outlook.com [40.107.21.85]) by sourceware.org (Postfix) with ESMTPS id B43373858D20 for ; Mon, 27 Feb 2023 09:13:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B43373858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CIlct87ALtQCZBZd1Xh7halZL6KQJCKQnw+n0BcgzsgB2dHW5sK8AUUkw1+6R/FkGg4HfkRi2q2xS7g2TxfTq++IaC/I1YyYyiWeeGiOy8d86W+Wq4S2wN8ULADzS7JxZ7PcFReHemfDWzfidYBI4Y7zetWgteOq3X1PBK4/1XrBGZ1lXPBVgRfpRxHT1SvIqLJB9bs3bYySKLTXglJ+BsWKMZQOJ+NHTpOiLaYY/oowFUCKtvXQHGCzvT8C7sl13Dvg/a+FWAGcueFHN1F1amzS7zgTKx1ZGvq1QQbGNZ/l0LXIdXt3EIKT9d+m98O9gEGzOnlqmuPaJ7gHWDXwrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gn0xOQCpDuDI/LMZ3/oMprfFrpl6Yi28ejeSGQoQ6Pg=; b=EIGgIyQ9p2oKoxGEzeHf/xzxRf9U1n1bYmxdUm077J666YvWHss+myMZU8O0Hpg2DIMLHY0dLKfW3E0z7EqpJEWI+WkqpVSVCa6qW8krnwDevxhv+vdiSM/sbfBQT+NF+wu1QjXFqNLRc3pJYfhB5uHC0eU6Ui54XVqW0n4yvj+eLs6c+CQyfAfmG3G0BKGSIFqvt+bk93+xz1wxS+caQKeqxLZRhL0Ihl9lh/tgYekmZUAmaIM+E65j1LILnVejwZ2ECbXZAVdi/tOlnaHwL6KbJMbVrmJLCAKh0B2dTOZfZ8n4WV3U7CY3aWCv++FlpHKeRi0C63lBGhxE44n/4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gn0xOQCpDuDI/LMZ3/oMprfFrpl6Yi28ejeSGQoQ6Pg=; b=iHqRoileBV0FitFkQOvzvtrPc72BBsZLnV3HWFPUnJ2WedGt+7oKpcyb9qXRgPMcEeP4r9cihTL2c3O3pfOc0Wk0IhEsk1jTUdRsTDMHUF3tCJ1RH//aUTkHhLimez+RMEbPHURVysRhmZ1u2EGpSENw7Vwt4ijlUNfeTu4gtSQOiBSKtOhcSLJYQ3VrfQJLsndRPw487Rx5ETr2Sdz9ixExG/WiUMa+cYIzAXXNbvLRm8oD2RjP4sZI4hoSawlmU/FpJDibqGsdWmGCmvBN24qmT3XFr5RjuZ/9pbu6vmkVg+Hexg6oQKEIhoZ7l6rxYYlrlTwladjKlL2O4GEQPg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8940.eurprd04.prod.outlook.com (2603:10a6:20b:40b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 09:13:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 09:13:53 +0000 Message-ID: <3aeaf40a-f59c-32be-9fad-1efc18ce6bcb@suse.com> Date: Mon, 27 Feb 2023 10:13:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] ld: Sort section contributions in PDB files Content-Language: en-US To: Mark Harmstone References: <20230227005935.12270-1-mark@harmstone.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20230227005935.12270-1-mark@harmstone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8940:EE_ X-MS-Office365-Filtering-Correlation-Id: c607cdcf-9580-4e0a-6879-08db18a2f284 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SqwlZlJYkyQPIO396rqBGy/eTfxUu06507QJd08tWTZvUcbWWih8VQXLe8TwzglsInWTZuMeoDWCXp5UhHsa0VVCvr17TvS/cNt96tXuSNYH14oRn+DemeInXxtjSzFRWOYScOXB9EwNxSTn+4xtAnq+RopgWoiINuJVQ6ANew/sLJZTRJzcBNsMAw/cU0C03eXLh+PMVAg5X+wI5rhxm59CAfACCQ4XF/CQbdTBu7tE1r73CE+Fh7WbaX0ozDyB5BTegW6Pgj7NYwT0eZN/c2QXUBYFlRNZosQYKpUtbw8IzW245OhdJ6uJ+5nevwP66EVTiPvjWV+wCq3vUuKqCR5FcyiGb3nuXpO4/7QLWfAQkp5+rpOohWc7mmXPy6HO6pmuUAH43zSz6qR/rn5izGILAXTGnQpy+k9pA9SZlSFD6jJq48QyJEFIvWrVfWKsT+iW8nCVjLPIpVR5nS8kPtAFk3Mwtf59TDftWIIXQ+215EId6H2EkwrtHMNqIl44afQGuTKDDKBxrpQxm7gL+DqVGCuijPpVS//KCD4sr1N7zpr1wAqEa/K6JAoCqYd0XdXfLH7U4WnscqWAcaOFDnMn0RhysSpc954iP/Bn3NTxM3GvlUEP5Y8pl3iDTpMOa5WdyM6cqTAyYabv7e4sryAmppU1r3Mn0TX/mm5pGhx8MEbbb0LLUd2bhBkH2FZQsD6PWCBoiPLmKxgVNQvl187aM+TwLgvsbqr6HBfOdTg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(376002)(136003)(39860400002)(346002)(451199018)(2906002)(31686004)(316002)(478600001)(83380400001)(36756003)(5660300002)(86362001)(8936002)(31696002)(8676002)(4326008)(6916009)(66946007)(66476007)(66556008)(38100700002)(41300700001)(2616005)(6512007)(6506007)(186003)(26005)(53546011)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b09IQ1V1UENWZStZQkJ2VURlS0FiRTVUaGhOVWlYTFhGRHdEYk52eEFncHY0?= =?utf-8?B?WjhEWEE1WGtjZXJzZHc2TloxZHgxS3RKR1VGUXBvaGlVQ1Z5VWFxMzFxSml4?= =?utf-8?B?bTdZbFR5TE5tdE83Q3ZxV2xDc2tsdm9XUTBmR252T1Zjbmw4Y1Q1VGNhQ0pm?= =?utf-8?B?QjF3a2Vlakk2dG1VZXoxR0F5S1BRT21WSThqUFJkb3ZERmx2dng1NEkrQ2F2?= =?utf-8?B?NzUvVEQ5TzlpTW85RFVEMWFUUi9aVU82RkJhN1JLNHBUeU9EQkpDTVVBa2cw?= =?utf-8?B?Ykg1UldqZSt2bHZWemg2VlVueFozQUtXZk5XQ1RjVkZTVitrOXNsTnlwLzl1?= =?utf-8?B?QzU0QWpCekE5M0ZZUWg2dzZuZkp3RjdhaFZ5MCtNUkFqb3JuYzZaRHdqZkI3?= =?utf-8?B?RnBPdHFwZjhOVktSQWhaZUtnVEovTHpGZzZUZWY0QmlQb1BPaVdXeUR5SktJ?= =?utf-8?B?MzVqVjZTR2RCUkxOQ3hxQTVCbC94cEdZeGtOSzgrYy9uYnpVblk2MHN1cDhS?= =?utf-8?B?N1BHNU1pcEpnem84YnlFNjZacUhOL1NTa0JDb21aSTBlMnN3a0xOMFpIV0xw?= =?utf-8?B?aVZwMlpSVHg0VHlGaXJvSGlVS0FLWnk2QmEwM01YOVF2a3BRNnM2ZWo4MXFl?= =?utf-8?B?cEVTQ0ozOCtma0xSdkdaQlYrV2lTRS9Ld1dmNGFsUTA4SW8zU2xDT3Q5K2tK?= =?utf-8?B?bWlnTEFnZmNrY1pvSzh6aGl1SXVXdDZjdXgzNHpENWw3Yi9pSk9jWlE2emh0?= =?utf-8?B?S1dja3RlL1Jxck1nVDQ2L2RMblBZVzFrUFZ3MkR6Mm5yMjNCdWZNRnB1VDkv?= =?utf-8?B?dXA0MldsWXBTN2JIRDloWnhhN0Q1aVZBcHEwUjlCQU5QSjMzc2J3MWRNWW5F?= =?utf-8?B?MEgvakwvY3VqNi9OM1NwZ3Q1ODU5V1B5b1l0b0RMdXhZTVNBdm9PRTVaNU9Y?= =?utf-8?B?Slp0Q2x3OXd0VXFPbHdWZGtVS0lTa0ltUDAwZTFFWkF6S3VOTStDSUFGZE1p?= =?utf-8?B?SlpYRjFPM1BMeHYvY3h6eVJKV3ZMbFJmd0VqSE1LQWFGUW1TMzZLSTdSaDFC?= =?utf-8?B?bG9WL3FUbEZaTVU4di9FUlA5c1NUOVBrTzdTK3lSU3FtUGtqQitQaGpidW8w?= =?utf-8?B?NXVrNEZHWUNNdFA3dktTWWh2ajF3ckswNWYzNHl0Z1lJVHB0YU0rZkNhc1R0?= =?utf-8?B?NFlXZ0F5TFdsUnU4QklzR0U4dGVlV3Q4OHkvczZHTjBHUjF3QW5ZTC9RSkZt?= =?utf-8?B?OVZ4ZUQ1ellhUXdaRklyM1BvUFhmdFhOeTB2Y2piNVdveHE3amhvQzV1ZExD?= =?utf-8?B?NnA3VHdOYTlGTE1PaGtOdlRNVEMyRWN1Z0liTWdpeWRoWGIxNTdjN09yV1JT?= =?utf-8?B?M1lleDY2c094L2o1a0FjRjVaWVRwUUN0YzhBY3lPalVxV2FvRlRpZ0dxUkR3?= =?utf-8?B?cHRMV0JnSEFCQUZZTGxGV2VocGNoSGJoTUVFdzgrTFUzNURsSHNmcGJic2Yw?= =?utf-8?B?QWRpUWNuREppVkRjT2h1YXpoNXdiRkZCYjd1OFZzZXJrT2ZacnFka0lLY3Jx?= =?utf-8?B?VWQvbnp6T2Jqby9TUnVJcXRZd3RuRy96YTdhQVhhZDJEUUR3RThLUnpxeitM?= =?utf-8?B?WVppaWxJL2xHZzczY0U0dTRrZzJsTHNvbG5JbzZtTHFjVlJXZVZ3WU9ocnJB?= =?utf-8?B?NDBRSEJ1SGp3ZEozUElENTUyTFB1Nm1xb0lDU3VyNER2MzJJbmliVlpuVnV6?= =?utf-8?B?RFIvbThpd3lzWCt2YjhyOGgrNmo5QWNsYXFvSFFiakdTcHhOOGlYaG1naTZl?= =?utf-8?B?TVhWUnVpQWwvbm5RZ2Z2SUhZdHY5S29TdkFiSkxSMmxmQytZMFBCNDlSSzZ5?= =?utf-8?B?Wi9la05qdnQ4cVN5QUMrWkRYVmoxMUJVVmRzTW1HUW0xMkxNNjJscGxZeUpI?= =?utf-8?B?VTlEenRVSjlJTXlManprZzJCemhROVNaUlVZRjdYVWNMa1RlNjF4dU1PQzFY?= =?utf-8?B?VUM3Z2U4TjFscm1sU3ZYUEpvNDY2NHBZREhEU3VEdHZRbzYzaTc3QTlRZkxl?= =?utf-8?B?WmdZSHNCc0NRRXZQQUd1anh5NGlqRUljTXhKaUVid2ZvNTV0SS84TUZwQklv?= =?utf-8?Q?/H/v/JJe+p0Is3rtzEQC9IviC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c607cdcf-9580-4e0a-6879-08db18a2f284 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 09:13:53.6995 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h2VvkGZmz2dvqt3VF1Qrg0c8b80zli+XBPmdryLecreJUfjeGqQdEaAF41MkYUiMWmvzwGVnPbRVVzdzQt4RAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8940 X-Spam-Status: No, score=-3027.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.02.2023 01:59, Mark Harmstone wrote: > @@ -4177,32 +4210,43 @@ create_section_contrib_substream (bfd *abfd, void **data, uint32_t *size) > { > for (asection *s = in->sections; s; s = s->next) > { > - uint16_t sect_num; > - > if (s->size == 0 || discarded_section (s)) > continue; > > - sect_num = find_section_number (abfd, s->output_section); > - > - memcpy (&sc->characteristics, > - sect_flags + ((sect_num - 1) * sizeof (uint32_t)), > - sizeof (uint32_t)); > - > - bfd_putl16 (sect_num, &sc->section); > - bfd_putl16 (0, &sc->padding1); > - bfd_putl32 (s->output_offset, &sc->offset); > - bfd_putl32 (s->size, &sc->size); > - bfd_putl16 (mod_index, &sc->module_index); > - bfd_putl16 (0, &sc->padding2); > - bfd_putl32 (0, &sc->data_crc); > - bfd_putl32 (0, &sc->reloc_crc); > + sc2->s = s; > + sc2->sect_num = find_section_number (abfd, s->output_section); > + sc2->mod_index = mod_index; > > - sc++; > + sc2++; > } > > mod_index++; > } > > + qsort (sc_in, num_sc, sizeof (struct in_sc), section_contribs_compare); You want to apply Nick's requested change here as well, changing sizeof (struct in_sc) to sizeof (* sc_in). Okay with that adjustment, assuming ... > + ptr = *data; > + sc = (struct section_contribution *) (ptr + 1); /* Skip the version word. */ ... you did at least consider Nick's remark regarding this, but didn't find any good replacement (and Nick's suggestion also didn't fit). Jan