From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2061.outbound.protection.outlook.com [40.107.104.61]) by sourceware.org (Postfix) with ESMTPS id E38B53857C49 for ; Wed, 6 Jul 2022 06:20:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E38B53857C49 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAdZ5zAuhKCz5N7UZ3R3q7zjujfB5oGB+iEbEBIdyZfgZqRbojxHMQ1pQ4hdq69zN0vCWZ82DqUCCpu3ahBmfCrGo4Ocm+aA6hcYoyQFqCedfxCeln4H3BNgmm7ESLlNCcreVugj6fkMtUcgPxitfxjwvcalZ6iq1KqC3eKXakF8dBo1pwe64l600jq15cATDfrQNjC/UyFwJCK9zqyK7J0fQxqRE7X4P+bu3A/KSnkzujtS3hzKY9v8fvPltzbwWMKXlaOPdi8Lw7E2652HiZSwJQMbZe41lmSFLkkecD3RdB6MImpYZLbiSw96jE7ek6tn0u01XzH5+892MygmsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lHhq7KHG+3fpoO/RRV666kByoimEHplKEhri3khFicQ=; b=E33t9y1aZcx8T1ye+JDCUkQHLX2QxCcN1l3m8Z+VFsj5MbAH7OBwxU3LASwqj1njsDqqP89UwXWmoXFRgplrh6AEh5oVk6C1nELBBR6316LBpGSO5Ef5DiAnl/9P6fddZOTeJ1E+WDVP8PAvl/IPjLZHIBPTAPVHjqNL5Qw7kET8CGFjUmgEOe8nx0YPEZbpehfjrOuAjz0kiEJWfOlwSunXVR13wBac+9vg70w38ldhZytXvMVZ1TtCSytVKsxUbiMMDev7tjCRlOGuKDHbcACGt3jcHQE7r/BV6MxDnMJJtbyCGngFKBLCFE2VoG3ecu5fK68usWFpn2Q0X/hTlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB3PR0402MB3787.eurprd04.prod.outlook.com (2603:10a6:8:12::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Wed, 6 Jul 2022 06:20:06 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 06:20:06 +0000 Message-ID: <3afa2665-5785-a9f3-139b-8f25469682aa@suse.com> Date: Wed, 6 Jul 2022 08:20:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] elf: Copy p_align of PT_GNU_STACK for stack alignment Content-Language: en-US To: "H.J. Lu" References: <20220705195022.346635-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20220705195022.346635-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80511376-a5d9-4afb-01f6-08da5f1791ad X-MS-TrafficTypeDiagnostic: DB3PR0402MB3787:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YFYtXrsDbfYn8dn7xkjh9gPw6b1GEDxbMiSrXiQIFQG/leaUqpBsVRZBIIE2WS7KGur6m9Bnvh9u8Xj2TU9nI59ruyTgBFfTL4WO09JT+NEqEnNuwogi8ZggakVdfY4l1aw8i6+eCxa6EsMi8JvhCLjEaWlnTUlQZCxoSTgUfmMs+mq69UaHkpvGOkWATfdygqxtehtAPHN6f/Sfd5/FfYOSo3BPM5eZUQejpmOVeUk8dzrN6C5T0ezlQDSFC0gWiCkBPJOQyxpXEQAIZfNNRzRBlCpJ+N3cy/DVFXJWlr+TROKyr/oKWqirl2ZCKRrU842jY4Y56TC7vq2qZme/Pg98BmMPejcyhPyrZ7cLawJ0/62HkGHwwHxDH/qKJGb1+PKM2xjWkw6lJu0fXGk/edDmJ9QkGDdd+Xecm3ByxIfsJ42YzMJZufWisnzVvizgfKQv71j5g6qpe4WlpJo9J6p06+6X0tDJo1nrZZ6c1tf4HSnvYtciH0G7CDKaqd2r3eJNw7oS3KdaOd4AVtCRPT4fijH92pPK5LJo8EJrGcMgMVTy8RNgO46AtRmoNLIAGG2utv22dPzv/2Vc3zVpN7l0+3BwP8CsFh/p+NUlxnoGhgFnoAUuP/o34dyYZZiF686+ARRA8w4oD76SaPVOTO6PSFjAonqI8mZ7Q+70hmB6njezGdyDXqQzsbGdPYA/3T9YRVaVkmmgZ81yi7iWhud62k8EFopqSkxcqUgtozv4aMsFXXM034piCiXmwvXEXdsWfDEL2paBbCcWdFP0r8s/rAAoNobEdHvfvGAi476gYXbswoWD2K+CRh1cVR0AI14dmyEzoEVgUu+tPNwvToUwHu4vRP8eD8QXm3GVG6M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB6551.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(39860400002)(366004)(396003)(376002)(136003)(6512007)(6506007)(5660300002)(26005)(53546011)(6486002)(8936002)(66556008)(86362001)(66476007)(4326008)(66946007)(8676002)(6916009)(316002)(478600001)(41300700001)(186003)(31696002)(31686004)(36756003)(2906002)(2616005)(38100700002)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW9pU1VLY0YwNXBPOGZiYURXb0lRMDBTLzBUc2pqZGZqM3RkYU9Ca0FzdDk2?= =?utf-8?B?cGsrUndzclF2cUZmTTBka3ZKZ2M4LzEvM3NWUlRheXREK3d3U3RtV3FsTU53?= =?utf-8?B?cmJianNsck50ZGMzaW5EZ1ovS0xjbVdQZXNrVy9EbUJzU2RJbmR5N3FuMWJi?= =?utf-8?B?YlJJUmh5SkxBOTdMTDNjRlRvQVBPNHJZUXMzc0tHNnhNMmhJeFlpanBzUEpv?= =?utf-8?B?NFdiMFZFMUVyVDBVZ2hVOUxEV2hHMEtOOXNFaFBvQnJUTDFqSG9Dakw2bkQx?= =?utf-8?B?NWhBaThiYVVPd29hb1lIeWFhWmVVbTRldjdvYWNCd3Nsb3pFMVNhVTg0K2t4?= =?utf-8?B?U2dpV29DYWNSbTNpNDE4eWNXelF2R2Ridk5mazVBamRyVnZqVWJuMVZ4N1pI?= =?utf-8?B?dU00YTF3aHVneldxbU9PWlpBekZObVVOT1F6R2xOWldZU09DbmQrVlk5ODNp?= =?utf-8?B?YWdDbjFoRy9jYVFPRGV0MjRpcEhVSmJUMEgwZjh0bVRiUnBSNGxtaVJUZlcx?= =?utf-8?B?eGk1dE1XYllFUTR1azR2Z2twWUlaeXptSTd5cHovNWE2UCs5d3FwN1dGVzFt?= =?utf-8?B?aGFPeHBvSjdpVEIrSFV6NEVRbFdPaXQ4T0thZU9XaWg3SmRMekJOTGhJT1M3?= =?utf-8?B?eExyekVIem1wMkF4aUNqUG9VTVNjUXY4dlNjRkV1K3VLS3VMNFVqY1JyM1N3?= =?utf-8?B?eHVPZHlwVThtWlFucnBQL2Y3MEJkUVB6YStjd1BSNHlOTDJNdG4zRWovT2Jj?= =?utf-8?B?S3FaTlB4bHAxRlcxd0tiaTNySGc5aG5KdGc3NzdNSEkxaGZVa3hmNmhQRGZD?= =?utf-8?B?ZXc1cTdreVphUUFIYkNLMXJBVllnMmpaaGpVZEk0YWN6dnNWUUZEMXdndkd6?= =?utf-8?B?NG9EZ0lBWm1UWUxHaXVlcndCUzdjejNTYStUUncwNzJ4c2xZanBCRFhUUkta?= =?utf-8?B?NGU2T3pCQkt0eE1BdENMUUNmbHBiMU1nSkc4T2Z1N0dmMnZrYnkrUEFMUVJx?= =?utf-8?B?QlFYdjBWSHJVWTFWOXlkTFZ1SWxLQURvTGgvUHZBNkF0MHVadWxXWDVYdUtT?= =?utf-8?B?OEQ2SGI1L0w3ZExKZktBRXB6V2gya0JxYkRHTDJtTWZ5WklObkk5djFZMXBN?= =?utf-8?B?a3p0Z2pwYWUzV0tNdkp2MHpWNkpMaXNvbjBNam9HNnlrUUJvSVpEMzRMTEti?= =?utf-8?B?emQyUDFreHJjbFl2aFFSNm94dXJwNTByc2w3OFpoTHBVODlMdzlBdFRVNG45?= =?utf-8?B?em9xaUxFOUkrVVFmZ2dRbzhtWDY0djdCQ3lSeXpKVlpvQzhUNC9GTmFBWGNG?= =?utf-8?B?bUdPK1N1T2lSMWhZQzVab0tnUVBtYlZEWGFDV3ltdksxYXB6K1lYalNQT0xs?= =?utf-8?B?eHdjY0M0VlQ1QmV3UU5nVDIwZTdRaThsckIwcHc2VlBoMktZVlBITWQyUkZk?= =?utf-8?B?c1MzSDl6L1ZmUm1ldjV5a25rS3VEWldhUUFyeWpKd0xVd1NoQ0dPdmhPNFp5?= =?utf-8?B?T2tZaHNZelMwWVVtL1NwYVJ6UVEzakdrQjg1QXd4aUFuemVzTXMvUlpIUVBw?= =?utf-8?B?RFI1dFpoVVRnL1lxZytKOFNkT3luR1U4bjQ0elA5eEtoZnh1MXNkM04wS3VI?= =?utf-8?B?L1RlYnNYalRkNjhvNFYyZWxHTnFhTVJTQm5SaXlXNU5wTklhU0x3eGFsODE1?= =?utf-8?B?QzdwR0pBTDZqbGZIY0tNT2prcW5tYVM3U1JqZHZ4T0pTVm9UM05IN3B0MVNy?= =?utf-8?B?VVZJR3h6NTZ6L1FYc2VkaHRMdG15TXYrVG5nQzE2U2toVlRKRmhrWjhiWVFF?= =?utf-8?B?T1dZV0Y3OFF0bkZCR0YyZnNEY0ZQYXJiR3N6UFNaZ3RPVEtaWEh5bTc1TXEz?= =?utf-8?B?YThPSFJ3azEvNjhkbkJZSzZTRlYyT1AxakZRcCtUNkNZdytia2dvM2VQbUQr?= =?utf-8?B?cy9ISUd0dGk1b1piTnJvWGdYTVJ3M3JucGkvL1VjLzF6aVI1M1pqZWtlTytY?= =?utf-8?B?TFF2OUJZb2JCbTRiejhvaDF0QVZzWDZkcFZyVEQzMVJiQlZrMmVJWUFMTUh2?= =?utf-8?B?a0c0QzUwRDZ2Q1FhYkh3V20ybzMzWlJGVmE1elEvaTVqTG1pWUxzZ2d1bHFG?= =?utf-8?Q?9yJCZRZIM/xNE5p6gtWWssFwV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80511376-a5d9-4afb-01f6-08da5f1791ad X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 06:20:06.0517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fyk+ZXHskMmswhJgLAAmclkbYUZuBA40uLOpl43S39gECaljPTFzXKhRqBEQG9jsrYgbLC21wQI7F5nKd+6WFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3787 X-Spam-Status: No, score=-3036.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 06:20:10 -0000 On 05.07.2022 21:50, H.J. Lu via Binutils wrote: > commit 74e315dbfe5200c473b226e937935fb8ce391489 > Author: H.J. Lu > Date: Mon Dec 13 19:46:04 2021 -0800 > > elf: Set p_align to the minimum page size if possible > > may ignore p_align of PT_GNU_STACK when copying ELF program header if > the maximum page size is larger than p_align of PT_LOAD segments. Copy > p_align of PT_GNU_STACK since p_align of PT_GNU_STACK describes stack > alignment, not page size, > > PR binutils/29319 > * elf.c (copy_elf_program_header): Copy p_align of PT_GNU_STACK > for stack alignment. > --- > bfd/elf.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/bfd/elf.c b/bfd/elf.c > index 468d37f5028..89484ceb233 100644 > --- a/bfd/elf.c > +++ b/bfd/elf.c > @@ -7685,7 +7685,9 @@ copy_elf_program_header (bfd *ibfd, bfd *obfd) > map->p_paddr = segment->p_paddr; > map->p_paddr_valid = p_paddr_valid; > map->p_align = segment->p_align; > - map->p_align_valid = p_palign_valid; > + /* Keep p_align of PT_GNU_STACK for stack alignment. */ > + map->p_align_valid = (map->p_type == PT_GNU_STACK > + || p_palign_valid); > map->p_vaddr_offset = 0; > > if (map->p_type == PT_GNU_RELRO OK. Jan