public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Xiaolin Zheng" <yunyao.zxl@alibaba-inc.com>
To: "binutils" <binutils@sourceware.org>
Cc: "jiawei" <jiawei@iscas.ac.cn>, "nelson" <nelson@rivosinc.com>
Subject: Re: [PATCH] RISC-V: Adjust the 'print_insn' return value of disassembling.
Date: Sat, 18 Mar 2023 12:41:26 +0800	[thread overview]
Message-ID: <3b1870a0-c95b-4105-b772-75ce30a1679b.yunyao.zxl@alibaba-inc.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

Hi Jiawei,
Thanks for fixing this issue! I didn't subscribe our mailing list so I add a "Re:" in the title and expect this mail could append to our thread of discussion.
Seems to me this patch has not yet been committed, so we have time to discuss.
My question is simple:
There seem to be two [1] [2] `memory_error_func` used in `print_insn_riscv`. Seems the first one is an opcode pre-fetch and the other one is the real one. So, should the other one be fixed as well? ;-)
[1] https://github.com/bminor/binutils-gdb/blob/9e4b2a6697006f9ff39bce13edd640330e208c9f/opcodes/riscv-dis.c#L1061 <https://github.com/bminor/binutils-gdb/blob/9e4b2a6697006f9ff39bce13edd640330e208c9f/opcodes/riscv-dis.c#L1061 >
[2] https://github.com/bminor/binutils-gdb/blob/9e4b2a6697006f9ff39bce13edd640330e208c9f/opcodes/riscv-dis.c#L1073 <https://github.com/bminor/binutils-gdb/blob/9e4b2a6697006f9ff39bce13edd640330e208c9f/opcodes/riscv-dis.c#L1073 >
Best Regards,
Xiaolin

             reply	other threads:[~2023-03-18  4:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-18  4:41 Xiaolin Zheng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-03-17  1:53 Jiawei
2023-03-17  2:26 ` Nelson Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b1870a0-c95b-4105-b772-75ce30a1679b.yunyao.zxl@alibaba-inc.com \
    --to=yunyao.zxl@alibaba-inc.com \
    --cc=binutils@sourceware.org \
    --cc=jiawei@iscas.ac.cn \
    --cc=nelson@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).