From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2042.outbound.protection.outlook.com [40.107.14.42]) by sourceware.org (Postfix) with ESMTPS id A09D93858D35 for ; Tue, 31 Oct 2023 10:25:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A09D93858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A09D93858D35 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.14.42 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698747923; cv=pass; b=WFCJbM5ithr6kgTwSLf3y87YAJoZfo64Cf/gWmrdsJtQlkgBShpt9/B4oFNKKMphweBsz+Hqa0MClSuJ3rxdRGOp3U23n/ZwkGgpewrlaMZSInwQ3SwVMTA4hfnibjFxMYHtTzbaCBOnUKSIvTtkccW0nuli6+RCsRsVmpGGgjo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698747923; c=relaxed/simple; bh=wHXuUN7DHuSpTlMSJ9jOajpOEctg5MbiPsYgk0dmktk=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=EXUV+q/onk6N1JsYZGuBnnilME6y+o3EvcUvE7V6NvFNbYoEodFgNF+x7tdTHRf/PIq/wVJoxL/Ac1ohYQHXxfUvrrlFsoFrT9uNvMsHhmSHiYBAh0rFPx2bKB1Ci9Jxx2wJ3gabVvlpChzqG2jbSSIyyYgUDTkmJA81RyClc4w= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b1E/EDEnAU1oSN3CnK3ibOmo0HGCw0vlztfSNGxnbCy5Eh+z9O6baokCQyW1i8sXeQq4Ph40qPId0MO1Fbb83aP55s78Z76WpmFUhusCcS4f6rg9Lhja0P03REVgsZssLVAdpciwT1A4gSI/NB+3ut9IbcKE38qKLlS2syYeItcJ3nvENnlmq5y+5S5u+VZfzqE7vOpp/n/oSD+nDNYeywtKkEJk8Zac4CnWQTzalru2kQceKPP/S1WVdhJlkoWHqEQ7YMpxSIU45H386P2/CHjrSxGBpV+bTsj/K10rHDsFGjNxCihSuNfhAbVEIAQc41gr+QfJfZSMVPnSNVF+xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=me4I1YXyQvqRcWEWxuaERAgPOddesxlheyUHmxrxcig=; b=SrsdBblr6iofsAcZ9gnMUUiclyPKeluZKsg0Cm3oQO9a9IBJbDEj0ur1wXyKyXSevfJ6dWk24z/wHIpLp6eTg0MfNc5qpOuvG6HjTUTHk0svyCsyH62L4YSDpF6H+8mKBxjAjbl2XQa9MNZmEbTnmUXBnUV8cFqmRY6NrZUjXwYavhjIHXIwmSfy5Mzjekp5fItHfNVsCR8JubtLE1/fCCzIwiOu2jTcu6q6pp+SEF8qz8hiR7feivjk9Ip81XD1rp/5hscE/qCGYWbvLwRBU9VnSKvSv2AMmblBiWqt/FktcmnhDNI6yn5dt+ViqFg1CY10ouCYthUqJwv7jNMI8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=me4I1YXyQvqRcWEWxuaERAgPOddesxlheyUHmxrxcig=; b=ISYS4v16pEZiCyQVDU4DWya6SjYaSF8UagWKnyfrGNciUtCiua9mJXZ34kMpX1tSO08P0IfgpBfNqxANMM8lWrcnSndiQ1uI02cQ92ucsxgqSwYk6Yy8+9x2R2llx03it6wA9PczshChTz7Z+s5/RaJo1ex/tSiUTjy1GPEW84WMOy4nBe87A1ad8BN5Yp7GLb6fFAKbYDZu+sO9uwv1cvb3eiXpuiW733/CRyH2aMOCOT881bT+hdLOaaNneg1SBFGm6okYu2n8tFF6IR0zi/rb8bR0E5km6M/z10d8BWyJJL2WBwCWomLbCa5MKuWe9pTx5OYXRj2KvGYDzycQ1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9665.eurprd04.prod.outlook.com (2603:10a6:102:240::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.18; Tue, 31 Oct 2023 10:25:19 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6954.016; Tue, 31 Oct 2023 10:25:19 +0000 Message-ID: <3b233f44-08a7-00fd-55ee-6171a35b18bd@suse.com> Date: Tue, 31 Oct 2023 11:25:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] gas: bpf: new test for MOV with C-like numbers ll suffix Content-Language: en-US To: "Jose E. Marchesi" Cc: binutils@sourceware.org References: <20231030150212.21445-1-jose.marchesi@oracle.com> <87wmv4ko9w.fsf@oracle.com> <11cf8b73-7b95-5957-3bf0-c49a7e740773@suse.com> <871qdbw16s.fsf@oracle.com> From: Jan Beulich In-Reply-To: <871qdbw16s.fsf@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0160.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9665:EE_ X-MS-Office365-Filtering-Correlation-Id: c1a1d62c-b59d-4662-a255-08dbd9fbae52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DqQsbAnKXQ7n0mNUn58FA58bFAirUkSp2E193GbNZ7pzDYXHyAOZmlOQGGu/68S4as+36Gi45eG6xNORgL6716Zyxe/rX7zNhaPeTnCIb0BnghW8itJQyNIAhQ3lJjVSD4V7EyJzBHckADmYbcLJPYJrVAmfPkz9sARMpgEjtf9wnl6HNyGjPLgtzHGc47xjDkljzLTe7e0ObIl50ZNBjX1i6y6HLL14Fsh1hDn4FfsUS8NubnyIK81C53qnxyzE6F3/RrqQGY/D//k5f0u+476RnIz3DfsXAhTFKOZYMqk8E2b0sSeXkEKTj0BhtslxecvRPW1GjivfKEZKTBupjfkJCSrxhDDKyKh0KmPIkvbWjNCFWLHsATN1+xzeh1ixZ0auzAQ3oyMZoS6ieH1D5gwB53FWtfd0mW0HmUbCG8wiiay3cekpOmGvCHs7+rp5Q+AlbYPD9uxsnCMmjrZbWr4RNFuqdgZnLjq3NR6ffS5w8kmmj/G68Q4PGh17Tpq6j7zcnFXsjhjBjN+zaOjJ4sxXMOTJk4EGbpOeGYACxYpLvFU1WlE7/5+Afs4z5Vwx50+XEg3q+z7VZ+fbyNUYm/G4lk4C8pudjZ7crpdtTw1120rmWCjI45OViHcZWTI7lvnLXDaCI347OuhvL652UQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(396003)(366004)(136003)(39860400002)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(5660300002)(4326008)(41300700001)(8936002)(8676002)(31686004)(316002)(6916009)(66556008)(66946007)(66476007)(2906002)(6486002)(478600001)(6666004)(6512007)(86362001)(83380400001)(36756003)(53546011)(6506007)(26005)(2616005)(38100700002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDdEWWtPS0FtSi91MkdVTCs0cU92Y0hRMXNiaGw0aUdYMXRWTmx4OUduZ2xP?= =?utf-8?B?SFZOTUwrMFRuTFFGQXlMMC9NU1RxWVFRL1VaSzRrUWhCNEFIcFc3NXZTT1J3?= =?utf-8?B?WGJtbTBOd2lEUWdvS1Bwd2FDK1NiZVNwSHR5MTBic1QzSmhwVzg4ZFJyZWJo?= =?utf-8?B?Z01rcFpYWXRDRSs4RE5BVWt2WnMxRjZkdlp5K3RTUFdXQTFkZTJyTnRmeFQ0?= =?utf-8?B?KzdSeDZNVFFObG9wcTBRZmgxMDFWLzNlNC9JT3lJYy9mUTR1Nlc3QjY4M3dE?= =?utf-8?B?b0hxbU9Ud2lrMUJJalJ3OXVkbUNYRkFyWTBkUFA5dGRHRUZYd1RoSHRETkNk?= =?utf-8?B?UVZ6NjcvWHhwc294V1FpQjUwcmpEQVFFVHNualFEQVN0VSt4VEVzRTMxb3JM?= =?utf-8?B?QW9pYmZwWFdhTFY1S1l2ekpkWk9Ha25KQkNsZDdPZmJ2cjV5RWVyUnNDdWNX?= =?utf-8?B?akFBcSsrWW4ybWdSRnpvQU9FWFFFc0NQTC9ISmhveHFJQS90M1U2SVVxdHdC?= =?utf-8?B?bXlYMC9wTjYyYU9kVDNwL3JPZmcxTWd5dkJ1VHBZRzRud3BHcm5VYjdaQWxZ?= =?utf-8?B?YnA1VE95RmVuSEgvVGpZYlBPdDFjcTZyZWFqc0FDVU45V254Y1QrdFVaYlk0?= =?utf-8?B?VDFPUklsNDVPdkp0bjQ3TDZpTWJoNmpFQlBuWnhvdWpGQW5LdHk3c3duTkMw?= =?utf-8?B?YVd4MTN1R1dHSDNVZ0c3Q3MvS0FPY01RMWIySDRMM2duVlhDcnBNTlBuUkVT?= =?utf-8?B?VVFTMUFldThNOXZIbGJucWhzS2doV2VoZ1d6b20xaEtFRDdrUTRtTGtlNkVh?= =?utf-8?B?Zm00RU9qU1dXbVJqNFYrczJ1VW5XN2tmRGIwdGhTMWJ6T05wbTNGNDdodjBt?= =?utf-8?B?R05KMTNGQ0hZY2M2eDllZ3FBS1FienNkVkNBd0lTdkJSc0NmemRQQjgvOEJL?= =?utf-8?B?cUdERVZHeFN0aWp6OW9DeXpyRmM3MlhQczJ6aDJOWWxiMUJCQkxKZFN5UUZW?= =?utf-8?B?SjZOSjZxcFo3ZjJKZTZCZmk4T1ZSZGhnTzJlRUF4Sm1nZFpORm16QUNHVi9s?= =?utf-8?B?N0srdUpjTWRTWEh2Tyt0UnZjVjhmeDBkcXlOcXJrYWZCd0w5SVRBdTdlMUJr?= =?utf-8?B?eTFkUE5odlBuU0pia0FEczdYU1BLb3UyaWMwMXhnT0RKOXFDY0hkZE5TQ1RX?= =?utf-8?B?QmJndFhZVFBZNEt2czNQZHc5eDNEbmdsWlJ0WVFiN0U5elFMWUFBV2gvY3Iw?= =?utf-8?B?OGJxM1NwR1p2RHRwait4WWd4dVd0Q25HQUFSaC82RUpVZ3hlZ3dsWlVMbzAx?= =?utf-8?B?WGdjUi80cWpOTG9TVkJ6ZTQ5WDJ4VGUrY2t5Z2IvOE5oMS9jR2xYWC9yN2JE?= =?utf-8?B?ckYwQUhmU280Z3hQTTRrY2Y3bmI5M0dJdm55L25oM2tsRDJLTDZTKzlKYlN0?= =?utf-8?B?M3o4b1hHYUFqbjBwaGRCdDZUVDZwYlBsRXlKalNld1NyYU5UNndVcFBubWwy?= =?utf-8?B?cC9lT0pvd1d4NmIxRndWeWNrVG12T1dxcjFOS1ZEeTJBenhuL0htMkp1RzF5?= =?utf-8?B?UThaNmxKdytVRGJueVZKOG1KR1M3SjdqY1pyT1lTZDNxVWwwdlJuK1hVTGFk?= =?utf-8?B?Szc0SW5pMCtLUWJKWmltKzUxK21lOUU1bnVSeEo2TGtkNEpHMjRiUW8rc1lG?= =?utf-8?B?RXRqREg0UVlodzFNRHdxb3E5bW5OdFlNMHdMUGUvcFFMbnNqK05QOUVPcUlR?= =?utf-8?B?UUV4Rm1ZRi8zM05UaXBQaDFNTUduWnZJb2hWNlZuV2lwVVY0NlN2T0J5ZXhV?= =?utf-8?B?VzNoOU5DdW03MGQvSDhSTkUzU2Z5VmN0RHgrOXlPbXovN3J0c1hoaWtYck9x?= =?utf-8?B?TTlKeTFpR2ltVHJzdWlzVDEvZmdWOGI5YzJTWHRIQ1RNSHdLbDNyZUNGcWtX?= =?utf-8?B?RTRIK1U2aHFaYjhDcmhmQkQzb2MzYjgwZ0VBd05obkFiZ2o4blpHbE4wR3lB?= =?utf-8?B?NGlWRGlGcVdpYUE0SVd0NGtQWGswTXRua2tJRU4yMFBJS3pnbkIrdUtZVDFa?= =?utf-8?B?ZWFsWDhBMXJZdE5HeXN0QndQVnd1Qld0TWtLSkRDbzgrR09JMWF6UTZHdEFO?= =?utf-8?Q?x76YYXsfcfcjHxhBOPJgYaTzH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1a1d62c-b59d-4662-a255-08dbd9fbae52 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 10:25:18.9454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hKDqCCEJ6dwXfFFjgs2iTY6GtkKTt9qa2EwbbNZvhLn0ht6ETMP4/dzo+FQA3Tska5W92qQ1Qraa9SgVTAPgiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9665 X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31.10.2023 11:12, Jose E. Marchesi wrote: > >> On 30.10.2023 18:34, Jose E. Marchesi wrote: >>> >>>> On 30.10.2023 16:02, Jose E. Marchesi wrote: >>>>> --- a/gas/testsuite/gas/bpf/alu-pseudoc.d >>>>> +++ b/gas/testsuite/gas/bpf/alu-pseudoc.d >>>>> @@ -69,3 +69,4 @@ Disassembly of section .text: >>>>> 1d0: d7 01 00 00 10 00 00 00 r1 = bswap16 r1 >>>>> 1d8: d7 02 00 00 20 00 00 00 r2 = bswap32 r2 >>>>> 1e0: d7 03 00 00 40 00 00 00 r3 = bswap64 r3 >>>>> + 1e8: b7 02 00 00 9a 02 00 00 r2=0x29a >>>>> \ No newline at end of file >>>> >>>> Just as a remark - issues like this would be really nice to be taken >>>> care of as files are touched. Imo much better than waiting for a >>>> separate cleanup patch. >>> >>> Your point being? >> >> "No newline at end of file" is something that shouldn't happen in any >> source files. Therefore when changing adjacent code it would be nice >> if the missing newline was inserted at the same time. > > Yes, agreed. In all candour, in this case I didn't even notice it > before pushing (was in a rush) or i would have done it. > > Would you say the same applies to typos and other trivial fixes? > Usually I refrain from fixing these that I happen to notice while > working on something else, unless they are very coupled with the change > (like a typo in a comment describing the code I am changing) even if it > is very tempting to do otherwise. I guess it is a question of degree. My rule of thumb is that anything that's touched anyway can also have cosmetic corrections alongside the main intended adjustment(s). Jan