From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8DA2A3858C74 for ; Mon, 15 Aug 2022 12:46:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8DA2A3858C74 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-672-E9KF43plNkeV6VOHMouJIg-1; Mon, 15 Aug 2022 08:46:34 -0400 X-MC-Unique: E9KF43plNkeV6VOHMouJIg-1 Received: by mail-wm1-f69.google.com with SMTP id a17-20020a05600c349100b003a545125f6eso8638906wmq.4 for ; Mon, 15 Aug 2022 05:46:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=U5Y/z0Vosxjj7R2JhLy+hzJP3Fcxn4tBmJMhYL8F2JQ=; b=SLvkzrhizO6LCOUvv0pOvyw3fq9EE9QfsvwVCkPYJAwEg0Y5E7zgFclqCLBZeHtDi5 XCZYvFK2USGQU6FJCP/rMcoLq6/AOP1bwONeabPlOuH2MWRPHgjfLvkO1Xlfk+tsbVJN 0aM2gimpVLgMbyoO37ikpT8LGiuSUgELC7J2NPdgQ/a6GBzhRE+3RwHI8l92LV8GSjl2 9JkKKf5V4FdIvYuXG3T4YiFxq3sS6m7W0804JdCQ5VchXQpvPbtOHrTP7wEA0CqtVc2q pjG5+02s9aT4vEpadTMA9VIo8/WoBgFr5SiXkhKGq70SDCcDv2TkbXxsQyHvkgCD6tnO yiYQ== X-Gm-Message-State: ACgBeo00bfOLbMd5mTpJFuz//6oDHBtQpGNBsAtUJ6sc1w6IaVembxEZ 6Fh4RDoJ2tLSsMdSSSqHINPgUS++VAE3fHUb7O5v1YNs9zwStPSm1wec0UpmGRJzjEs28KypHvS DDHLynx+gwnF9kxO2dA== X-Received: by 2002:a05:600c:4e92:b0:3a5:fd90:24e3 with SMTP id f18-20020a05600c4e9200b003a5fd9024e3mr1697807wmq.59.1660567593095; Mon, 15 Aug 2022 05:46:33 -0700 (PDT) X-Google-Smtp-Source: AA6agR5FO79ohegNK3VDsar+p0Kg16tSy941TzJYf1OGlIo3QcJtDvVzaVrTdE52Hk+NJitwQ/dieg== X-Received: by 2002:a05:600c:4e92:b0:3a5:fd90:24e3 with SMTP id f18-20020a05600c4e9200b003a5fd9024e3mr1697800wmq.59.1660567592854; Mon, 15 Aug 2022 05:46:32 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id j11-20020adfe50b000000b00224f67bfc95sm6271369wrm.62.2022.08.15.05.46.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 05:46:32 -0700 (PDT) Message-ID: <3b65e299-5dcf-fd05-8c82-013cac7e0683@redhat.com> Date: Mon, 15 Aug 2022 13:46:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Indu Bhagat , binutils@sourceware.org References: <20220802080452.1143351-1-indu.bhagat@oracle.com> <20220802080452.1143351-5-indu.bhagat@oracle.com> From: Nick Clifton Subject: Re: [PATCH,V6 04/10] libctfframe: add the CTF Frame library In-Reply-To: <20220802080452.1143351-5-indu.bhagat@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 12:46:36 -0000 Hi Indu, I had a strange problem with this patch. When I tried to apply it by hand using the "patch" program I received these error messages: File libctfframe/testsuite/libctfframe.decode/DATA1: git binary diffs are not supported. File libctfframe/testsuite/libctfframe.decode/DATA2: git binary diffs are not supported. File libctfframe/testsuite/libctfframe.decode/DATA_BIGE: git binary diffs are not supported. When I tried to apply it by saving the whole email and using "git apply" I received: error: corrupt patch at line 362 (I think that this is due to a bug in thunderbird which is causing it to wrap lines when it saves them to files). Using "git am" did work, although it complained about lots of whitespace errors. I am not a fan of git am however as I do not like the fact that it commits the patch before I have had a chance to review it. But I can work around this, so on with the review. > diff --git a/libctfframe/Makefile.am b/libctfframe/Makefile.am When you add a new top-level directory like libctfframe you need to update the src-release.sh file as well. In particular line 96 contains a list of the top level directories that will be included in a release, and so you will want to add your directory there. In addition it would be nice to include an entry in the binutils/NEWS and/or gas/NEWS files mentioning the new feature of the binutils. Cheers Nick