From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id BF8573845BFB for ; Fri, 15 Dec 2023 12:11:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF8573845BFB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF8573845BFB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::236 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642301; cv=none; b=SzHaCjaEMdONiSu7Ne6r5wZRH9/CrV9Zbe6sHY8v/L2WXO3SM5nceSnEa8q4Faezw2CpG4WTf+GwN3b2g+dhYwscpeUfW6eXxsl/rK9UvxSF1qZ/I3Zj1fqyT6safQPkUPdew20BtpF1l4f+xoXFUlx3BNxDqF3obPmrejeawBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642301; c=relaxed/simple; bh=UveW18yBE16n1Ln3FcJqReuWdjZp+r7Dvf6+Am0A5Qs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=FLRUIUFAtGo3VZqjvKccOfLCZLh2FEk8q+IXlLvww0NHZUEpnVRvWtR30dzBGmskOwtxo9JtkD6lg87G1IKLFj9Sel5eOapD6L26oNkJ8czKlFUDn9Qbam/Mlh3df5tN0Qoc7SmPlCO7JclJ8pguBZjSJF+hhVHGNvN2/pB3iJU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2cc3f5e7451so6628071fa.2 for ; Fri, 15 Dec 2023 04:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702642298; x=1703247098; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=fo6xThx0QDQYXtoYFPitQ8ArBwDco76jkaYjMwCAWXk=; b=Y0broi9JcyrcJVHRaVCGIdWZc0xLLGB/BW13FyLAjy5oMx+ThTfynQytzLNbYkTQBO 3iAgIexK7NYc52CvLAlIsIIZsnHvh+4gMuGiaTfaNJYtaOQcWNfqE5KJe/fJybG5E7Dj EI11pADVQW/PAAiBIRIVxuRFORJvALSiq/Ne2hyoYo8kn7h8xYZKmNgX+bD7M0oX7Xtv vtxhFW+eliVKwhwPp5whzVCjJuBa9UBYKPV6wTGfh3/+VInUDY7VmmZzch8/KMNiYGMO f7NqQLA9FT2AoVCkW0YH4Ah3ePUTcwscSJDIfrZxLidpIeamUmQtADW/+VfA8VjF8nqu C1VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702642298; x=1703247098; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fo6xThx0QDQYXtoYFPitQ8ArBwDco76jkaYjMwCAWXk=; b=bSR6nu0d9VnMurHuTtNg91MwETYj15JpsVm3tKi6wekNeHwEhSLciaom6ucVssAxhg poeOAiCNvHgPbhUt1BH4iIl/FXSdnjiQb7n8cLDWpm68PDJPNpV9QI1Smuq46fA1RBdo GMFJYyHRQJnKZcbadq1cujgo2fQBQjYEIC/e5bwOV8Z2ZAx+qA6WdTz5740z1lyUWDvG BHzP1uSZudLZSo5d3Wnh9e+XSVEky2/RENgiDohScn+bNt1RDHSKd+8j1DHEZ1sDzoN7 sBdjT7IM3LiW8yMM0IufxfQoWbqqzXt+l1Yq1imW5CEgWkqULvf1pwRF7MteCAvq9K5E C/7A== X-Gm-Message-State: AOJu0YyMLtdNr96UZj4vUJSxrdj37mcvjDbPk1jIsHtDP4ltYypcvAJG mxqAOqB4m4YbApWrUDhFkPdtZn4hro3vXdFvZoHM X-Google-Smtp-Source: AGHT+IEj7WNmLn84IkSfu7/5vc1VZzas4oTdZaTDZ7EY1af4MRSBNi4uZajoQKoQ6vNgcXXfg0V0ng== X-Received: by 2002:a2e:be28:0:b0:2cc:1c2d:ef7f with SMTP id z40-20020a2ebe28000000b002cc1c2def7fmr5632603ljq.62.1702642298189; Fri, 15 Dec 2023 04:11:38 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id k9-20020a056e02156900b0035da74cd896sm4764564ilu.77.2023.12.15.04.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 04:11:37 -0800 (PST) Message-ID: <3b9cf7bc-76dd-4cb1-9872-413ed5a62bab@suse.com> Date: Fri, 15 Dec 2023 13:11:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 08/22] microblaze: drop/restrict override of .text, .data, and .bss Content-Language: en-US From: Jan Beulich To: Binutils Cc: Nick Clifton , Alan Modra , Michael Eager References: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While only ELF is supported right now, (stub) code generally is in place for the non-ELF case as well. Don't override .bss for ELF - that's unlikely to be a good idea anyway and prevented the sub-section specifier from being usable. Don't override .text and .data at all - for .data and ELF for the same reason, while for .text and ELF obj-elf.c's is all we need, and for (hypothetical) non-ELF read.c's identical handling would have been invoked anyway. --- Wiring .bss to s_data() is somewhat odd, too. --- a/gas/config/tc-microblaze.c +++ b/gas/config/tc-microblaze.c @@ -135,27 +135,6 @@ microblaze_generate_symbol (char *sym) /* Handle the section changing pseudo-ops. */ -static void -microblaze_s_text (int ignore ATTRIBUTE_UNUSED) -{ -#ifdef OBJ_ELF - obj_elf_text (ignore); -#else - s_text (ignore); -#endif -} - -static void -microblaze_s_data (int ignore ATTRIBUTE_UNUSED) -{ -#ifdef OBJ_ELF - obj_elf_change_section (".data", SHT_PROGBITS, SHF_ALLOC+SHF_WRITE, - 0, 0, false); -#else - s_data (ignore); -#endif -} - /* Things in the .sdata segment are always considered to be in the small data section. */ static void @@ -298,20 +277,13 @@ microblaze_s_rdata (int localvar) } static void -microblaze_s_bss (int localvar) +microblaze_s_sbss (int ignore ATTRIBUTE_UNUSED) { #ifdef OBJ_ELF - if (localvar == 0) /* bss. */ - obj_elf_change_section (".bss", SHT_NOBITS, SHF_ALLOC+SHF_WRITE, - 0, 0, false); - else if (localvar == 1) - { - /* sbss. */ - obj_elf_change_section (".sbss", SHT_NOBITS, SHF_ALLOC+SHF_WRITE, - 0, 0, false); - if (sbss_segment == 0) - sbss_segment = subseg_new (".sbss", 0); - } + obj_elf_change_section (".sbss", SHT_NOBITS, SHF_ALLOC+SHF_WRITE, + 0, 0, false); + if (sbss_segment == 0) + sbss_segment = subseg_new (".sbss", 0); #else s_data (ignore); #endif @@ -385,7 +357,6 @@ microblaze_s_weakext (int ignore ATTRIBU const pseudo_typeS md_pseudo_table[] = { {"lcomm", microblaze_s_lcomm, 1}, - {"data", microblaze_s_data, 0}, {"data8", cons, 1}, /* Same as byte. */ {"data16", cons, 2}, /* Same as hword. */ {"data32", cons, 4}, /* Same as word. */ @@ -396,9 +367,10 @@ const pseudo_typeS md_pseudo_table[] = {"rodata", microblaze_s_rdata, 0}, {"sdata2", microblaze_s_rdata, 1}, {"sdata", microblaze_s_sdata, 0}, - {"bss", microblaze_s_bss, 0}, - {"sbss", microblaze_s_bss, 1}, - {"text", microblaze_s_text, 0}, +#ifndef OBJ_ELF + {"bss", s_data, 0}, +#endif + {"sbss", microblaze_s_sbss, 0}, {"word", cons, 4}, {"frame", s_ignore, 0}, {"mask", s_ignore, 0}, /* Emitted by gcc. */