Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails

[Vladimir Mezentsev <vladimir.mezentsev@oracle.com>]

I cannot reproduce the problem on this Debian:
% uname -a
Linux gcc14 6.1.0-11-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4 
(2023-08-08) x86_64 GNU/Linux

% make check
...
Test run by vmezents on Thu Aug 17 18:32:49 2023
Native configuration is x86_64-pc-linux-gnu

         === gprofng tests ===

Schedule of variations:
     unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file 
for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for 
target.
Using 
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/config/default.exp 
as tool-and-target-specific interface file.
Running 
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/display.exp 
...
Running 
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-archive.exp 
...
Running 
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp 
...
Running 
/home/vmezents/GPROF/binutils-gdb.git/gprofng/testsuite/gprofng.display/setpath_map.exp 
...

         === gprofng Summary ===

# of expected passes        6
make[2]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'
make[1]: Leaving directory '/home/vmezents/GPROF/dist_binutils-gdb/gprofng'



How did you configure your build ?
Could you send me gprofng/gprofng.log from your build directory.

Thank you,
-Vladimir




On 8/16/23 21:22, YunQiang Su wrote:
> Vladimir Mezentsev via Binutils <binutils@sourceware.org> 于2023年8月4日周五 04:34写道：
>> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>>
>> gprofng/ChangeLog
>> 2023-08-03  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
>>
>>          PR gprofng/30700
>>          * testsuite/gprofng.display/gp-collect-app_F.exp: Fix -name argument
>>          for sub-experiment filtering.
> With your patch, It seems that this test still fails.
> And in fact there are 3 failures for Gprofng on x86_64-linux ( I test
> it on Debian):
>
> testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/display.exp
> completed in 7 seconds
> Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-archive.exp
> ...
> mkdir -p tmpdir/gp-archive
> % timeout 300 sh -c 'mkdir -p tmpdir/gp-archive' 2>&1
> cd tmpdir/gp-archive &&  cat
> /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
> sed '1 i /* CORRECTSOURCE */' > t.c &&  gcc -g t.c  &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -O exp.er ./a.out
> % timeout 300 sh -c 'cd tmpdir/gp-archive &&  cat
> /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
> sed '1 i /* CORRECTSOURCE */' > t.c &&  gcc -g t.c  &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -O exp.er ./a.out' 2>&1
> Experiment is not created in tmpdir/gp-archive
> FAIL: tmpdir/gp-archive
> testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-archive.exp
> completed in 0 seconds
> Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
> ...
> mkdir -p tmpdir/gp-collect-app_F
> % timeout 300 sh -c 'mkdir -p tmpdir/gp-collect-app_F' 2>&1
> cd tmpdir/gp-collect-app_F &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -F 'off' -O exp.er  sh -c 'mkdir t && touch
> t/x; rm -rf t'
> % timeout 300 sh -c 'cd tmpdir/gp-collect-app_F &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -F 'off' -O exp.er  sh -c 'mkdir t && touch
> t/x; rm -rf t' ' 2>&1
> Experiment is not created in tmpdir/gp-collect-app_F
> FAIL: tmpdir/gp-collect-app_F
> testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
> completed in 0 seconds
> Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/setpath_map.exp
> ...
> mkdir -p tmpdir/setpath_map/src
> % timeout 300 sh -c 'mkdir -p tmpdir/setpath_map/src' 2>&1
> cd tmpdir/setpath_map &&  cat
> /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
> sed '1 i /* CORRECTSOURCE */' > t.c &&  gcc -g t.c  &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -O exp.er ./a.out
> % timeout 300 sh -c 'cd tmpdir/setpath_map &&  cat
> /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c |
> sed '1 i /* CORRECTSOURCE */' > t.c &&  gcc -g t.c  &&
> /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng
> collect app -p on -a off -O exp.er ./a.out' 2>&1
> Experiment is not created in tmpdir/setpath_map
> FAIL: tmpdir/setpath_map
>
>> ---
>>   gprofng/testsuite/gprofng.display/gp-collect-app_F.exp | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp b/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
>> index f791b0f7a95..02bcc8e5b49 100644
>> --- a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
>> +++ b/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp
>> @@ -46,11 +46,11 @@ proc run_gp_collect_app { subExpCnt F_opt } {
>>       return -code break
>>     }
>>
>> -  set output [run_native_host_cmd "find $tdir -name '*x1.er' | wc -l"]
>> +  set output [run_native_host_cmd "find $tdir -name '*_x?.er' | wc -l"]
>>     set subExp [lindex $output 1]
>>     if { $subExp != $subExpCnt } then {
>>       set out [lindex $output 1]
>> -    send_log "Test failed for -F $F_opt. subExp=$subExp. Shold be $subExpCnt\n"
>> +    send_log "Test failed for -F $F_opt. subExp=$subExp. Should be $subExpCnt\n"
>>       fail $tdir
>>       return -code break
>>     }
>> --
>> 2.31.1
>>
>