From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 45E413858D1E for ; Fri, 12 Jan 2024 19:49:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45E413858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45E413858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705088991; cv=pass; b=lUXJbZqINEiCCYpjjhlWwuoZSyw9oXhxvdfj62elq9JReKkKoQiWMYxw9bBmRGKqz3dtGhB8R4pqRn1anvgv7V7MZqXxFTQuMB6wyuJxBnS6P62AhY1WtSZ4R70tCHJQ8UuL5sTWp4a7d0xYetx+1wAi+z1sibuZ0+ueOrH0/+U= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705088991; c=relaxed/simple; bh=6debzZqAwPSZ43zXx4xVgO1YaVz71ROLXzt495eXuBw=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=YsLcaoWsgjH9J4f9eKfckxht/A5aekk3pdROydsJLvpmSodW1y8vmK7jweOrT+yupAse6xvK1GXUM5LH+3UqL8cje/JjyJzU3HE7Du7J71CuuSUEreVjZZE65W44pfSBViw5QWyFwDMPbCnDO2wne27n79kkpQsdkg0+gt+e/kQ= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40CJJXia024177 for ; Fri, 12 Jan 2024 19:49:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=mYusHsmoHWyeH34oEYm+sEW38ESTJE5PBINR4NJsFaA=; b=d1nz2sN1j4oEsRVTU+nJvy6292Z9gmX1iWu10fkVuUAVZSSfh01j82+eUtdLbYPtSbae ZTorRmkcnKTvDEaF+uw7v1Z/Tw1x18iXH5KvZZnDqMG5DAtYzh9FZMlIcsbqoaaPRaqE b7xfscguD2bljFIDbNsoOQ70gvHV/f3raIhfMJZfcLJoBr1U6PPtan35F3SrMJtGGZRJ osRpP4VEUsDpTdXXwRjAh4JeBC321yDnqcULBnj6OP+gm/pB5PSj/a6jIWCF1ySxe5fU 1TjWNWv576ToejfzVgKlN9e6XC1ibssmMcTq00FL328RxyJAYVY7wFOmsbLftol7X8MZ Jg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vk98h8a49-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 12 Jan 2024 19:49:48 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40CJjcvt034986 for ; Fri, 12 Jan 2024 19:49:48 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vfuu9pcq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 12 Jan 2024 19:49:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OibeDnQphYPoOGv4SnyA/maG7/BdfYIy2lt+Xahxpgz6GyH1XWRl/gH0ZEI9/S/aHxNKT2COF8FyoJTJCuC7NPuHBqA9dwqS0uQD1G+YUmZAtWgJTdja7I5Z1OCYJUztoBjfjFCV4kpp/hGTxWFvMd4cWAlAi+YnuO+OyXgPokT7odr0+4Cs3/XAG+i8jArE9bGepTpYaKlFyz0EtLQz4aU1H8sJw888mAZs+fTdw5DdYACba8cjsZOcIeGbdvrbmNLrmDG6jV8ySUSAcT9hAY77+RrBiteuV/Qu1Tbwcb5BEKKpr4qEs/RyeCgo5+QI5GujKvh/A0cEJMa7593yGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mYusHsmoHWyeH34oEYm+sEW38ESTJE5PBINR4NJsFaA=; b=awW/BmimB8I9nl/ep80z0/e6VB5N/Drdu9zl6Xley8B/FOA/baCrHH6TtgbZ57a+BH+xgoN5Vl8C/h8tl/smJxxxgRlmTHjD5RZoKux0qTM4TvGdHkwOpJeBG34qt3ESOG/H2gxL4H4UlUHd9+A7MqL0sZmfk7qGyUkUy9e3MWpO5GG1l1tC640LHflYM0+U54GtzTKospaEks/94Xlw5UYBuF2YTPKo80F+8vRZ0N7Xn1YtSL/NNKRu2BSGaE9qUUMfqwARWyT1CitSHEQ5Rt6Hnv2DBQya+mNyIa1+1+YmvaruDG04MWRJpq2hWlABCCdTNavaXUZWPrWeQnNkbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mYusHsmoHWyeH34oEYm+sEW38ESTJE5PBINR4NJsFaA=; b=KEDe43JCokETlc1v2TrCXnxuaUro2NDyGils8lCwcKqFG+mOPSvJPTufZp3oAdwXdpLkgOp0w+fd/LihpjCSeXZbxD0i6s1stx4YYT/2C1YFVhAoDo/KfgMr/PMYaQpYSXJ3gZdL0xuRtYFlDmv1X0Xr3QTUQuWLQgJSebWUKzE= Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by BN0PR10MB4967.namprd10.prod.outlook.com (2603:10b6:408:123::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21; Fri, 12 Jan 2024 19:49:45 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::5b9b:a8a:21f6:a505]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::5b9b:a8a:21f6:a505%3]) with mapi id 15.20.7159.020; Fri, 12 Jan 2024 19:49:45 +0000 Message-ID: <3c5bf4e4-b8be-f36b-bd05-9e0f0063b234@oracle.com> Date: Fri, 12 Jan 2024 11:49:42 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] gprofng: 30889 can't compile without large file support Content-Language: en-US To: "binutils@sourceware.org" References: <20240112041054.1836291-1-vladimir.mezentsev@oracle.com> <87ply652nu.fsf@linux-m68k.org> From: Vladimir Mezentsev In-Reply-To: <87ply652nu.fsf@linux-m68k.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PH8PR07CA0030.namprd07.prod.outlook.com (2603:10b6:510:2cf::16) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|BN0PR10MB4967:EE_ X-MS-Office365-Filtering-Correlation-Id: ae3484f4-e9cb-4b35-4b8e-08dc13a7a091 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ox3ET6KWvAHeNXbg0iBHk9IF07xbrbdTu+80C8RDwmdgu6L57G1Aot+OyKIKkxldpYRKmZfVb0LGZSMS3TDuwE4BD780vSMfQPF/h7bwdaSFjrknOe/WVIWD3BztRnzdHqR4a7ZRmMFHa16+2/w0wHjZFUL7Pl3BHabQcpwEWya7L8ezpyo4XiUUugQhbfz9tlDpchlPcRTD+dYWWZkJOMvYy2L7nSU9b7ijeA36Ys7m7U6z3/eyPYvWdhGd+Fj4N3XyOL978rELytQRVCn5Sz8++4Ui0qlMckQ6iUIVhle2+8Wrl4MrPgbxyaoJ8U29a4mCqCZNYvCT4PK9B6xZcWFlCoDXZqUf6xdKCr0S1Lnz2jLusxD4ceyY69nnPWJRvUt3f7MDu/R+jkJJmzdLJBeW6f6I5yZ9hcjCeCu6CWCjJzirWP0sGriKH0ZsbisgocHHBcZLfrlSmHPsexmI0QUO15pS33/QVjteAneDxhtyNbfyv2kUCjy/0gkp+DsQ+s/fRxHq8UKX2Akr9ifwZxAHkm5fpZQXzJYjUI4i6/+Xzrx1mgGI1vm6wDMcdcLVE4cNWhC4SEDwrahtbAkw3duf213IhwqybkZye3yVH/wSRjnpZsCU9NTM5KbuxEyJBWSUjRH3/0mYS6/3b7KIgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA2PR10MB4636.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39860400002)(136003)(366004)(346002)(376002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(31686004)(83380400001)(86362001)(316002)(41300700001)(36756003)(31696002)(6512007)(38100700002)(2616005)(6506007)(53546011)(5660300002)(6486002)(478600001)(6666004)(66556008)(6916009)(66946007)(66476007)(2906002)(8676002)(8936002)(44832011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGhtRERVWXFHZGhBelcyNDVETXhqS3BKWGJHd0d3V0ZzMXdOdGFxUXZ2M29q?= =?utf-8?B?UlhjdjRXaEVuNmhSRmFTMUs4ZVdGSytJcTIxa21HclZUb3BldFBJQ0d3MHhD?= =?utf-8?B?RzJkZnJ3VksxaDdudXk3MW51K056TkdBNkdxYWJPblVTSm5CZXRJU1B2VkFs?= =?utf-8?B?QnB5T0RBa2NENTBjZitzRTZGZTdpc05LbTcvRm4zamdkdVNqeFNRa1RsemJv?= =?utf-8?B?R21IbDEwY0N1YXlwVDNYTGVhTWFKWWMxczJzVlBCeVhWVnRNbGRGQjFsc0xl?= =?utf-8?B?ejNUeWJNdHNFRDdXQ09IdjE5M2xvcldzM3J1VU1HSGtTMkVjTEF0d0Y3OFhH?= =?utf-8?B?U0dsbTZaRXp2WUVUSnp3UitESW10ZGVtU2lPMUoyN21xVzkwMGRBTjBRRmtl?= =?utf-8?B?Q1YwcUZrUVVPeWd2TjhQdFVOWFZDYzRCOHdqZytPZ1IvK2UyZlBiUmJWWjNy?= =?utf-8?B?ZWxpc2xTa0VxTXFOLzBVN0lDUjNSWHl3Q2FsSU52UGJ1U2JGNkpvNHAyUTFp?= =?utf-8?B?R3lFbi9YUkZMR1A1bDhWTEE4c1YrUGY5NU9NMkZoRy9ITFBCRG9mbHdvNXVC?= =?utf-8?B?cEUzdlhkcTF5TS9kc1JFaXdzclFZV2lCRnZCMzErWS9yRi8yQUMvZHFUcHRv?= =?utf-8?B?eTN4Q042QXNON2psWGVobHdZWXUxUGh6SGpmWTJDWEdSZ2daTWVRbHZIbm0z?= =?utf-8?B?aDNTOE52MlVJZThNZkNoTlowYXlVTUpHcDRPZUlxR1ZrWkdhTmRZbDFWWmZG?= =?utf-8?B?WmpyMkpNcVBCMUpYTzVyMXdJSG9YQit4OERTeDFBb21LWjdEeGRJTkwvSDdv?= =?utf-8?B?WFBTbXltSUJwWWNhSXNENTl5a016TWdZU01ObzVGUlFuSkVaeEQ1M09LOWJs?= =?utf-8?B?WkM0N0JJRW9vcUlHM0ZtS3E1SDNrOWYzSzdaWTY1YiswcUM4NFNlWUdSY2g2?= =?utf-8?B?UGgxSDhEWWhwZUsvVCs1bXgzY3R4WmgwL0hPM3BMOHRyVm9EOS9HQVhQUStr?= =?utf-8?B?cEhvY0ZLcG5oUktkNzRrbVloTTRLN0IzRGhBOTBuVGVpdE5hWXlaNG8vQTlz?= =?utf-8?B?elp2T2FCUWhaSFJvM0pYV1lQOWl1enJxSGFwQmZHNTJPc2hwTDhIY0lzKzRy?= =?utf-8?B?dU1VUFMyZklwZ0tNRkVObTRIRzNhaVJOODROME9YWXhFNmhoNFQ4V3B4WUhp?= =?utf-8?B?eGNHMHJKQ0ZZczZQYW1TclQwTVNoRWk1bkg0Rk5tNW8yZFlzcHNxRUU4TTlO?= =?utf-8?B?U3lIMDNpeFZwZFpJY1BEVE9sR1JuSG52cGVtdjhoOEZMRVhaWmpmd2FOVXZl?= =?utf-8?B?dHNkN1FQTUVaS09mVFJTWHU0WkxGSUtZeHh5aGJFSUw4cXdrbEswSG9wY2Ji?= =?utf-8?B?S1ZFTnFpd1JCYUVlUHloaDUzb2Y4T0pGSk84V3gwZ09EZmpOYjFjZWhKN1lJ?= =?utf-8?B?VTRPU3Y2WVM1RStNemJNZ2l1azc3MGQvSFRQUzdjQUdJeFJJRkZIalJjYWJw?= =?utf-8?B?c25QdXVZK2MxeEo0djZYRi9NNFF1WnhZd2E0cHh6K0lxU3BZYXJWREdTblBI?= =?utf-8?B?RmlCekhuci80Nk5PQVFsVFZJZzRJYVdpOVJ3ZUNyNjJ2bW1QQzNHTTBRZkVL?= =?utf-8?B?M09BOGdacEdVcmxsbEMza3g1SVJPZDh4Ulh6VmtRTS9oZlEvRXRrLy9LVmN4?= =?utf-8?B?cUV5VitnQ2h2SFRabWNRRGhSY1F0NG82M2k3K1l0dVYyM05YdEgxRUdSbXpV?= =?utf-8?B?V1FoRnM2TDZtQkNweHY5VktwUCtFRHYxQjV0c1RRUjVBWDQ0d1J2QS83NXBW?= =?utf-8?B?SVZ6M3dmQm9IZzh6cklySlAzTHJFYzduYURnQlRtbjQ5Z0k5UVdCL21oWU8x?= =?utf-8?B?Wmg2WmgrN1ZCQmNYa1BnQ1pWdHFTYm9sL05WWksyREtoN1NCSTJaM2ExNHl2?= =?utf-8?B?TEEvdERRTUc4alNBcGswOEIvM0QvcFZtV0FyNTFwRkU4NzJ4WENtZTRKdkdW?= =?utf-8?B?OXFWbm1aVVNrZ0E0K3ZaeFI1NkNON01IQitUSWVTMDlnMjlMK0NFNHB2WUFn?= =?utf-8?B?djNOZDgrNkZZVDhxQ09Dak1mK1ZyTHI0dEg0SEkxc09TODh3c0kvYmNaYm5o?= =?utf-8?B?bUZ3OUpueWxXYitiNGhsaVUvZEFYS0VhSUZGakpPakNUNUp2bVNkdCtsK3ZQ?= =?utf-8?Q?at/oa5GbMJ7VCWvmYEdkjok=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4otClm69uqCxMvRo6gE9hMBiEpgjT1nF/HQmtGLkifbLJqxQbXyb7V9r7yOUtouEnHxfSAmyp+tIONmbg3q/zix62xt1hv1dfP7TGM8rfuZMt5lXQn9WTJKGi7bRrv12GygUuOw2hGYdZDUSEsljqg4J018Mxy/8taZoPQZ7BEifxEzWneaErAPuGVdS/Ag5tpzbmBODSUv/UimkGdwciXWHlF+T1BojP6Xw/fVX/vtdrbKWhT/x5j1jVYlUqP5ofpBQWhLeQnJmFo5w7Xk5j/9ZCvvUHczXpajl5o0fmYFHfBqZoLEHBiD0JBH1J/vrE+UQWhuxXqbe7DkQ+oxRESmk6yY4c8IqEf/2p32fXT0m/kTUXLlHpDXBpNVX5EC2LSBhkQB4l95NKsewt75uQ43paCG5voMP8d5uOOi7b/SoKUR6C7WFTp2I1I2WOjirBTV5LhbIKt9qW1krZIbacUWBxykvQJxIYE0mR2vUkpPwft170MdH3g4C2jG2gaU3HnCJ5uLn+P/lU/h4Omvyml37dLXyuxskFSSIzYdCcvfZMipi2xZSyo2vvHtOMqhOZVLAqm0dh3KiFt7TlLbudtUGdHp2YAbRrwVJEnKhqsY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae3484f4-e9cb-4b35-4b8e-08dc13a7a091 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 19:49:45.5939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1mxOPdnUuqal9QZdcSjohH834T+C0QP45L1FasrmRMlHziyDvVN4rGDl5BIjT9dC2Zgy5W9ixx02ciO55Z2S7LxuXMgXsFRAxuJEUjJO/gk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4967 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-12_10,2024-01-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401120157 X-Proofpoint-ORIG-GUID: r168UQYikFuDp6vv55iuT2fd6hLFeFDZ X-Proofpoint-GUID: r168UQYikFuDp6vv55iuT2fd6hLFeFDZ X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/10/24 21:53, Mike Frysinger wrote: > can't you put this in a single header file (gprof.h?) instead of > duplicating > the boilerplate in a bunch of files ? > -mike On 1/12/24 01:20, Andreas Schwab wrote: > If you are using open64 you don't need O_LARGEFILE at all. An autoconf > check is overkill anyway, you can just use #ifdef. Agree with both comments. Please review the new fix below. gprofng/src/util.h is included in all files where we use O_LARGEFILE, and is always included after where O_LARGEFILE may be defined. gprofng/ChangeLog 2024-01-12  Vladimir Mezentsev     PR 30889     * src/util.h (O_LARGEFILE): Define to 0, if not defined. ---  gprofng/src/util.h | 4 ++++  1 file changed, 4 insertions(+) diff --git a/gprofng/src/util.h b/gprofng/src/util.h index c6382aab5bb..cbbc2f7e118 100644 --- a/gprofng/src/util.h +++ b/gprofng/src/util.h @@ -32,6 +32,10 @@  #include "i18n.h"  #include "debug.h" +#ifndef O_LARGEFILE +#define O_LARGEFILE 0 +#endif +  #define SWAP_ENDIAN(x)  swapByteOrder((void *) (&(x)), sizeof(x))  #define AppendString(len, arr, ...) len += snprintf(arr + len, sizeof(arr) - len, __VA_ARGS__)  #define ARR_SIZE(x)     (sizeof (x) / sizeof (*(x))) -- 2.31.1