From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id EEF7F3858C2C for ; Wed, 5 Jan 2022 06:54:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEF7F3858C2C Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 204NiDEf021552; Wed, 5 Jan 2022 06:54:20 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3dc40fm129-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Jan 2022 06:54:18 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 2056pd7N169663; Wed, 5 Jan 2022 06:54:16 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by aserp3020.oracle.com with ESMTP id 3daes4rh4n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Jan 2022 06:54:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=McDC+RtAMVfNZ/euzy0sceCoHFfZeXttp2fiPmd+EbARjRu8LQB90Uccc19vucQ0k4T/zQ7fSiYbWL2lPzdsy9Xxmkcye7vtLjXNQ6TJA94B0OuLvBxuNEq8wJhlGwcXxUyZQfUkr3oascg3N1L3nYD1iW9lzqwIJ29dYK5SskQEbx8azAG6pgZPjIem29TSb+PhB9NfxvvprlQ/A5yGL5aoLkJ3cWkSvHRcZ1T7wTK+Nz73KETC9fQtNsP1kggCN7HJ4OGiMhz/fuWa1LUxeE06RuiTgzXXf3s6jecDQmMnHZkpKW3AZa9poke065pm55+/K+d+093IrXv9JICzxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S6Wh9WOrl+DYoZryvCOR5s/xblLjbpduHcgHkfeselo=; b=ff/lNHdG8Mxdlsafh5x+cpk5ittTp5dL46A+9Xsx76iz23WwtpekkXntio1z//Ibq4IahyrlFg2HinWEHpZh860LfXqDSSJDN44pq+WeMKLqJ3kLWD8hGOQu47OIu9V1MZJldafvfbJ25crdYkE/SOCAUdqpYNjk+zfJZ2tK1CXDJ5UmAOfxJwkYEnfhhiUqBvrAMu9TMHZ7OZ58I4FvRA/MImswx29ZedyKgw8McZHlz+912DTjWQWauao8HfFIjdzzJ414lduHzuJf5Gt/2g+YK06f8Dv+S53vVHBVZ//R3rCqO798T6xwxzHthPAHwD+ufqsgEPkd1C0NE8PEww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by SN6PR10MB2430.namprd10.prod.outlook.com (2603:10b6:805:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Wed, 5 Jan 2022 06:54:15 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::48fd:915d:dbc9:d136]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::48fd:915d:dbc9:d136%8]) with mapi id 15.20.4844.016; Wed, 5 Jan 2022 06:54:15 +0000 Message-ID: <3c7b1732-065d-89cd-ac0b-b6a5bc2098d8@oracle.com> Date: Tue, 4 Jan 2022 22:54:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] opcodes/i386-dis.c is not thread-safe Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org References: <20211220230417.842662-1-vladimir.mezentsev@oracle.com> From: Vladimir Mezentsev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN4PR0601CA0004.namprd06.prod.outlook.com (2603:10b6:803:2f::14) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0efcc45-18cc-4f83-23b7-08d9d0182fa8 X-MS-TrafficTypeDiagnostic: SN6PR10MB2430:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NK00v3vv0nrZPPHbxhULxiTh9rmeXr+t32dpgXOvXdM2sIe1lPB7/7/jlZHnfCDuenrmS2YXpfeo8B6O0vW7FeWncCJj7RfTDpFzbEJMHbYl41UKu+/oPrArSxH11rlznyiMaAxEeDoSbedDF2wvKY10ll+bP4fThX10hXLKwCsXqzlh2aUXqQJfA9jBNLElVVFG0f6yF2Pn1oiuerjLIYEOtKJ8uqSTagpzn2E+R3Q3xcwEF3jXrzj26UsqikWlAFKX8FeF4/7gGxEu7ucC4TDnOStkxZJSTf+yR7VM2kyzeNoV52nuBHn6pwpIBojSn+4kSrC8S+VQygF3eD6CkonxTuOtjM9yHixZXlPowJyzJEsPEZUSeFVmuOkLb+x/UGzEotL9sB/Pd8limrLLxLLEOoGNGv9YQiLYX6f6gJGO8spgwXO2Ts19aB6W6F5JN4vRKDF+nT8NsYNCZHSjN7Pt0iHEAKhm/et60iqa6zL3our3odLRAoFSAW4+VdVFXBxlyjJjDLvqA/lLTkl7OsK/vWfFK1GRIZpH1FXnGWdnpnSyiPrB/uxtvGFrbjAkheypDbHqCbACzq7k2Z8DUt61+x/Wug2GZ4vZVtIau/Un5KIiTM+c/vbtHB6cbovYmy1renzzoYuUPdR//7/yU4akCsbwgnBkd52ypv5njO8xIGQO2I3JFN+tf7EzXn6MLj7u5g7io7Ey8yHjvIvsSjy/+j7z91yRJhcreN0h+LuTS182oU1Wietl7984IezJ8NKZvpQMNNX7BFZ1Eavzofi340Uc7zlFuJu/gLiJlfVP217xLPGRGafd8hiBV9sQle+o7y1DDbmu5tZpM9KXqtg1yWnxZdmxj/J8W7mgCkw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(2616005)(44832011)(8936002)(6666004)(31696002)(966005)(36756003)(186003)(508600001)(6512007)(38100700002)(4326008)(83380400001)(5660300002)(66476007)(66556008)(53546011)(8676002)(2906002)(6486002)(6916009)(31686004)(86362001)(6506007)(4001150100001)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnRLSXl0d1MxeEVXRnZ3djZkTXhXNWhFOEZlK3RHc0dUK2gvdUxmbHgyOFhC?= =?utf-8?B?dTlYSjYyWFM1MjcrZDhxbi9ZL1hOMitBenYwN2ZMM2lDQngvdC9RZXBvK1Np?= =?utf-8?B?bVpqQTlTbG5MTUUvUGNqRXBJQ2dqVW53R2p1R0hobC9HQkFEMWIrcXh5djE4?= =?utf-8?B?cWdKZVZoOTJuUGZvVWpOalhZb3QxTnBLb0N6UUplZklweUxYTDVIcDUzeG4r?= =?utf-8?B?NUpzR3lWTysvMlFhWXptYjBDV0lkUUpuM0YrU3AvQlVZbDd3MGZTUGhpZ2hj?= =?utf-8?B?TlBtWkZBeXBwaWVpVWZsYXRIY3U3ZFk4UVNUS3YyN3JvdUNTZmF2TWN4VFp1?= =?utf-8?B?SHg2cWVSV1VHVG0vV09aYlp0NVlQbjlqS3RQWllhYWljY0NhWFZydzl1RnpB?= =?utf-8?B?blB3R01nRUwyRml1eGZlendhMUx3QmlWOVF1cEtHdmtMRDVtbU9xczJMbW0y?= =?utf-8?B?dzVuZURhVG42RFZ1ZmJrVU1nVkNKZW1ocHlKbGphdTdaOGVzSWNPaUo1YXJP?= =?utf-8?B?ZXQ3RHBFZGZxQWZXajNlQklVTmx1NWFwa2xHYkJtNndHc2JzRHQ5Zm54UmpL?= =?utf-8?B?K0x4MlJ3aExLbjlkc01vaHJPUE4yZUZNZFlVcERzSFpsVHJEYzVud1QxYkVY?= =?utf-8?B?cnpJaHdscVF2enRuZERyQ0gvUmNiK2NBbTEzUTVxMzkvdG5raTNWUG83dmRu?= =?utf-8?B?UjNJZWM4NDNsWXViTVN1dURlSEF0bGROOGdPRWZBcG8wN1V0YmlMclFPQkwy?= =?utf-8?B?Ry9PeDlxK3VqZjVLTkRvbXJlMkJhWEM0YlNFQkoySnJzRm4wVTRpa3Jva1JF?= =?utf-8?B?Yi9Jays2SGZqdGtnQ2dqN2ZXZTUvbDRMUkZnTEFZRWJsUCsyMm53cy8xV1Fi?= =?utf-8?B?R1NCamdBOUcvWE8xZzFFU1BLVHluRFE0WHRhSFVXdFFxSXFkSnhuemREWU44?= =?utf-8?B?c2tWZU1CdzlUQkFqcjI5UlZDOVlxZG5jZWhPMVByLzdTT3RjdXRncTFML2l0?= =?utf-8?B?SW1RN1VndTZVVi8rZ3VWMTBHTy9pM3V1ZkM3TGxvOWVvb1h3cVZKV1M1T2xv?= =?utf-8?B?VEltWitscGxUMVhGLzVWTW5aU0lBMTZoQk9IYUIralU3Rmk2emNjRFUyZ0hw?= =?utf-8?B?Ym1Kd3NaWE94aXQ3aVovYlVmc0VST0d4ci9NV3BiaHNUWFBrNTVpYzVhL2Jw?= =?utf-8?B?ZjloYm5EdTNuZzAvSlEvS3FQK2tIUkd0TmRCMlg1TkE0dzJWUXBncGkydW9G?= =?utf-8?B?ZkwvQUhzamtXQStmbUU2eDVONjM3NDBQM3c5T3Z0SysxaUJpRmdlUzlvRURW?= =?utf-8?B?RUdlczRuZWl3eFRmVVFmMWVNRW1NVUhVUHNNcGZmdSs1RjgvcDBWaSs3cDMw?= =?utf-8?B?RlU1T0h4Y3B4NFNXV2RpVEMwZXcvZ2FLWnlHVmNkMkJQRjVQZ0t3eTJGVzVj?= =?utf-8?B?RGV2clNkbEF2ZGY2WVBKYWd2YjVMRitvK0lhR0JndUVuN0hidi80MksrYkUr?= =?utf-8?B?eFZvOGR0M2dBcDAwRVk2SUpQbXN6VVppTUs3cEErVldpTnkxNGQ4SU02WWxG?= =?utf-8?B?YXN6Wjk3bk9saDlMZVBjd3JjZ1dubmFxeGJqNm5FTmtHZjFjR1o5TDczOEZr?= =?utf-8?B?QURQZkc4aHBHZXJhS3JIUUpQM0NxMjRLd1h5cU0yNDVydG51dU4yQno2Z0sr?= =?utf-8?B?R0EydkNxd3k2d1hEbGVSUTZaUERhQjNPZnVCNkw2Rko2aGtSdlN5NjN0VlFn?= =?utf-8?B?dFA2YnBsOFdRa1VZWXdQRlhUZWxKZm1vTk9LUC92UVMxWnlEM3NHWmRFb2ZI?= =?utf-8?B?WU4vZ2ZuUVdVVFNSQ09tNzAzQi83TDB1eEg2T0FHMy9YRUxvaTl5bDVLbEh2?= =?utf-8?B?aEl1SlM2aDY0dHF0NmNNZVJZS0xGcHF5MzhSK0xTZnNCYUh5K25WR2Q5dDVU?= =?utf-8?B?d1JuRy9JbEVQR0lpQi9CV0s4dk05VFBGa2I3U09nR0pKa3BiSTVVaXQza20z?= =?utf-8?B?RElIL20yRTd6U0xISXhoZTUzZGdEKzBtTnVsOFV4ZUpUaU1CR0E1YW9PSC9u?= =?utf-8?B?U0UxakJXNkVmUDlQR2k2RVJGRjdzQ1E1WkhjZW5qOHFSdEhyMWV2dXRtajVm?= =?utf-8?B?U3Z4RHBYbVFEcVpYemV2SGFxNDUrL0F2OEVWdUJRRUJSUVhmWW1vVzVkR2tQ?= =?utf-8?B?aXZERTFBdGp0aTZobUlnRjQvQit2S1UvSUVpWG5YZEd4VXRoM1RPR2NGOE9I?= =?utf-8?B?eERFdk9lcXk5WWUxdjM4YWkweEJtbGQzWGEwVmVZbnVtZWhjMTNIM1cyOEg2?= =?utf-8?Q?rkqdIvk9VCIAAKsm0i?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0efcc45-18cc-4f83-23b7-08d9d0182fa8 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 06:54:14.8728 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HxQEZt22pmPvHXSrsG0GMUcNtuAJobGlpqP3D+sAqUEjtJocngC4Tet0fGxDrcbJDPweJWDe6fkL/9hSi/ZOv7KORNikfiWLVfS4/fIgpd8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2430 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10217 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201050044 X-Proofpoint-ORIG-GUID: 3Ua-XJuf3nCwyD04YvykU6D4yr0QaWPg X-Proofpoint-GUID: 3Ua-XJuf3nCwyD04YvykU6D4yr0QaWPg X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jan 2022 06:54:23 -0000 On 1/4/22 09:47, H.J. Lu wrote: > On Tue, Jan 04, 2022 at 09:38:40AM -0800, Vladimir Mezentsev via Binutils wrote: >> Ping. >> >> >> -------- Forwarded Message -------- >> Subject: [PATCH] opcodes/i386-dis.c is not thread-safe >> Date: Mon, 20 Dec 2021 15:04:17 -0800 >> From: vladimir.mezentsev@oracle.com >> To: binutils@sourceware.org >> >> >> >> From: Vladimir Mezentsev >> >> We plan to use print_insn_i386_att, print_insn_i386_intel and >> print_insn_i386 in a multithreaded application. >> These functions are not thread safe due to the use of static variables. >> >> Tested on x86_64-pc-linux-gnu. >> >> opcodes/ChangeLog: >> 2021-12-20 Vladimir Mezentsev >> >> * opcodes/i386-dis.c: Make print_insn_i386_att, print_insn_i386_intel >> and print_insn_i386 thread-safe >> --- >> opcodes/i386-dis.c | 3488 ++++++++++++++++++++++---------------------- >> 1 file changed, 1754 insertions(+), 1734 deletions(-) >> >> .... >> > Please follow GNU coding standard: > > https://www.gnu.org/prep/standards/ > > contrib/check_GNU_style.py in gcc source: > > https://gcc.gnu.org/git?p=gcc.git;a=blob;f=contrib/check_GNU_style.py Thank you for links. check_GNU_style.py really helps. I will send a new path after testing. > > and clang-format may help. clang-format reports no errors now. But I've run clang-format after  check_GNU_style.p. Thank you, -Vladimir > > > H.J.