From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2064.outbound.protection.outlook.com [40.107.6.64]) by sourceware.org (Postfix) with ESMTPS id BDDFD3858425 for ; Thu, 27 Apr 2023 08:26:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDDFD3858425 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AM9k/6zFXuQRdKscJzwvnXSyfyvS6JV47Yax9aiDRVALjFvephxpn9IGQm1uQLP5wacELveSFz7yVMNPlWih2zvyfEF4pYIV3tIQX4LQFvyb/SAUgdmGJeEBX0ISLEmsWNjw0WyoZpI9DnHkWuTOFYLvlSqVjA4aANnMQ0w170/MxK65LZcyakzKCG3eFdrlrhPMoBb/EeHGY4kCinY5mvlimtro/1a9Oq9vryDuDnd3GxA4BkaizRkTHUBV0M7RiLke0s7vg+O7x10alUJ2Mf+FTeE/bNxkgYQ0QXCASaj1uUj+SWzI1tUIEpfw5kj4Jv5zG3vatWILgcAnHVdMSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eU1oCeHhB0l9dqF9mfNDVrS7t8tWgalQZrxX1ZvAjhA=; b=Wrlf1FJC6kc03b6+bxv3j+UdsEt/UDGrK7A7mJ1vVpYdSG5zptkghOzT14P6XzwgQmR7IIUY8vxUmi0IsJbphkezUVKexegUaImFTpESNbfya6SdAxdRiPHk4YlZxnp8hJTWOymyTK1kvv3tqx7gdUWYZVWeDS8UcfrYD/HpEFAw6NUPv4C8jt+jtLy+8VBh5RD7hEm4JBMN2JydYVid/logR/bew+XHZr+RZH+u25oGxRlJxYe01lHnb/jP1SGmzXaGqY6xiZfJjUEQM5SNJNc2cHRw+0igOKW6T3K2byJR5u3t0VIlRwgpKvy703UDIg/gM7sFJAGD03zdccvA4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eU1oCeHhB0l9dqF9mfNDVrS7t8tWgalQZrxX1ZvAjhA=; b=pHHSFVMV73XHz53w66Is3XEmK1MEGteIA3MfdwZwUzHqY7z33KIu5ETEQIcFp8y6Jk3+7wgfO/VY/wrOW8Q12Gt9EkAPF/ZGj99bc2Hm22/y5uPQCrpkckclRaNJg9Bjba/J+OSVrcFa0ul6dWx56zWWE+iihSxZ+arEtCKBrqz2BAGNDgTQoZX6L5wovaxASI8zrQ0x+ObpVcW+H01UA4PYjaHhTO2AWEONldgwIaA7nP/qHpebsE3TPOsCAtGRKDzp8T0tHoU2+34a1FFO03horka1fH4DEnAnruUf5lWzQwh4yv6pRu74DqaoJwfaaF1L02Bzff6TbjTkns7sMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS5PR04MB9942.eurprd04.prod.outlook.com (2603:10a6:20b:67e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Thu, 27 Apr 2023 08:26:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6319.033; Thu, 27 Apr 2023 08:26:15 +0000 Message-ID: <3ce08588-8065-473a-2ff8-d2c412406cbb@suse.com> Date: Thu, 27 Apr 2023 10:26:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [COMMITTED 2/3] gas: BPF pseudo-c syntax tests Content-Language: en-US To: "Jose E. Marchesi" References: <20230426173123.24564-1-jose.marchesi@oracle.com> <20230426173123.24564-2-jose.marchesi@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20230426173123.24564-2-jose.marchesi@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS5PR04MB9942:EE_ X-MS-Office365-Filtering-Correlation-Id: a4554a96-2167-46af-3a33-08db46f9114f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R5iH9dC5iXN8n8cei/CJ8eJyy3KYWkQjPyfqT9QXsdnwnbxwfgFOfWj9GRX7Vl1YE8/ZKtTF7q6F1KhgDRUZsEDHlh0CvNjMIuueEdnaxp2bpTJjH4Dg9pVJWXEXELWGTmgsyfn14CJr45igLRqvA6Co4kYFUFjJeSou2oBo+W5jwC0n8qsVsHTcb29eNbR4Q3GF5wf9aPiM6ocimSPrBtsTAZ4SJ4rWHEjRpMAFJPmMpNDchQhCbkcQtpSgRfXaIFi2a4ZQp6BtzPAUS3efNYf7mcWcJK8g20SxX6mQoBnWnufFRrLL9Xg+ejpys/cNP4kQvJ72i/As5nYy37Rps0mGhxIgd4q4DOQPUqRGC7h7qVfo8x3WzGOkDKxX+wYq0da+cHkv9BGtDMCwUK7pCk3nJYNRiNrlw4JTbQ92LhaPjPd4OmrZmczp6EGaM2vVAJ1OjANCoSLQ93Nd+8F6MhF3e/edBBcJbZ5Rp7Xx9VrHU4x0Ec3FFpg0OV4LqRU4eg275D5yIT61E7SNz6m21m08atsoYwuNb+m02eGMDLlijU/ejNakoyojyWyTz1quMuFRj7w2xiINqc2zd8gEEhteR/TwE9mRp04mQLEWcgVaV9LXXAFN2T51TxybrO+W6w6pR/NaMUlDNPgy8eFmxg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199021)(4326008)(66946007)(66476007)(66556008)(31686004)(5660300002)(316002)(41300700001)(6916009)(8936002)(2906002)(8676002)(86362001)(31696002)(478600001)(38100700002)(6486002)(2616005)(36756003)(83380400001)(6512007)(186003)(26005)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWVrc0VSZ0RNUDB4SHlmWEY0cVJkQkZpbzdwN3pjYmtwQ213UUh2VHYvQ0tK?= =?utf-8?B?VUs4VlN0NXZUTTcyRGNxYzZQVDFwdWRvWXdHU0MyWC8xcTIvSzhtYmU1NjNx?= =?utf-8?B?M3lhT3QrQUpzZ3NjS3F3NEEwNDVFUmhxRjkvMmlaN0g4cEpyLzhQM1hiRzdO?= =?utf-8?B?S2Q4Zk1JeXU0SHR3K3R3SXdSR1diL2VzL3VVUk9pQ1VtNlRJdXAxZUxSejFq?= =?utf-8?B?WFJIT2wwWHRRL3ZHWHh4RWhYc292bHpRQ0VGcHhlOVppVFVuRUt3ckRFMjBo?= =?utf-8?B?SytKeHVCdFFQK3ZnUVBsb3EvQy9aeWV3Y2pJRUFWTWpWTWtqQzZvSFZyVzNT?= =?utf-8?B?M2ZFZWNMSkNHa01Ra3oyOVdtVU1kUUc4Z3Y2czdzeEY2Y3ZreUFpQkx0bkhW?= =?utf-8?B?WGNmdVN2a2JMVUJYSEtMdFVQZHNPOWtPVHVTcjJzcjNoSVpSbmx5aXUrNXE5?= =?utf-8?B?RjFxWWVVbUNGWk91Sk9xa3ZKbGRiVitOcnF1N3hnZVJMOGZQMXJ4ME1ibWFm?= =?utf-8?B?QktwQnpMcS9TZDZBN1loMzB0KzE1aUVQa28ybmlhWXVKYysxY1I3M2hCOWM2?= =?utf-8?B?V3BLZUJVVU4wemxsWTJ1Rm5RR2d2MmNoVXd5RHAydVljd2ZzcEtQeFJXTXZp?= =?utf-8?B?QVNmYTZZQXNBblVTb1RpOC95QXk1ZDRZUVhNOEhaWjQwb3BGMmZsWUFzTTdB?= =?utf-8?B?aVRPWXliTVFuSS96UmgrNTRnbVc1eWY4a3RiS3FMQUhSK2RuTHEvQTNOTnBG?= =?utf-8?B?Y0hBQjNTY1Rla2x6RWtJcmhsQWJ6VEVDTERNcmN3cWJaQ3NFRHhNMEYvbjQr?= =?utf-8?B?ekFwZmxoRjNhdEI2cW12c0xOOXZrM1NpVlc4bmorZG5kK09jb1NJMnRvQndt?= =?utf-8?B?Mm9iYmYrZmt4MWZUTTFsRDZXWnNoMmxFRHNvUmZzbVlKYnRxY2ptSEhiMENo?= =?utf-8?B?WE56ZFE1T05ZcW51U1JhQjlnejFQSjFld1NSakg1UXNMcUZwMUhQR1Rubm5D?= =?utf-8?B?aS9YN3VIa1pkZm5ncmNVUStZY0VXdDM3SUxqaTFmK3JwdkNHU0x1TE9TOHVB?= =?utf-8?B?b0thdTNENEdzR3BIZDRTU1BkbGlzVFhweVUrbm1SME5aOWNVbUN4dVl3Q095?= =?utf-8?B?SllncThlUExTQVhnZEQ3aVpVRFFyVDBxejZsRnc2NExmNDdpWW1jOUQ1Zjdu?= =?utf-8?B?bDlwVkdKM3RhUGpZdmRwYVhEV1FKK2FTNDBFZW5JejgvNU56U04zSEpEZk1h?= =?utf-8?B?ZmZqclZzRHRNNkdab0k2QkZ3QjREZkRoTnQvTU8vQjlWcDFKUU9raUhkSDBF?= =?utf-8?B?MWIrOUFYZ1U0QkdpZjVIVmpyWDBPMzlvc1lMTDFUNmpsRXdTdEZtN0xaRTFH?= =?utf-8?B?d3hFa0ROYXZ0ZFJKZGRhV09DcTdKbzNBcnJnTjZ5MDl6b1JobzU2d1ViQ214?= =?utf-8?B?dnp6dTdNYU5KVkJ3NXZsTzJLWCtWT2ZnU05Da2Q0TGpRVUtzZGUzNVJrV2xY?= =?utf-8?B?d3dEQWxsZG4zZ00zWDV3UlJ6RlZNdkNBa0F4Qlh5eEwrMy9lb0xDUG9ka1ZW?= =?utf-8?B?ditnenVlb3NrTE1JN3dlS2M0YlUvdjRVRCtyZ1ZRc1NCMlA0Zm9pcnU4NnFR?= =?utf-8?B?bVNCbmRWK1BJa0pFdHVIQ2JKYVU2VEJ5ejEzMHBpN1M2eUg0TmtObm9qOUZE?= =?utf-8?B?R3piTzZYOWhmTmcxdFNoQTdla0ZsMGJhUUtiRUxFa0RaWWF5NUk5ZllZL0xv?= =?utf-8?B?WlA2NXpWaDUwbkQreXlsM2pVOCtYa0NvVDRFcGlURlJSRkg1YzNrQ29oREx0?= =?utf-8?B?cmc2c1ZsaWpzbDYwWWJLNGwvczR3ZXBUaUc1MkhzdXpqb1BVbkNIQnRMZkQ5?= =?utf-8?B?L0EzSnhsMTZqVm5lOElwUi9TbDRDRUxpbTVFK2srWDJCU0tTVU1aUEgzdkNz?= =?utf-8?B?a29ZQURoMDJBZ0ZiWXB6ZzZIUXJQenhMZnFMdWlsaldtZFB6MlJhVEhtM0hD?= =?utf-8?B?STVEcFdvUnY3aG1wSTNSaEhaQThrSFdLSXM5WkdzVlNMUjhkS0hKOGxUSmtG?= =?utf-8?B?YUt0SXFMd0NSV2VhZExGVkNVRmNLb0VBZGFTTEFibVN1aXdhczhLNUdaZHlm?= =?utf-8?Q?3Y3YcMIlSlzM8s+99SYzAgbHj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4554a96-2167-46af-3a33-08db46f9114f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 08:26:15.6060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r/4jqZHNF4CVHm3rET0QvmCrmsTnzF39JkdkWgUI5q48ZfBHkHsMgz+b7M71j0826tyKpriH4+koj678VJ8XzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9942 X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.04.2023 19:31, Jose E. Marchesi via Binutils wrote: > --- a/gas/ChangeLog > +++ b/gas/ChangeLog > @@ -1,3 +1,23 @@ > +2023-04-20 Guillermo E. Martinez > + > + PR gas/29728 > + * testsuite/gas/all/assign-bad-recursive.d: Skip test in bpf-* > + targets. > + * testsuite/gas/all/eqv-dot.d: Likewise. > + * testsuite/gas/all/gas.exp: Skip other assignment tests in bpf-*. I view doing such as problematic. Looking at what patch 3 documents, the uses of " = " are pretty limited, and ones not naming a register on the lhs (or, for store forms, on the rhs) ought to be fine to retain their meaning. Sadly there isn't an easy way to specify target- specific flags, or else I'd be inclined to suggest that you have an option to suppress recognition of the C-like syntax (which may be a good idea anyway, as people might be using constructs like the ones used in the testcases you now disable) and use it here and below. In any event, ... > --- a/gas/testsuite/gas/all/eqv-dot.d > +++ b/gas/testsuite/gas/all/eqv-dot.d > @@ -2,7 +2,7 @@ > #name: eqv involving dot > # bfin doesn't support 'symbol = expression' > # tic30 and tic4x have 4 octets per byte, tic54x has 2 octets per byte > -#notarget: bfin-*-* *c30-*-* *c4x-*-* *c54x-*-* > +#notarget: bfin-*-* *c30-*-* *c4x-*-* *c54x-*-* *bpf-*-* ... at least in cases where there already are justifying comments, new additions of exceptions shouldn't go uncommented. > --- a/gas/testsuite/gas/bpf/alu-be.d > +++ b/gas/testsuite/gas/bpf/alu-be.d > @@ -1,5 +1,6 @@ > #as: --EB > #source: alu.s > +#source: alu-pseudoc.s > #objdump: -dr > #name: eBPF ALU64 instructions, big endian I may of course be reading binutils-common.exp's run_dump_test wrong, but is this having the intended effect of assembling each of the files once and checking objdump output for each of them? It looks to me as if only the assembling step would be performed for both, which I don't think is what is wanted. > --- a/gas/testsuite/gas/macros/macros.exp > +++ b/gas/testsuite/gas/macros/macros.exp > @@ -82,6 +82,7 @@ switch -glob $target_triplet { > rl78-*-* { } > rx-*-* { } > vax-*-* { } > + bpf-*-* { } > default { run_list_test dot "-alm" } > } How is this test affected by your changes? It consists of only labels and directives afaics, so insn syntax expectations shouldn't matter at all. Jan