public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Alan Modra <amodra@gmail.com>
Cc: Fangrui Song <maskray@google.com>,
	Jan Beulich <jbeulich@suse.com>, Nick Clifton <nickc@redhat.com>,
	binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections
Date: Mon, 26 Sep 2022 10:08:30 -0400	[thread overview]
Message-ID: <3d0e846b-b8bd-d0f2-953b-7a8d5cd3bbd6@polymtl.ca> (raw)
In-Reply-To: <YzE0qY5KoEM8VXYq@squeak.grove.modra.org>


>>  But what about the other configure.ac files, don't
>> they need PKG_PROG_PKG_CONFIG too?  gdb/configure.ac, for instance, uses
>> pkg-config for debuginfod.  So if the user passes --without-debuginfod
>> --with-zstd, I expect things to fail, as the pkg-config will be skipped.
> 
> No, that will be fine, I think  The reason being that
> PKG_CHECK_MODULES AC_REQUIREs PKG_PROG_PKG_CONFIG.  So the expansion
> of AC_DEBUGINFOD will emit an expansion of PKG_PROG_PKG_CONFIG if that
> has not already occurred, before the entire AC_DEBUGINFOD expansion.

Ah, makes sense.  Thanks for the explanation Alan.

> 
>> binutils/configure.ac probably has the same problem, since it uses
>> PKG_CHECK_MODULES for msgpack.
> 
> I'll fix this one even though it isn't a problem now because
> AC_DEBUGINFOD and AM_ZSTD preceed it.  We should use AS_IF more often,
> particularly when autoconf macros are invoked.

Silly question but... AM_ZSTD was clearly named after AM_ZLIB.  But why
does AM_ZLIB have the "AM" (automake, I suppose) prefix?  It doesn't
seem to have anything to do with automake.

Ack about AS_IF, I will try to remember this for top-level configure
code.

Simon

  parent reply	other threads:[~2022-09-26 14:08 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23  4:08 Fangrui Song
2022-09-23 14:32 ` Simon Marchi
2022-09-26  5:12   ` Alan Modra
2022-09-26  7:20     ` Fangrui Song
2022-09-26 13:30       ` Alan Modra
2022-09-26 14:08     ` Simon Marchi [this message]
2022-09-27  0:33       ` Alan Modra
2022-09-23 15:45 ` Nick Clifton
2022-09-23 15:58   ` Simon Marchi
2022-09-23 18:20     ` Fangrui Song
2022-09-23 18:57       ` Simon Marchi
2022-09-23 20:34         ` Fangrui Song
2022-09-24  5:43           ` Eli Zaretskii
2022-09-24  6:53 ` Enze Li
2022-09-24  7:13   ` Fangrui Song
2022-09-27 18:06     ` Tom Tromey
2022-09-27 18:08 ` Tom Tromey
2022-09-27 18:53   ` Fangrui Song
2022-09-29 11:43 ` Martin Liška
2022-09-29 20:17   ` Fangrui Song
2022-09-30  9:48     ` [PATCH][RFC] add --enable-zstd-compressed-debug-sections configure option Martin Liška
2022-09-30 11:25       ` Pedro Alves
2022-09-30 12:42         ` Martin Liška
2022-10-01  7:31           ` Fangrui Song
2022-10-03  7:49             ` Martin Liška
2022-10-03  7:50               ` [PATCH 1/2] refactor usage of compressed_debug_section_type Martin Liška
2022-10-11  7:14                 ` Martin Liška
2022-10-11 12:06                   ` Nick Clifton
2022-10-11 13:27                     ` Martin Liška
2022-10-03  7:50               ` [PATCH 2/2] add --enable-default-compressed-debug-sections-algorithm configure option Martin Liška
2022-10-11  7:14                 ` Martin Liška
2022-10-11 12:08                   ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d0e846b-b8bd-d0f2-953b-7a8d5cd3bbd6@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=maskray@google.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).