From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id 4818E3858D1E for ; Fri, 30 Sep 2022 11:25:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4818E3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id e18so2706485wmq.3 for ; Fri, 30 Sep 2022 04:25:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date; bh=oypTnMp0Gxylyng5TeWhz/QiduKwO37kwrCSvSXVYTE=; b=H1Eg9JalJ3SFGZLzou6Y/hwodyoR+AYV3jNfw3GRABY8Wirp58oE55wxHEsA3uqFYF GNkR6G4NhD6dqs2+zJwY3J+AvZ/jofEGc68UDYmusTz7l5P5LoWy+sXLh3YiB7GVntBC ME75+V+aNT/3zi+IDoeFmzb3rZnzyUhjnloiwM3Ik9FcE3dZTkA8kVDLEZNfIAlSZHC6 GMwI0vcT+YfrdKc8oCFvbyWg4pcg0BcgG9skcLfHTypa/6BEc5NhshAPV32IT2QZiqwR eWT121o+8sVs4imBrHe8oAVZw/k2ml3mEDPalrqVGLj3s2EwlCUf2zauU7U4pUF1dSAT oBzQ== X-Gm-Message-State: ACrzQf2ex+3JaFwCI7cdghUEV3aesBzxb5qkcU0GnO09BJOKj4719yli I0wx46ke3w3sI12uB0gxeKIskXdalPwe6g== X-Google-Smtp-Source: AMsMyM6L4U93atfDZcAWlJDSwRWFQeR2wrUlfXq4IzvhYb/rB5J2I3SVCyVjeztiPmcgGVBn4shX7A== X-Received: by 2002:a05:600c:1d25:b0:3b4:92de:fb28 with SMTP id l37-20020a05600c1d2500b003b492defb28mr5586916wms.202.1664537124110; Fri, 30 Sep 2022 04:25:24 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653? ([2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653]) by smtp.gmail.com with ESMTPSA id bw15-20020a0560001f8f00b0022cdeba3f83sm1767526wrb.84.2022.09.30.04.25.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 04:25:22 -0700 (PDT) Subject: Re: [PATCH][RFC] add --enable-zstd-compressed-debug-sections configure option To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , binutils@sourceware.org Cc: Fangrui Song References: <20220929201711.7nz236xraosd76za@google.com> <61355429-24b3-17d0-ab03-6fa57ee861d5@suse.cz> From: Pedro Alves Message-ID: <3d23c527-9090-8c76-bd95-a9cb440fca1d@palves.net> Date: Fri, 30 Sep 2022 12:25:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <61355429-24b3-17d0-ab03-6fa57ee861d5@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-09-30 10:48 a.m., Martin Liška wrote: > Hello. > > The patch can set up default compression algorithm as zstd instead of the > default zlib-gabi. > > The patch is lightly tested as readelf can't decompress debug sections: > https://sourceware.org/bugzilla/show_bug.cgi?id=29640 > > Thoughts? > > ChangeLog: > > * configure.ac: Add --enable-zstd-compressed-debug-sections > configure option. > * configure: Regenerate. This may become a bit awkward in the future when other better format appears, and you want to switch to use it by default. Like, imagine zstd2 is invented. At that point we'd have to decide whether to add code to error out if the user specifies both "--enable-zstd-compressed-debug-sections --enable-zstd2-compressed-debug-sections", or always pick the latter option, or some such. IMHO, it seems cleaner and more future proof to add instead: --enable-default-compressed-debug-sections=zlib|zlib-gnu|zlib-gabi|zstd WDYT? Pedro Alves