From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2075.outbound.protection.outlook.com [40.107.7.75]) by sourceware.org (Postfix) with ESMTPS id 25CCC3858415 for ; Fri, 11 Aug 2023 08:07:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25CCC3858415 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UhREfK7XufARnk+3+DE9ix6oiJYY9A48Y4YivB6YJBlDrqbj/NjGqxvCHnlViXFW6hzi/sWuEsLzOCupP0xj0zZ+4Wuosu8Xb9awhLaMLf+18wMwaUWdqdCUKNYzCu12DFhkYqVEE6bxz4YjNlVB8NRRSE5XYmMx7DborVK1mKQslji/vLods6nqpeJukzyrVBnhc0ZWwRgeeMtY/WHLVgUPv2iJa+o2v+6jPZYjxEWLYpGnW5qUdkc+kdt+kPwUqd/ccNcAxWq1YpgsP47gRcw6klkVa1yV3uLkhno00Sg2Nc4WFUnS0OH9vXIeXxOeM69jrkTeEXT8cUvkSaVACQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9cBOAHAvjoT2FJ6F9w3DrJzBVvPIvL0cQgNGBuQqQxk=; b=eHE/KT7TE5JsfF++OelLFUPiRFl0Qxyi78MnYfrisK5GK4M3OF3rSmrKaxhqsQH+VcIKVd1nEv681LX56Zlwb9yOrEQu5tcWJg4WB24lYNuwdr07O9OUZK9x2aaAGwfL7WOfNmpRdSYLSYhDzbtzjgf9i7X7Uvj0eeS8AtKnNzSN6ytcbwEB5EBI99cqn2uJ/1uPsReQLK/5GmlFX9U43gu4nxRg8cwSjtgPKqdqmLYQhYhZjjiw2htn1xZe7nWcQjXl7bRUT+DPL+QxqoKLJRL/2KksQIA/tzjPgYsvaD+chuSxB+eYg9HQ4YqZnE4kOajDl12/KaVLC9hKKAx7rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9cBOAHAvjoT2FJ6F9w3DrJzBVvPIvL0cQgNGBuQqQxk=; b=TVtFBveC9mAlpjTbcMuARzwO9veR1iycgVbKfWNIvBoy3gmeXc3SlsKti4KDvi2lhfxZ4nwqd1a54goLn62+uPoZcmzB3n0uwl5siTGVGK//vQD27pIEWRgAS/w4b0SrtA5ZDVy9fdFZOaq3dmImXumvdUJkHs7b3Xk+3GHyREn02Pu99pjmbEAUDg0FhQMMRGlsp9eVnXgS5CVCFRoMUAFSajg3aGnMD33zpsv/8KKttTOHsnFcodJKOabudn3iGyQ3084QPHdmdiIgHvZJFo/zXM9h7dET3svZr2DhoqT9OPcUtcjrURjseHV+qv2ggEBkQGw3JRRllPc/5lHLSA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7648.eurprd04.prod.outlook.com (2603:10a6:102:e4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Fri, 11 Aug 2023 08:07:52 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Fri, 11 Aug 2023 08:07:52 +0000 Message-ID: <3d540eef-9167-1559-9414-111e6c23498d@suse.com> Date: Fri, 11 Aug 2023 10:07:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: Binutils From: Jan Beulich Subject: [PATCH] gas: make S_IS_LOCAL() and S_IS_EXTERNAL() exclusive of one another Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7648:EE_ X-MS-Office365-Filtering-Correlation-Id: e16ee9dd-06fb-43c1-4219-08db9a420f6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nad1ToQ1/JIn1oUwOa6nQSmiM75JRB2LecQ7vSo9OCZYz+vZQs0Yi6lNJF0N9FWUL1S6YosbDWCAncNJZNVI/v/v1RapQu59SBfzp7Qog9aed3iCMAAMjXrZaSymf0BtqUVj/SJk/zINllJqakz4Ono1bZAyGEgSiQulsN+k15EV6q/+RWSVbmMgZASRh2XG6TFhzbqYMFNznRzcU3NwD8zUVbYvMQwIrqcA8Qc2oqwEXTHF+lGQqhdVIYiZGRvKKLcETuNEBLPkPkOFz2P2dqE00ab4+KBTyQ2V2RxuHfK/TlNPhi/vutrRILpqfhpweLtzHqx00ZKQ4aqCQBsRRalmIGLosTF0A91mBL/GRB06sxj8EU/D+Wzu+i8wXoeV/VIdq7N253FTaphUjA/LLscMMo9NgpGjFofUR49XU/DH89jqgZlFTZF/01eFFQ7AgQekYQQzSgQCzm4jdkiwbt6Dv04FEvNCDeZ1f9fQzjCLqG3KRef038gRQdSdPid2nUTqWxBTPz1x3u0Cekkm6LKSOz3WFPIVRPN6Ml8gLie78Gr9c9M6s4BEAAFDGwB72n0evh2QDx3FZT2ZhI5zfd6fcKQZTtfhMy0PXga/WgWVpFWsDXU+0Eed+PDkPkCDG4dZho+TlMIJyy+V2sIh3w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(39860400002)(396003)(376002)(346002)(1800799006)(451199021)(186006)(31686004)(316002)(41300700001)(4744005)(2616005)(31696002)(86362001)(2906002)(5660300002)(8936002)(8676002)(6506007)(26005)(83380400001)(6512007)(66556008)(6486002)(66946007)(478600001)(6916009)(36756003)(38100700002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWRPcUFJUTRTcTVUa1ZKa252L0x0LzRuSm9ZQm1DWkFWdzFFN3Z5UitDRkNF?= =?utf-8?B?dnNvRkRESlRDWUgxcWRuVGdrNUFrRFMxaENndXdpemNFWmxhT3RPTUc4YS9Z?= =?utf-8?B?cGtxT1c1WVFFNzZIOU1ZSGV1MW9RSlNWL0I4Y0l2dlJ3dkxVaDVDVWdkajRI?= =?utf-8?B?aVhkaTFuNTNzWnN1YmpXdk5IUDZvc2NZQlF1cVlLTmZTU2dXUzJpeUYwREU0?= =?utf-8?B?ZjgyQk5GWUZVeWtBLzVKRW9TWW4xS0JsUFVWVG1BMVg1Wk1mejNZL3RETDhH?= =?utf-8?B?R3JwOUEwZ25xTlQ5VUlzL3V1SzZ5akNDdHliRkN3OHd5ajd3bkZMZGZSeUFS?= =?utf-8?B?ZXJNb2lKY3ViQXROcEJqUC95T28wTVRRSGxwUlUvam5XWGk5cHdVK2dWTi84?= =?utf-8?B?UTdjVUFsOFlTdUpFUVk0b2ZuaEpYM1ZhUVh2WjRRRGU2MTM5dFM2cXFJNk5Z?= =?utf-8?B?ZU9OazFyeHQzZ1NmZVd4c016bTZYVkZVMlFQTHd6eEVYUVl5aWw1WXFoUFhl?= =?utf-8?B?SFZkUWJIWi93anQ1bDRTS2FFK2MzODlQbmovNHg0b0NZN1Qva2EvWmJCQW9y?= =?utf-8?B?ZjRkNDErWllGTzUwZjBOVDJNQUZCNC9YeTFFemU1TUgzR1lVMEdnS2ZFVWdL?= =?utf-8?B?ZXl5S0FFbldxb2NBWERrSjdTTGVUQlpveVpDUGxoOVcvVFFUUCtsQmV3TktZ?= =?utf-8?B?TWxjTW04Q3MwMzFudUEwcFRMczNVeGdkdDU1WmhrMUlqTUhMZGc0OXFNSkgy?= =?utf-8?B?VHNMZEVVa2JBTnYvMnpKTjM0VVczSjF1Vll5aHFxQ3JKRUlMTHNmelVyakpD?= =?utf-8?B?c2JSbnp3NkMzWHpMN29xeENlazBBUHUyTjdzbk1qak9lWDArL3lIcUcyUExw?= =?utf-8?B?NlhlT1lZQ2lrZVRCeHMrNkdJaUNGeHVpd1Bvc3NHNkJBeEhNYnVVSzB2cm9I?= =?utf-8?B?cHhHclJzRExBYTMvanZONXc4VllRK3ltcTBuRUs1ZXNhZXYzNXVXRzZUaWVG?= =?utf-8?B?dUxIZHFUV2d1bUF2UjJWMGluRlJVWVFCL3h6R2pEL1VGZU5sazJIbEFzU1hS?= =?utf-8?B?VlFVUzZHK00ySW5NQVdtQU9sc2VNbHc1RzZYTzVjb2l3WGdWems3L290Zk8x?= =?utf-8?B?QmFPbHcvYkdvVi8rOVZFanBkc0JoMHc1MnNsWXI3UzZpOGxaS0dGdzdZV0VR?= =?utf-8?B?dU1YUXVIL0FoNmViSE9GbXUyanYzQzM3NkcxVDBWVWtoRFIvKzlQWjdDbzhr?= =?utf-8?B?NkllU3pSdWdzNTJhajYzQ082QjVCVmgzZzd2cEFpdkJuUUE2Q2FNM05EV0tP?= =?utf-8?B?U3NvcWpPbXpmWHpBV0dIVDNYamdXN2lENjg2S0ZuSFZiTWlFNU1SUjZ2Q080?= =?utf-8?B?YjFSUkFsRDFOVExKd2NFMDF1SUpMa2V2Ujg4SGYxYVpEb0xUKzc1TDVQZXpo?= =?utf-8?B?NEdvTm9vWmp1MmFERlZkZlBPVXZ2Vi9ReHVNUVhuOXVvWVZ0SU95SElVZGxF?= =?utf-8?B?Zk5hUzhRRjZpcytFdGFFcnhGTTNBeGpsZ0hoYncvU2NFLzlKMTNHa2pMMXVa?= =?utf-8?B?MkV2bXIwZWZZTzQ2TCtJVjZJWXErRHZLVXNPbWxGSGFWU2E5d3BJS211K0tQ?= =?utf-8?B?a2YwUFRJMU5FQXdOalRMVk1lTjhnZ1B2NW1yd3BKSEFGQ25aQmpwbGw5U0Jp?= =?utf-8?B?SmZmQS8yTmpJbnA0aVpZMGdvczdyQXBXKzJkTmRmN3lER1NOQmJrV0ZJdFdz?= =?utf-8?B?V1BNSTV1d2ducUFmMCtMU3UyaDF2UjhFSjJ0cTVLOTRiNXNzWlo4aXZOc0cv?= =?utf-8?B?N2xla0toVFpFVThlUEZjck85b2VPNTgvSjRxbDJyZFlvbXhIUnlDeXBGSnZP?= =?utf-8?B?cVYrRVlsOGRDem9RZ0hrNmtYUGV0K2NDYTViOFo3aUtoN202Z2R5aWlzdkE4?= =?utf-8?B?YmZSTjUxRVNSNzU4eTI1ZWlsMXltVUw3ZmRZQW5WaXNkMnNFK0VOeGNFdklL?= =?utf-8?B?NEtsSkU4cGorbTZybXJYM1U0a3k5Z1dFZTVLcEU3dkdYWXVtNTdHVVdmYm4z?= =?utf-8?B?SXUzaS9GOHY3Q2RWd2RWeWhuQzd0U20rUnJ5bXhPOUlLU0VaQzZnTk56NzY3?= =?utf-8?Q?lUDIr2YNknzWqoHNJBXujHiHg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e16ee9dd-06fb-43c1-4219-08db9a420f6b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2023 08:07:52.2196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: soXQ0xydChp0nWAawl2V8vNXHMoEkI1O4DoJloBmA5OqqkkrGcAH2W96INYHJX5Aod5gK1NYNf3RLsVJa/b58Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7648 X-Spam-Status: No, score=-3027.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While they aren't opposites of each other, there also shouldn't be any symbol for which both return true; both may return false. Therefore use S_IS_EXTERNAL() in S_IS_LOCAL(), thus subsuming the sanity check which so far both did alike. --- a/gas/symbols.c +++ b/gas/symbols.c @@ -2420,15 +2420,14 @@ S_IS_LOCAL (symbolS *s) if (s->flags.local_symbol) return 1; - flags = s->bsym->flags; - - /* Sanity check. */ - if ((flags & BSF_LOCAL) && (flags & BSF_GLOBAL)) - abort (); + if (S_IS_EXTERNAL (s)) + return 0; if (bfd_asymbol_section (s->bsym) == reg_section) return 1; + flags = s->bsym->flags; + if (flag_strip_local_absolute /* Keep BSF_FILE symbols in order to allow debuggers to identify the source file even when the object file is stripped. */