From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80054.outbound.protection.outlook.com [40.107.8.54]) by sourceware.org (Postfix) with ESMTPS id 4DCA63858C60 for ; Fri, 11 Nov 2022 08:22:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4DCA63858C60 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gaM68OdxVnNV+MEqBa1QoNrW7+dG7C8KD1cu4B2VRvc+3sm137vUEQc7Qq1TmnrKD5hpitb8urVzeruJBeDnBYl9K8UOGVWcAn0CMlfMPBpcTf3WCesmtx1FHnLm48f0w3O7HfsbSZabyDMploGVreFBcv+e8UI1A/osMbk+GBTySfquHTk06jPj7bjL/ofpzPKywK/QZMFooZuzdgDWrVs0xr9f3rQzJkXh0sjmvTr2SpKvaYFwov3acXy87AI20mLVQqnaV34CJk9eOnL4tdeGnWIyM1gmsA15KQ32gMYnzj1Efr76s3PTzKHTfaomaJNtXIZdr1Rc5klv4n+x6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ILWHjgh/C47Fr4yGLJY7YAGnXqPABpJpDXAT3Eva5vY=; b=gYaSfCr2PPqide63kryRIKLb+pRensRx8uiisKV+j+nNLq6gUKyp6QZ2nA5xdCZ1zOwlsSy4jYlTOMnQGaxoaBUXIUyn6VSnoAkjf7BLIbhLuH1EPCrKlHxTa35TbJQ1Qcn7eiocneMx4UqA5pQUJnZf0kd5vRlvg3VjmxwGOyyyM9sHzvxyACwBAB2efgE3hv2BP9wtfyqcmHAfWOyRCMeMKnVsGTxu2f49rh4yJRB6MkawnDWb4OGu0P7n/aJ7tS7Xe0/0MxWWbl/bOe5OY6yhWEjurJUH2tQZUn3wNCjb7UCfYeOHFWuHYKADc3ttLzGd9yhUBKXomXvQCO88hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ILWHjgh/C47Fr4yGLJY7YAGnXqPABpJpDXAT3Eva5vY=; b=MWQYov3xpmN5Glgu0ZWvG5l0K1T7UCUwoVYhsxg0UIX2ZfoxsQlThkRceBDVpyB88l+WapF1sOtMU3UEyQhD8mU4paGXe8hg4ak+ClL4Clv46EHMwL959r9YRQdFmKpJ6yZSDJi694ZebMQkQrW6Tyl4iAKezbpwa32zLG8yKyLH/yABC8QpDw6TNWRafkancLhTh+xGozmO7xvO7AGa4fHGjk4Sv27C9yfsRNBt9tTGXUGD0GaDwnlKkbfnZD3pdOUnkOuDJdCNJlO3zm/TV0d1+9tgU+2aYXkaqfWUuIc/MPH9jaa/HFo5EC57ThcHxsDoQT2VPF+Kx4gUY+zwYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8410.eurprd04.prod.outlook.com (2603:10a6:10:24b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 08:22:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Fri, 11 Nov 2022 08:22:20 +0000 Message-ID: <3d6d6d28-d4ed-5871-e20b-62aaa89ca6d4@suse.com> Date: Fri, 11 Nov 2022 09:22:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] x86: fold special-operand insn attributes into a single enum Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <21665493-a9f9-3429-c9ae-ea69bc7751e2@suse.com> <2a971dfe-00b6-856b-5f3b-8a1cd7dc78c6@suse.com> From: Jan Beulich In-Reply-To: <2a971dfe-00b6-856b-5f3b-8a1cd7dc78c6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0080.eurprd06.prod.outlook.com (2603:10a6:20b:464::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8410:EE_ X-MS-Office365-Filtering-Correlation-Id: e9b5c6a3-2dba-4fe1-77f1-08dac3bdd9da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GmNFltazOMOQB+LvX6fIKR2jVSph6bYGmC2RkFzg5lutMaKRu1XjS98RzGDeRvav09XdakhkBgk4c3vvDgOc89JaK14NZmX1zpgEFai5JGbKZ36KZ/dsVVIdYsFilGGSYQiL1W1HUOAaAqE2ZZH/DJzKkU9YXzVoTmyQz856YjbYQ7rwyLrTnHaOCHnHfV2ZAtBybb9WHWUEEO+Ob29Z1ASarcfFJh+jSRQOMQrENHXYPukhvBRd4/c/+jwOtN64wKAf5mo/n3PrCP0V0K0QdrxLp9u4o8Se0639E/aKedd4bE3DY3Ylyz6IK0CpwWpLvBIZ9XJQpb688LOuVh2OCMx+yb181AlapPZghOa/1L00uskJcUGsZHPFohoKEE1gz1e3DghDfLMcUbRu6lI3LTfnkB57uSyJjrzfR+ZaqPjLyf06qlWWJJ794edVhZo0XIT3+yc8usNDlH6w3J25uxZJaycJlvRs1zT+9SFkXKhXysZVa+XLrq0NovIyT/rSLiBP3prVrE7dMwxN7YDqMxj5/nJzyb6qyARoBWMonq0JP+IlHPHlzhwEStEjc6GGIt5o23inbFmWF4+mfK/vnmsHWICv5Ed5K3KlG+PvFhtn30GLyPpM/8pf7Dh+VoxeFwsT9MhzlYp9ckeOKOtRe9rxklxZnqhOHslXoCCDy9I61LcWA2ForEgZpbjyU9Q0OU1b98LQKsSuUpkfp3LAyz7ljNxcJcdvWUa1lDa+UmmZah9JgW8W8hpTh/PphZvfWFJ+C0BMc1E+UCbi4GXDKk8MGSuanT+QhKYR/+hCYjM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(366004)(39860400002)(346002)(451199015)(6486002)(478600001)(31696002)(86362001)(31686004)(316002)(38100700002)(6506007)(6916009)(53546011)(6512007)(26005)(83380400001)(41300700001)(36756003)(66946007)(2906002)(5660300002)(8676002)(66476007)(66556008)(186003)(4326008)(8936002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3g5TWJQMDRiSFNCN1VXUTRWenlNcEg5MVNnbWtwT21CbVplTnhTaHEvb0VK?= =?utf-8?B?RnVQYk5FbFV5NjhBN2R1UU1uMUhhcUFwMnZXdEliTWdZaS9qcDJrMjAzaitK?= =?utf-8?B?ejhSTlZlZmhraElQYVlkRW9TK1Z5Zno5SDJxSDJOL3R4TTQwZ1ZPUk9BZ3JK?= =?utf-8?B?RmVwTFpBK1lLazR0bjE0NGNhNUc0OGJhaWdqM1BlTm5BMWk4ZERXbzU0NEpV?= =?utf-8?B?cVhOQXFhSWE1Wk1GS0c1VTR4K0VyNGtDdFlPMW54QnBkZU9hRm5wYjQxNkJF?= =?utf-8?B?S0duc3JuZ1FsOVBrMkZRUmZMQ1NsQ1hKTWsvcEw5MHZWNHN0dVdzQzg4UGpW?= =?utf-8?B?YXRxZytGVzh1aEZvQ2JoVEdtVUNGajd1OUQ1N3B6Vk5tYlphMG1NUWJBeTlu?= =?utf-8?B?aVZtMUlzeDJTUXlZdDR6eEJOWERIK2xlRWl1aDh0cFQ0UlVFV0hENWQ2WTlq?= =?utf-8?B?a1JKazJlRXVVN2JPL3lWb1JHR3JURHUzSi9IYU5hLzlLYktDcVlaREpjYjNQ?= =?utf-8?B?d1lHNVFOclM5MjZCN3FEN1NUMzVGNzk5ci93N2NXTGduTzdBRjl6R05HUm9H?= =?utf-8?B?VGgwZmJkMTJCWmgxcGNoNDdRdm0ybVdjMWtndWg5RStBNW1SNWN6N25uZkZS?= =?utf-8?B?ZEoxNFFKTndLRkhyTHdVenBZZHZSMXFpK3N2bFFRLzUwc1dHUEZ2aFplWWlk?= =?utf-8?B?VmpZTUpndDZKZmNrRnFuZ2ZKYXpiTkxYd2dOcWkrbjYrNG1yai9SUVRkSzJ3?= =?utf-8?B?T3NPVVpzdUp4MkVTV3dobGRpa0Vmb2hsa3hZcVN3bWtxTVhHSmNHcno3dmdQ?= =?utf-8?B?QlJOV3E2bmxFTjRKQnE5ZHhMT293V25XcCtIMVoxSmM3ZkpVTFlhZEFQNmFZ?= =?utf-8?B?dGM1VGxBTU1FcGtUZzd6U051YW1naHJzc3lrTktmNk12UVpzb25IY0FsUVZs?= =?utf-8?B?VDBOc2RvV0p5bUFVM1hvalhWVFM3VGtrY2tvakU5c3N3TDEwYjEyY2lDcmEy?= =?utf-8?B?UENWTGRMMEpvTk5DWDRCMnZ4NDZWcjZrbHp4LzluQmxJeWlpUlY4Z0puREc5?= =?utf-8?B?R2tGdUpoVExndXdSQmdCVmZzcFRIRlpHQmVGV205cDJtc3kxWm9Sd0RlNzdB?= =?utf-8?B?TTllU1FnQTArbG1RaDRpc0tYZDVMejVSRlVweDB6YklLazBiTlBQZTJpYlpD?= =?utf-8?B?QTlEYTNNSGhLandwUEFzWmpMNjU0RGIxdGhpc1ZrZUxzelZMMStnUHMyNVBK?= =?utf-8?B?aG8yTThIRndkU3RFdHhHYitURkFJYldyQ0lLRXNmTytwbUFwR2dvamxZcTkz?= =?utf-8?B?cmNGWTdKZ1Q1MCsxU3BjT21QVk9jd3grRUM4VmozQ1MxYXd0L3RKenUxazJx?= =?utf-8?B?dzg2ZVRNVWVzR3hwdkZkRGxHV2ExaGpSNmxDcFFQWEVJNXNIZWdIY0NUVHVH?= =?utf-8?B?YUdBd1cwMlAyOEZQQ0xSNldES3lSSU9KeSszUEtzblVUQXdOcjdFeHFxYlVD?= =?utf-8?B?UkZwMDNJcW01dm1xVDAzcWdJUjRhNkFyT3dZME12Z0w2VDZxNVpwMVF1Y0E1?= =?utf-8?B?aU1rb0QwUjJUcXJFSWswL1R2bVh1dGl3T3RwVzU4VjJ3c1ZuSEdRUHN2STAv?= =?utf-8?B?ZmdaTFBoa1MwOFBBck1Zb0FDV1cxWUtWS3VqcVQvZk5rdGpMNWdwRGJmbjZ4?= =?utf-8?B?NmFpMHVVcUJuUHM5YnJvc1pDUnBUZldyNlE2b0p5Ulp0UU5uRTJtUTlsTFlw?= =?utf-8?B?L2JxUkh2eXExclVnZWpLWU5CUU5qbzJJZElRdHZrazYySWZUSjVZd3p6TlFr?= =?utf-8?B?ZldnRG56b3MyQ29Zbmo0TE5tZm5MWFlVY0l1eEtBMyszRlY1UmhxMktXK0xY?= =?utf-8?B?WDUvcjlXQnZ6QVJFTTlnRkRibndQM2tISWtqd3JmOWVNcEJZeG05TVY4dTE0?= =?utf-8?B?dXpmcm9TTXpuaEN2SWlQZm9KcGFpMEV1RTFmcVA3WUVFbGpkaWRmeTJQWVFp?= =?utf-8?B?UnY4VnVuR09RSEdDNElheWVRRkVJMTBtc3dhKytrZTFiQ3NzZk4yWmlSQTU4?= =?utf-8?B?UHJOT2lCUUduL3NXTXROY05wbmpvcUNjczcwbHQrUkpHaE1TbnI3ek90aEl3?= =?utf-8?Q?L/EhPmCB39zD7CJ7b8cQVAt+w?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9b5c6a3-2dba-4fe1-77f1-08dac3bdd9da X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 08:22:19.9273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1ffwxZKiLq2TDWvVqkHC+FkvnNpkpw8/7d+t6u1kZAYwP0MBEOK5on6SVPzpZSyq6Y2tVmFzEsqkLI6M9e60VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8410 X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11.11.2022 09:00, Jan Beulich via Binutils wrote: > On 10.11.2022 18:38, H.J. Lu wrote: >> On Thu, Nov 10, 2022 at 5:45 AM Jan Beulich wrote: >>> >>> Attributes which aren't used together in any single insn template can be >>> converted from individual booleans to a single enum, as was done for a few >>> other attributes before. This is more space efficient. Collect together >>> all attributes which express special operand constraints (and which fit >>> the criteria for folding). >> >> These assumptions may not be all true for future new instructions. > > It seems pretty unlikely to me that any of these assumptions would break. > If one does, converting back to an individual bit is an easy option. I > think this minor risk is far outweighed by the benefits of the change. We > really have still some ways to go to reach reasonable data representation > within the generated opcode table (and of course also in the source table, > but that's an orthogonal direction of work, where I also have further > changes pending). I should probably expand: For most of these I don't expect new uses to appear at all. Note also that I left alone e.g. ImmExt, for having a bigger risk of a new conflicting use appearing. If you have concerns for a specific attribute, please voice it that way. I'm certainly willing to re-consider for individual attributes (albeit as said in the earlier reply, the way back for any individual one is easy); I'm not going to accept a blanket "no". Jan