From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 320A93858281 for ; Mon, 8 Aug 2022 11:06:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 320A93858281 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-185-PT5ezzu7OZCpNxkFxZtK_Q-1; Mon, 08 Aug 2022 07:06:15 -0400 X-MC-Unique: PT5ezzu7OZCpNxkFxZtK_Q-1 Received: by mail-wr1-f70.google.com with SMTP id c7-20020adfc6c7000000b0021db3d6961bso1348084wrh.23 for ; Mon, 08 Aug 2022 04:06:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=ifANFqwWlnU4+ims14FD9rAyoEeg/HFlO0JWqyFO8I4=; b=pQtILsmYzNKTWTol6NJVa3zlZcWmBuoWGW0iMdV8qxgPv2FRk18+ykjhsTbh4vsvci 5qwaqzWoC+hXrrS/MEMuGneCOddhUidR+JRAe3+8ggIFMQIYeUmuc1pfb8443uRTbvLn EFR+t5y6I78iruUofKIk4R3HEAx4fB8ICS/dtbe8ECIZWDn1S+Afv9ewbmkngR0Gagje Q/XOlmdzrInxx32B25AKxpZ4qB+tpWCxz6SwKma2jKLPkCZSr2dkNoYaCoUbWQRT2qEq zwgQNJkpc/MAqp74FnHt8E4d99mzHPPTiUdwSwUO6zCAwGFYh4p+R06fKfCWFNLDjoKf 62OA== X-Gm-Message-State: ACgBeo26N5uf7ludTDq3U6mG7AnbetdH5cQDhir3Sh0oBAXvxwW8kztV a9gdBz6LREAro8JrV+copk53MOWyWHENySNIajNmRikZ8A+wSP3ehKgkxnSS/IR1HNyN/NlVrbz CoAE5u1RjELgx7xQXuw== X-Received: by 2002:a05:600c:4e03:b0:3a5:1755:8498 with SMTP id b3-20020a05600c4e0300b003a517558498mr10733728wmq.137.1659956774517; Mon, 08 Aug 2022 04:06:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR6r4/pNXuOggudgZysiG/LujjiOPEJiQuJmxZQVET92WxtWD4hq2xAp5BsxgWKlvYr9NloN3g== X-Received: by 2002:a05:600c:4e03:b0:3a5:1755:8498 with SMTP id b3-20020a05600c4e0300b003a517558498mr10733718wmq.137.1659956774368; Mon, 08 Aug 2022 04:06:14 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id b13-20020adff90d000000b0021e5adb92desm10913038wrr.60.2022.08.08.04.06.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Aug 2022 04:06:13 -0700 (PDT) Message-ID: <3d6dbb89-9084-1a79-dac8-eb11cebaba03@redhat.com> Date: Mon, 8 Aug 2022 12:06:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] dwarf: use find_abstract_instance for vars and DW_AT_specification To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , binutils@sourceware.org References: From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2022 11:06:18 -0000 Hi Martin, > bfd/ChangeLog: > > PR 29442 > * dwarf2.c (struct varinfo): Use const char * type. > (scan_unit_for_symbols): Call find_abstract_instance for > DW_AT_specification for variables that can be in a different CU > (e.g. done by dwz) Approved - please apply. I would ask for a testcase as well, but I am not sure if one could be constructed that was independent of dwz. Cheers Nick