From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH 1/2] x86: drop redundant calculation of EVEX broadcast size
Date: Fri, 24 Feb 2023 14:08:25 +0100 [thread overview]
Message-ID: <3dba3751-3fa1-0684-b98c-2c383f26c5a6@suse.com> (raw)
In-Reply-To: <e79bbf7f-351d-d455-dcee-fcf47b0d6758@suse.com>
In commit a5748e0d8c50 ("x86/Intel: allow MASM representation of
embedded broadcast") I replaced the calculation of i.broadcast.bytes in
check_VecOperands() not paying attention to the immediately following
call to get_broadcast_bytes() doing exactly that (again) first thing.
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -6409,9 +6409,6 @@ check_VecOperands (const insn_template *
return 1;
}
- if (i.broadcast.type)
- i.broadcast.bytes = ((1 << (t->opcode_modifier.broadcast - 1))
- * i.broadcast.type);
operand_type_set (&type, 0);
switch (get_broadcast_bytes (t, false))
{
next prev parent reply other threads:[~2023-02-24 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 13:07 [PATCH 0/2] x86: assorted small tidies Jan Beulich
2023-02-24 13:08 ` Jan Beulich [this message]
2023-02-24 13:09 ` [PATCH 2/2] x86: use swap_2_operands() in build_vex_prefix() Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dba3751-3fa1-0684-b98c-2c383f26c5a6@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).