From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18106 invoked by alias); 14 Feb 2020 21:08:11 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 17033 invoked by uid 89); 14 Feb 2020 21:08:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:83pnehn, H*i:sk:83pnehn, H*MI:sk:83pnehn X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Feb 2020 21:08:09 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 01EL80cF025533 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Feb 2020 16:08:05 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 01EL80cF025533 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1581714486; bh=5wBvO4hrTJ0twwBCkk1Pmvr5SGi+Oqa6IJN+GGQNUlE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=G6uYmoTxAoWtmzSsRum1QtiE/NAKr6U/5jm+onyKOvlxl70lnVZaRaPkHVyW8zTXK 0iU9LZvvGAPuWkSJtaez4sOFE95P/6Rn25GYjtE5kaJPTwPq5xlrKqJmd33OWcfj5S x26QyQsdKdnyaaRQOh2zlLzt1HTp+PTnPsIydFG4= Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0494B1E5F8; Fri, 14 Feb 2020 16:07:59 -0500 (EST) Subject: Re: Using the vcs_to_changelog.py script To: Eli Zaretskii Cc: binutils@sourceware.org, gdb-patches@sourceware.org References: <83imkbqhry.fsf@gnu.org> <83a75mqyry.fsf@gnu.org> <675991ee-28c0-ce5a-6327-c6ad80ccb1c3@polymtl.ca> <837e0qqpps.fsf@gnu.org> <83blq1pknp.fsf@gnu.org> <83pnehncwe.fsf@gnu.org> From: Simon Marchi Message-ID: <3dc19ede-66d8-e329-3fc8-e0e88c25ef93@polymtl.ca> Date: Fri, 14 Feb 2020 21:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <83pnehncwe.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00371.txt.bz2 On 2020-02-14 3:15 p.m., Eli Zaretskii wrote: > So I think it would be good to have some guidelines about that. > >> I would therefore suggest adding: >> >> - What's the problem you're trying to fix (compilation error? if so please >> paste it in the commit log?) >> - Why is this the right way to fix it? > > Something like that, yes. I'm saying that we should have this on the > wiki. I think it's already quite well addressed by this section in the contribution checklist: https://sourceware.org/gdb/wiki/ContributionChecklist#Detailed_Explanation_of_the_Patch Simon